unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Fatima Toothpaste <fatimatoothpaste@disroot.org>, ludo@gnu.org
Cc: 54273@debbugs.gnu.org
Subject: [bug#54273] [PATCH V2] gnu : nicotine+: Update to 3.2.1.
Date: Sun, 13 Mar 2022 12:06:10 +0100	[thread overview]
Message-ID: <c4ce5882f2c171e6316b2b6be2735794eaff5709.camel@telenet.be> (raw)
In-Reply-To: <20220313011414.10351-1-fatimatoothpaste@disroot.org>

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

Fatima Toothpaste via Guix-patches via schreef op zo 13-03-2022 om
10:14 [+0900]:
> +         (replace 'check
> +           (lambda _
> +             (invoke "python" "-m" "unittest"))))))

"./pre-inst-env guix lint nicotine+" would warn about this.
To make the '--without-tests' package transformatin work, this needs to
be:

> +         (replace 'check
> +           (lambda* (#:key tests? #:allow-other-keys)
> +             (when tests?
> +               (invoke "python" "-m" "unittest")))))))

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2022-03-13 11:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-06  5:45 [bug#54273] [PATCH] gnu: nicotine+: update to 3.2.1 Fatima Toothpaste via Guix-patches via
2022-03-11 22:11 ` Ludovic Courtès
2022-03-13  1:14   ` Fatima Toothpaste via Guix-patches via
2022-03-12 13:59 ` [bug#54273] [PATCH V2] gnu : nicotine+: Update " Fatima Toothpaste via Guix-patches via
2022-03-13  1:14 ` Fatima Toothpaste via Guix-patches via
2022-03-13 11:06   ` Maxime Devos [this message]
2022-03-13 15:45     ` Fatima Toothpaste via Guix-patches via
2022-03-13 15:41 ` [bug#54273] [PATCH V3] " Fatima Toothpaste via Guix-patches via
2022-03-15  9:52   ` bug#54273: [PATCH] gnu: nicotine+: update " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4ce5882f2c171e6316b2b6be2735794eaff5709.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=54273@debbugs.gnu.org \
    --cc=fatimatoothpaste@disroot.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).