From: Maxime Devos <maximedevos@telenet.be>
To: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>, 55997@debbugs.gnu.org
Subject: [bug#55997] [PATCH staging 2/4] gnu: Remove texlive's dependence on ruby-rspec and ruby-byebug.
Date: Wed, 15 Jun 2022 23:06:34 +0200 [thread overview]
Message-ID: <c3c1114698716a2b1db787a970cc9f3b4464b345.camel@telenet.be> (raw)
In-Reply-To: <20220615150434.11604-2-tom@tom-fitzhenry.me.uk>
[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]
Tom Fitzhenry schreef op do 16-06-2022 om 01:04 [+1000]:
> +index 12831417..df6daa39 100644
> +--- a/lib/tex/hyphen/language.rb
> ++++ b/lib/tex/hyphen/language.rb
> +@@ -1,6 +1,5 @@
> + require 'yaml'
> + require 'hydra'
> +-require 'byebug'
> +
> + require_relative 'path'
> +
I recommend a small description: ’Avoid dependency on byebug to reduce
package closure significantly, see https://issues.guix.gnu.org/55997’.
Also, patches need to be added to gnu/local.mk because $reasons.
> (sha256
> (base32
> "04xzf5gr3ylyh3ls09imrx4mwq3qp1k97r9njzlan6hlff875rx2"))))
> @@ -225,7 +226,7 @@ (define (texlive-hyphen-package name code locations hash)
> (invoke "ruby" "generate-ptex-patterns.rb")))))))))
> (native-inputs
> `(("ruby" ,ruby)
> - ("ruby-hydra" ,ruby-hydra)
> + ("ruby-hydra-minimal" ,ruby-hydra-minimal)
> ("hyph-utf8-scripts" ,hyph-utf8-scripts)))
While we are rebuilding anyway, could you eliminate input labels (in a
separate patch)?
(native-inputs (list ruby ruby-hydra-minimal hyph-utf8-scripts))
Anyway, the concept looks good to me, though I haven't done any
practical testing!
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-06-15 21:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 14:58 [bug#55997] [PATCH staging 0/4] Remove texlive's dependence on mariadb Tom Fitzhenry
2022-06-15 15:04 ` [bug#55997] [PATCH staging 1/4] gnu: Add ruby-hydra-minimal Tom Fitzhenry
2022-06-15 15:04 ` [bug#55997] [PATCH staging 2/4] gnu: Remove texlive's dependence on ruby-rspec and ruby-byebug Tom Fitzhenry
2022-06-15 21:06 ` Maxime Devos [this message]
2022-06-19 14:01 ` Tom Fitzhenry
2022-06-19 14:47 ` Maxime Devos
2022-06-15 15:04 ` [bug#55997] [PATCH staging 3/4] gnu: unpin ruby-nokogiri-diff's ruby-nokogiri Tom Fitzhenry
2022-06-15 15:04 ` [bug#55997] [PATCH staging 4/4] gnu: Remove unused ruby-nokogiri-1.10 Tom Fitzhenry
2022-06-19 21:36 ` [bug#55997] [PATCH staging 1/4] gnu: Add ruby-hydra-minimal Thiago Jung Bauermann via Guix-patches via
2022-06-24 11:08 ` [bug#55997] [PATCH staging v2 0/5] Remove texlive's dependence on mariadb Tom Fitzhenry
2022-06-24 11:08 ` [bug#55997] [PATCH staging v2 1/5] gnu: Add ruby-hydra-minimal Tom Fitzhenry
2022-06-24 11:08 ` [bug#55997] [PATCH staging v2 2/5] gnu: Remove texlive's dependence on ruby-rspec and ruby-byebug Tom Fitzhenry
2022-06-24 11:08 ` [bug#55997] [PATCH staging v2 3/5] gnu: Unpin ruby-nokogiri-diff's ruby-nokogiri Tom Fitzhenry
2022-06-24 11:08 ` [bug#55997] [PATCH staging v2 4/5] gnu: Remove unused ruby-nokogiri-1.10 Tom Fitzhenry
2022-06-24 11:08 ` [bug#55997] [PATCH staging v2 5/5] gnu: texlive-hyphen-package: Remove input labels Tom Fitzhenry
2022-06-29 9:32 ` [bug#55997] [PATCH staging v2 0/5] Remove texlive's dependence on mariadb Tom Fitzhenry
2022-07-01 2:07 ` Thiago Jung Bauermann via Guix-patches via
2022-08-08 15:25 ` bug#55997: [PATCH staging 0/4] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3c1114698716a2b1db787a970cc9f3b4464b345.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=55997@debbugs.gnu.org \
--cc=tom@tom-fitzhenry.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).