From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>, Dariqq <dariqq@posteo.net>
Cc: 70282-done@debbugs.gnu.org, Vivien Kraus <vivien@planete-kraus.eu>
Subject: bug#70282: [PATCH v4] gnu: gnome-shell: Wrap screencast service.
Date: Tue, 14 May 2024 07:34:58 +0200 [thread overview]
Message-ID: <c3ac5f23668dcb9201a43cb8d4b075baa92a2535.camel@gmail.com> (raw)
In-Reply-To: <87a5kz2eb6.fsf@gmail.com>
Am Donnerstag, dem 09.05.2024 um 11:30 -0400 schrieb Maxim Cournoyer:
> Hi Dariqq,
>
> Dariqq <dariqq@posteo.net> writes:
>
> [...]
>
> > > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> > > > index 92e35e3c5a..4bbff2a89b 100644
> > > > --- a/gnu/packages/gnome.scm
> > > > +++ b/gnu/packages/gnome.scm
> > > > @@ -9408,6 +9408,7 @@ (define-public gnome-shell
> > > > (add-after 'install 'wrap-programs
> > > > (lambda* (#:key inputs #:allow-other-keys)
> > > > (let ((gi-typelib-path (getenv
> > > > "GI_TYPELIB_PATH"))
> > > > + (gst-plugin-path (getenv
> > > > "GST_PLUGIN_SYSTEM_PATH"))
> > > > (python-path
> > > > (string-join
> > > > (filter (lambda (item)
> > > > @@ -9427,6 +9428,19 @@ (define-public gnome-shell
> > > > "path =>
> > > > imports.gi.GIRepository.Repository."
> > > >
> > > > "prepend_search_path(path));\n"
> > > > all)))
> > > > + ;; Screencast requires a pipewire service
> > > > running
> > > > + ;; (i.e. as provided by home-pipewire-
> > > > service-type)
> > > > + (substitute* (string-append #$output
> > > > "/share/gnome-shell/"
> > > > +
> > > > "org.gnome.Shell.Screencast")
> > > > + (("imports\\.package\\.start" all)
> > > > + (string-append "'" gi-typelib-path
> > > > "'.split(':').forEach("
> > > > + "path =>
> > > > imports.gi.GIRepository.Repository."
> > > > +
> > > > "prepend_search_path(path));\n"
> > > > +
> > > > "imports.gi.GLib.setenv('GST_PLUGIN_SYSTEM_PATH',"
> > > > +
> > > > "[imports.gi.GLib.getenv('GST_PLUGIN_SYSTEM_PATH'),"
> > > > + "'" gst-plugin-path
> > > > "'].filter(v => v).join(':'),"
> > > > + "true);\n"
> > > > + all)))
> > > Perhaps a simple patch would convey the change better and be
> > > easier to maintain in the future / be readily available for other
> > > distributions to use.
> >
> >
> > The simple patch that would do this is basically the patch from
> > nixos in v1 of this which adds a shebang line for gjs to the
> > service invocation files (rather than the dbus service invoking
> > $gjs $service). The problem then is that wrap-program changes the
> > filename to * .real which makes gjs unhappy.
> >
> > The people from nix circumvent this by using some js at the
> > beginning to reset the entrypoint to the correct value.
> >
> > One nice way around avoiding the problem would be using wrap-script
> > instead though that does not support gjs as interpreter (yet?) and
> > adding that forces a rebuild of all packages due to (guix build
> > utils) changing.
>
> It'd be nice to prep such support on core-updates. You can test it
> on master by having a (guix build utils-next) module that you
> explicitly use.
>
> > Maybe another comment, similiar to the one Liliana suggested
> > earlier in this thread, could be added at the beginning to inform
> > about changing to wrap script + patch instead once that is a viable
> > option?
>
> That could be a good reminder to have, yes.
I've pushed the current version as-is, without reminder, so that we can
at least mark the issue done. If someone has a good text to add,
please don't hesitate to do so in post. Also don't hesitate to submit
new stuff to gnome-team or core-updates after the pending merges are
through.
Cheers and thanks for all the hard work :)
prev parent reply other threads:[~2024-05-14 5:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 15:39 [bug#70282] [PATCH 0/2] Fix gnome-shell screenrecorder Dariqq
2024-04-08 15:53 ` [bug#70282] [PATCH 1/2] gnu: gnome-shell: Wrap d-bus services Dariqq
2024-04-08 16:54 ` Liliana Marie Prikler
2024-04-09 15:35 ` Dariqq
2024-04-09 17:04 ` Liliana Marie Prikler
2024-04-10 8:07 ` Dariqq
2024-04-10 18:20 ` Liliana Marie Prikler
2024-04-11 9:04 ` Dariqq
2024-04-08 15:53 ` [bug#70282] [PATCH 2/2] gnu: gnome-essential-extras: Propagate pipewire Dariqq
2024-04-08 16:49 ` Liliana Marie Prikler
2024-04-09 14:05 ` Dariqq
2024-04-12 17:26 ` [bug#70282] [PATCH v2] gnu: gnome-shell: Wrap screencast service Dariqq
2024-04-19 18:51 ` Liliana Marie Prikler
2024-04-20 10:11 ` Dariqq
2024-04-20 10:46 ` Liliana Marie Prikler
2024-04-21 12:37 ` Dariqq
2024-04-21 12:43 ` Liliana Marie Prikler
2024-05-08 12:57 ` [bug#70282] [PATCH v3] " Dariqq
2024-04-21 17:02 ` Dariqq
2024-05-08 17:24 ` Liliana Marie Prikler
2024-05-08 18:33 ` [bug#70282] [PATCH v4] " Dariqq
2024-05-08 19:51 ` Maxim Cournoyer
2024-05-08 21:18 ` Dariqq
2024-05-08 22:11 ` Liliana Marie Prikler
2024-05-09 8:27 ` Dariqq
2024-05-10 14:59 ` Dariqq
2024-05-10 16:04 ` Liliana Marie Prikler
2024-05-11 8:03 ` Dariqq
2024-05-09 15:30 ` Maxim Cournoyer
2024-05-14 5:34 ` Liliana Marie Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3ac5f23668dcb9201a43cb8d4b075baa92a2535.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=70282-done@debbugs.gnu.org \
--cc=dariqq@posteo.net \
--cc=maxim.cournoyer@gmail.com \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).