From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SCl9As90X2Ci0gAAgWs5BA (envelope-from ) for ; Sat, 27 Mar 2021 19:09:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UALfN850X2DxeQAAbx9fmQ (envelope-from ) for ; Sat, 27 Mar 2021 18:09:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 844A92A2BE for ; Sat, 27 Mar 2021 19:09:18 +0100 (CET) Received: from localhost ([::1]:55270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQDN6-00065Z-SD for larch@yhetil.org; Sat, 27 Mar 2021 14:09:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQDMs-00065F-Kd for guix-patches@gnu.org; Sat, 27 Mar 2021 14:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQDMs-0007Zn-Da for guix-patches@gnu.org; Sat, 27 Mar 2021 14:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQDMs-0002wf-7N for guix-patches@gnu.org; Sat, 27 Mar 2021 14:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47435] gnu: mail: Make the sendmail package actually output its binary Resent-From: =?UTF-8?Q?L=C3=A9o?= Le Bouter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Mar 2021 18:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47435 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Rovanion Luckey , 47435@debbugs.gnu.org Received: via spool by 47435-submit@debbugs.gnu.org id=B47435.161686848811259 (code B ref 47435); Sat, 27 Mar 2021 18:09:02 +0000 Received: (at 47435) by debbugs.gnu.org; 27 Mar 2021 18:08:08 +0000 Received: from localhost ([127.0.0.1]:44899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQDLz-0002vW-W9 for submit@debbugs.gnu.org; Sat, 27 Mar 2021 14:08:08 -0400 Received: from mail.zaclys.net ([178.33.93.72]:45517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQDLw-0002v0-I0 for 47435@debbugs.gnu.org; Sat, 27 Mar 2021 14:08:06 -0400 Received: from guix-xps.local (82-64-145-38.subs.proxad.net [82.64.145.38]) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 12RI7vYJ016285 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 27 Mar 2021 19:07:57 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 12RI7vYJ016285 Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1616868478; bh=C8tRnL2gjPiZL2i7EC0GnxdD59Jt/K3yv4Hf84kBFDQ=; h=Subject:From:To:Date:In-Reply-To:References:From; b=Ax7Mhj7OYM4UW3F8EBhWeVt9P1DHu6SaO8uy3tq3Bs0sMSgUtxGyhLq/UqG+BuLUo iwPpRkpA89dD4U1OO2ZJWGFUeN3hQDSy2TELwxhOy1LphJE7//SldbqyJvzaGiGXiD Y3w6XI1F1UaPwwJVze5H7KWiPX/Pjsfnr0eWQSqI= Message-ID: Date: Sat, 27 Mar 2021 19:07:52 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-U4Kv2CkJkMbdTyQ8X4hf" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: =?UTF-8?Q?L=C3=A9o?= Le Bouter X-ACL-Warn: , =?UTF-8?Q?L=C3=A9o?= Le Bouter via Guix-patches From: =?UTF-8?Q?L=C3=A9o?= Le Bouter via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616868558; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=C8tRnL2gjPiZL2i7EC0GnxdD59Jt/K3yv4Hf84kBFDQ=; b=BvV51bGbIaPmvK8qOJXV6zwC/YP6RabJ2xeSOYP2ISEm/dTE6e8YAZ8KEfwCNM2EIqOI4z jeGrcyFCL/z444dpCrSkdC01hwHwlBfEs5PJjjidZ+ppgwFh71gh2VkrQcnIVTiQsZ/eDE dm+ELlEaZ/PRp9mNYYoMHogOsKmQQrJDXnDH2rdgX5nthxei1D0I1erPUuhrnd/l6Pd14y HpsD6KHukmogbQz8UPkRDlx7a0JdQVNZlExp7nicYTsagoPsYq9TC3cDwv6CAqGvDVKYkf UysQQcBEqccsXpfUEH2fpv6JRz4kc4WEJgx1WtgMbgV4mepXd5LupzzlZb2OxQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616868558; a=rsa-sha256; cv=none; b=a/liorokKzODv5zwzkjJdJgb85Nd8W80/ih/WlEWySGZsj/K3X7ed7aMgY4LgrzyKIt93p TyECZsMBkPMI3uKfgVwKnmBLCbxwXf/dYlKdqHiFVpv8tN7TqE8jkPZ4DquWeHsixX7fla qupSatYgy+4CjYdkG+nsi6B0YlDWwoOBmV1zy/N4cBT7KjSfJT/YakFvTg95uRsLrNXV24 P8YB4MrXPdEkJS8Uu5lIqknAXH1OhDYyBYGSSh52xvuGNx/GvaSRO4TSV0cPxNFrkiIsiu dvwBKW4B95pHXI0D5LVrWM8gV+ffxZa4ruVINykqFC2jssAfEYAQoALhvQZ6Qw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zaclys.net header.s=default header.b=Ax7Mhj7O; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -5.02 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zaclys.net header.s=default header.b=Ax7Mhj7O; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 844A92A2BE X-Spam-Score: -5.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: SnpZK/EEvSS7 --=-U4Kv2CkJkMbdTyQ8X4hf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2021-03-27 at 18:34 +0100, Rovanion Luckey wrote: > This is an attempt at getting the sendmail package working. Currently > installing the package does not make the `sendmail` executable appear > in `$PATH`: >=20 >=20 > > =E2=94=94$ guix environment --ad-hoc sendmail > > =E2=94=94$ sendmail > > bash: sendmail: command not found >=20 > This patch fixes that. >=20 Thanks a lot for working on this! It seems the commit message does not follow the ChangeLog guidelines as used by GNU Guix, I suggest using this: > gnu: sendmail: Fix output's directory structure. > =20 > * gnu/packages/mail.scm (sendmail)[arguments]<#:phases>: Properly > specify output directories in replacement 'configure and 'pre- > install. Look at the commit history of GNU Guix for more examples and inspiration. > Though there are questions that still need to be resolved. While this > patch does fix what it sets out to fix, the solutions aren't > neccicerily correct. It configures a "helpfile" to be put in > "$out/usr/share" and the same goes for its "statistics" file. I have > no idea what these does and where they should go in reality. If > someone happens to know, please do tell. If we look at the output of these commands: With your patch applied: $ tree $(./pre-inst-env guix build sendmail) /gnu/store/ygz55p6g8z4kjbp6418w385jzy53324h-sendmail-8.15.2 =E2=94=9C=E2=94=80=E2=94=80 bin =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 hoststat -> /gnu/store/ygz55p6g8z4k= jbp6418w385jzy53324h- sendmail-8.15.2/bin/sendmail =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 mailq -> /gnu/store/ygz55p6g8z4kjbp= 6418w385jzy53324h-sendmail- 8.15.2/bin/sendmail =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 newaliases -> /gnu/store/ygz55p6g8z= 4kjbp6418w385jzy53324h- sendmail-8.15.2/bin/sendmail =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 purgestat -> /gnu/store/ygz55p6g8z4= kjbp6418w385jzy53324h- sendmail-8.15.2/bin/sendmail =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 sendmail =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 vacation =E2=94=9C=E2=94=80=E2=94=80 etc =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 mail =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 sendmail.cf =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 submit.cf =E2=94=9C=E2=94=80=E2=94=80 libexec =E2=94=9C=E2=94=80=E2=94=80 sbin =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 editmap =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 mailstats =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 makemap =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 praliases =E2=94=94=E2=94=80=E2=94=80 share =E2=94=9C=E2=94=80=E2=94=80 doc =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 sendmail-8.15.2 =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 LICENSE =E2=94=9C=E2=94=80=E2=94=80 helpfile =E2=94=94=E2=94=80=E2=94=80 statistics 7 directories, 16 files Without your patch applied: $ tree $(./pre-inst-env guix build sendmail) /gnu/store/yn6dlixw6cnbmgjggk640vbv8hidfhi7-sendmail-8.15.2 =E2=94=9C=E2=94=80=E2=94=80 etc =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 mail =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 helpfile =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 sendmail.cf =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 statistics =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 submit.cf =E2=94=9C=E2=94=80=E2=94=80 share =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 doc =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 sendmail-8.15.2 =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 LICENSE =E2=94=94=E2=94=80=E2=94=80 usr =E2=94=9C=E2=94=80=E2=94=80 bin =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 hoststat -> /usr/sbin/sendmail =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 mailq -> /usr/sbin/sendmail =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 newaliases -> /usr/sbin/sendmai= l =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 purgestat -> /usr/sbin/sendmail =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 vacation =E2=94=94=E2=94=80=E2=94=80 sbin =E2=94=9C=E2=94=80=E2=94=80 editmap =E2=94=9C=E2=94=80=E2=94=80 mailstats =E2=94=9C=E2=94=80=E2=94=80 makemap =E2=94=9C=E2=94=80=E2=94=80 praliases =E2=94=9C=E2=94=80=E2=94=80 sendmail =E2=94=94=E2=94=80=E2=94=80 smrsh 8 directories, 16 files We can see helpfile and statistics file go into etc/mail, then sendmail goes into sbin, smrsh is missing in sbin. L=C3=A9o --=-U4Kv2CkJkMbdTyQ8X4hf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmBfdHgACgkQRaix6GvN EKbI4BAAmT46sz+ktFH5OkEI+0M5dqfAtYclqXSE27WfbqjJPedkR77IJu+bguyV UpxGawDJQ0K8HXthLU6Udl8OKhBaxVvKa6mDCbRP+9oLLa3qunL907HyNiNUCiFH 6wltqmrpEITZLeR5TGsLyHCeciEXmZjS7e5dXus1154sx0HsUTgQsF8KiQPuxGhQ 7zCFivpuhXMQtgnd1MqNg0Ev8/my6zNU1HTMhGD3upgkCGm+GeKzf4yFrp/RsZen K7KeFV4edhEPwj7lPYl1x9/h4XgSbdFMMwhJKGEYKu3epM8OHGiorLJqHGW7lVNR lJoQIZ/PO9Cx0r10LE7khmKshnDU74j1ie02V12zqDti+4RoXqRyS12BC2eUuIZ4 /xiIOiYp/kbbXXAxFW66YP2fPPUz/VTVQJnhkwB/dm120BB/AECog6jTHGlHxCDZ t5/Fd6kkBDR7h2weErMoQBqLaBqsuod9VEs64R5O3DPy7GkIatkRirLWd+YRT5Y3 qQrIzxiyiXrHid5/j3XYOiifGaGA35+SlxA342BNV5iKhHdsc/fpF/+znTrLLmJv JjTDsG2N8zzZGRhpzdtb9siY4uPezi9HbApjP+9bn9aojzoe9h4Z6XTCFuGwzDZG 3/iWQ1m3162WnAzOvLDk7gta9Mmph2ysMmVkj7KQ/CRI0e36gCo= =3sGz -----END PGP SIGNATURE----- --=-U4Kv2CkJkMbdTyQ8X4hf--