From: Maxime Devos <maximedevos@telenet.be>
To: Zhu Zihao <all_but_last@163.com>, Oleg Pykhalov <go.wigust@gmail.com>
Cc: 51747@debbugs.gnu.org
Subject: [bug#51747] [PATCH]: gnu: nix: Update to 2.4.
Date: Fri, 14 Jan 2022 13:56:25 +0100 [thread overview]
Message-ID: <c1c3fe3a451046a4bfc6206f5000182b1658a49b.camel@telenet.be> (raw)
In-Reply-To: <86h7a664rv.fsf@163.com>
[-- Attachment #1: Type: text/plain, Size: 2001 bytes --]
Zhu Zihao schreef op vr 14-01-2022 om 17:31 [+0800]:
> [...]
> +(define-public libcpuid
> + (let ((commit "2e61160983f32ba840b2246d3c3850c44626ab0d")
> + (revision "1"))
> + (package
> + (name "libcpuid")
> + (version (git-version "0.5.1" revision commit))
There's a good reason for using an unreleases version here,
but this should ideally be documented with a comment,
maybe
;; See <https://github.com/anrieff/libcpuid/pull/159>
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/anrieff/libcpuid")
> + (commit commit)))
> + (sha256
> + (base32
> "1mphvkiqq6z33sq6i490fq27sbyylacwrf8bg7ccvpcjms208sww"))
> + (modules '((guix build utils)))
> + (snippet
> + ;; Remove blobs
> + #~(begin
> + (delete-file "libcpuid/msrdriver.c")
> + (delete-file-recursively "contrib/MSR Driver")))
> + (file-name (git-file-name name version))))
> + (build-system cmake-build-system)
> + (arguments
> + (list #:tests? #f)) ;broken
In which manner are they broken? Maybe they can be fised.
> + (supported-systems '("x86_64-linux" "i686-linux"))
See my e-mail about target-x86-64? and the Hurd.
> + (home-page "https://libcpuid.sourceforge.net/")
> + (synopsis "Small library for x86 CPU detection and feature
> extraction")
> + (description "Libcpuid is a small C library to get vendor,
> model, branding
> +string, code name and other information from x86 CPU.")
It seems easy to confuse this with the package 'cpuid', maybe you
can mention 'cpuid' and 'libcpuid' are unrelated packages, albeit
for a similar purpose?
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
prev parent reply other threads:[~2022-01-14 13:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 12:35 [bug#51747] [PATCH]: gnu: nix: Update to 2.4 Zhu Zihao
[not found] ` <handler.51747.B.16365478179399.ack@debbugs.gnu.org>
2021-11-10 13:53 ` [bug#51747] Acknowledgement ([PATCH]: gnu: nix: Update to 2.4. ) Zhu Zihao
2021-11-10 15:47 ` Zhu Zihao
2021-11-17 11:21 ` Zhu Zihao
2021-12-04 15:28 ` Zhu Zihao
2022-01-11 8:23 ` [bug#51747] [PATCH]: gnu: nix: Update to 2.4 Oleg Pykhalov
2022-01-11 9:46 ` Zhu Zihao
2022-01-11 17:19 ` Zhu Zihao
2022-01-11 19:04 ` Maxime Devos
2022-01-12 4:21 ` Zhu Zihao
2022-01-12 5:19 ` Oleg Pykhalov
2022-01-12 7:08 ` Zhu Zihao
2022-01-12 8:26 ` Maxime Devos
2022-01-13 4:54 ` Zhu Zihao
2022-01-13 7:54 ` Zhu Zihao
2022-01-14 13:06 ` Maxime Devos
2022-01-14 16:51 ` Zhu Zihao
2022-01-14 18:39 ` Maxime Devos
2022-01-15 1:58 ` Zhu Zihao
2022-01-15 5:47 ` Zhu Zihao
2022-01-15 10:52 ` Maxime Devos
2022-01-15 16:06 ` Zhu Zihao
2022-01-21 14:29 ` bug#51747: " Oleg Pykhalov
2022-01-23 11:02 ` [bug#51747] " Maxime Devos
2022-01-11 19:05 ` Maxime Devos
2022-01-14 9:31 ` Zhu Zihao
2022-01-14 12:56 ` Maxime Devos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1c3fe3a451046a4bfc6206f5000182b1658a49b.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=51747@debbugs.gnu.org \
--cc=all_but_last@163.com \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).