From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fakkE-0000La-CW for guix-patches@gnu.org; Wed, 04 Jul 2018 12:35:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fakkB-00016C-2n for guix-patches@gnu.org; Wed, 04 Jul 2018 12:35:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38998) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fakkA-00015x-Te for guix-patches@gnu.org; Wed, 04 Jul 2018 12:35:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fakkA-0001pn-M6 for guix-patches@gnu.org; Wed, 04 Jul 2018 12:35:02 -0400 Subject: [bug#31954] [PATCH] gnu: Add emacs-org-brain. Resent-Message-ID: References: <20180624092937.19959-1-va511e@yahoo.com> <87a7riek00.fsf@fastmail.com> From: Vasile Dumitrascu Message-ID: Date: Wed, 04 Jul 2018 16:30:00 +0000 MIME-Version: 1.0 In-Reply-To: <87a7riek00.fsf@fastmail.com> Content-Type: multipart/mixed; boundary="------------3C2BE0D719E25A25C3F7C1E4" Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke , 31954@debbugs.gnu.org, chewzerita@posteo.net This is a multi-part message in MIME format. --------------3C2BE0D719E25A25C3F7C1E4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi @Marius: Please find attached an updated patch with the requested changes. Do let me know if anything else is to be adjusted. @Charlie: I am glad you find it useful. You are welcome! Thank you, Vasile Marius Bakke: > Vasile Dumitrascu writes: > >> * gnu/packages/emacs.scm (emacs-org-brain): New variable. > > Thanks for this patch! Overall it LGTM, but it does not apply to my git > checkout, so here are some nitpicks that I'd normally fix myself: > > [...] > >> +(define-public emacs-org-brain >> + (let ((version "20180522") ; no proper tag, use date of commit > > 'org-brain.el' has "Version: 0.5" in the source header. Perhaps we > should use that instead? > > [...] > >> + (description "@code{emacs-org-brain} implements a variant of concept >> +mapping in Emacs, using @code{org-mode}. It is heavily inspired by a piece of >> +software called The Brain.") > > Make sure to use double spaces in descriptions (guix lint should complain > about this). We also should not refer to nonfree software, can you try > to expand on this description without mentioning the inspiration? > > The commentary inside 'org-brain.el' contains a pretty good description. > > Can you send an updated patch please? Thanks in advance! > --------------3C2BE0D719E25A25C3F7C1E4 Content-Type: text/x-patch; name="0001-gnu-Add-emacs-org-brain.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-gnu-Add-emacs-org-brain.patch" >From 097ea36392360028cec20d2e8908755c926dcbcb Mon Sep 17 00:00:00 2001 From: Vasile Dumitrascu Date: Wed, 4 Jul 2018 18:24:50 +0200 Subject: [PATCH] gnu: Add emacs-org-brain. * gnu/packges/emacs.scm (emacs-org-brain): New variable. --- gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 467791e21..712dd1363 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -11290,3 +11290,29 @@ To use, add @code{allow-emacs-pinentry} to @code{~/.gnupg/gpg-agent.conf}, reload the configuration with @code{gpgconf --reload gpg-agent}, and start the server with @code{M-x pinentry-start}.") (license license:gpl3+)))) + +(define-public emacs-org-brain + (package + (name "emacs-org-brain") + (version "0.5") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/Kungsgeten/org-brain.git") + (commit "3faf9303af3f2356e3444e69c22dc6c5774047d1"))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1ad681zk6kckw2zbk0r4iaj4bw8cfqrbd1s3gdwgdjlzq81q9mmj")))) + (build-system emacs-build-system) + (home-page "https://github.com/Kungsgeten/org-brain") + (synopsis "Org-mode wiki and concept-mapping for Emacs") + (description "@code{emacs-org-brain} implements a variant of concept +mapping in Emacs, using @code{org-mode}. An org-brain is a network of +org-mode entries, where each entry is a file or a headline, and you can get a +visual overview of the relationships between the entries: parents, children, +siblings and friends. This visual overview can also be used to browse your +entries. You can think of entries as nodes in a mind map, or pages in a +wiki.") + (license license:expat))) -- 2.18.0 --------------3C2BE0D719E25A25C3F7C1E4--