From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gBASIY3zVGEVQAAAgWs5BA (envelope-from ) for ; Thu, 30 Sep 2021 01:15:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YOGSHI3zVGF6PAAAbx9fmQ (envelope-from ) for ; Wed, 29 Sep 2021 23:15:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E5B0E144BF for ; Thu, 30 Sep 2021 01:15:24 +0200 (CEST) Received: from localhost ([::1]:56162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVinM-0003x8-1R for larch@yhetil.org; Wed, 29 Sep 2021 19:15:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVin0-0003wx-PF for guix-patches@gnu.org; Wed, 29 Sep 2021 19:15:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39403) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVin0-0005jf-Hi for guix-patches@gnu.org; Wed, 29 Sep 2021 19:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVin0-0002Fg-5X; Wed, 29 Sep 2021 19:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50814] [PATCH 5/5] guix: git-authenticate: Fix authenticate-repository. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Sep 2021 23:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50814 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai , 50814@debbugs.gnu.org Received: via spool by 50814-submit@debbugs.gnu.org id=B50814.16329572948627 (code B ref 50814); Wed, 29 Sep 2021 23:15:02 +0000 Received: (at 50814) by debbugs.gnu.org; 29 Sep 2021 23:14:54 +0000 Received: from localhost ([127.0.0.1]:50949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVims-0002F5-EO for submit@debbugs.gnu.org; Wed, 29 Sep 2021 19:14:54 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:41180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVimq-0002Ew-K9 for 50814@debbugs.gnu.org; Wed, 29 Sep 2021 19:14:53 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id zzEq250080mfAB406zEqNf; Thu, 30 Sep 2021 01:14:50 +0200 Message-ID: From: Maxime Devos Date: Thu, 30 Sep 2021 01:14:44 +0200 In-Reply-To: <20210928162406.27205-5-attila@lendvai.name> References: <20210928162406.27205-1-attila@lendvai.name> <20210928162406.27205-5-attila@lendvai.name> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-bw1GYLABH7zY1e7MLO6/" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1632957291; bh=lZHk8pZgUEyrOGgC/rByi1ZlvHRjWfnUx6VspRoW6fE=; h=Subject:From:To:Date:In-Reply-To:References; b=K7QBne2ZJrCe1D2FArpaknC5GsrTtpyyOPiKF+87kQTf72gzg1SiFZL03c3LfwGPx gBOC9af3FqgnLJEYkWsJi/vt3T7kJhiy40987COYyZBa8W1hIqzFh5YBEAgsiK0ZD0 95mMsFh2qXgCXcQRYfPKqh6o1lR341TlWOa1+1CMlorGWCHUOglSnxTa0VcEYbmLO4 1FM29V4frNCccOu0ac9xR4iTavE1y2bbUGT5kBBP7KYsM5Fo4pLXOtQjx6NqZhxkFx v7lrYWg17oWppw4zd36x2nSv78JhMI5hHWQM0hNMRSmmAc/Pw/eWT9B+SvxCQvnwve xsYzYT1moxFaA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632957325; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=lZHk8pZgUEyrOGgC/rByi1ZlvHRjWfnUx6VspRoW6fE=; b=HMDwTDZsHSajnjnw3UHkuzES8bepsgphMm3PNmDkiGw67DU4jXQwCZPxhScLEGloIYD8AD wbPjdRHhb0T13reZG91M+AH+UhYDJ+bg0eA6uayWdIAwdfZCtbDM/6tFWcpLJCwNoFXhka Yx9jASnB5becJ/OpI8ROzf5aTaQjRhWu/HuG1I4Bz4vyM9U6HWjzswXLQ01P8go9LI4o+9 N9IH2y6ju+FcriltKPM5oJgmgCuDpRAPZtOMDRtY0WRpZjPs31kybTIqkHUvHXiBLrDTz8 c0yYM96Iwv7eG3eej3H2shUgp+jZQs4ZiTDfD7V8kkHhlzoejcYRaGEm668aLg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632957325; a=rsa-sha256; cv=none; b=ItZxRHAbV7SLMVCzjx+64L0h3VQE86X7K8HhFwInMhsY5c4H0I76xZaFO2/fjm3opoEvyp 2dGDN+9xEdqMtIwWFerWnVoIZ7aOTu2f/ASzRorfq8lToTUHBZA8oInhpbJf6z0dSq9ZoC G02mkO3rKbOlzIRZYujQLMqjOZatn4sER3PUYr6NDR6xRQeTTpqMJuLnwPIrns2XI6FAxn 7QXjVHNIoRdzFs02LKuhifLUeeu3I68suaZkAy/jdQvT4p0hOs5bjElbSKPMxUDqpjWVlc RSux7aqzHQzhCwK3K1X0bWPgoZVhWfUmzpbavxsY39nq2t0sAepBv7F8Ah0x7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=K7QBne2Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=K7QBne2Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E5B0E144BF X-Spam-Score: -3.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: rSOReU/+NjJp --=-bw1GYLABH7zY1e7MLO6/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attila Lendvai schreef op di 28-09-2021 om 18:24 [+0200]: > [...] > -(define* (commit-authorized-keys repository commit > - #:optional (default-authorizations '())= ) > - "Return the list of OpenPGP fingerprints authorized to sign COMMIT, ba= sed on > -authorizations listed in its parent commits. If one of the parent commi= ts > -does not specify anything, fall back to DEFAULT-AUTHORIZATIONS." > +(define (authorized-keys-at-commit repository commit default-authorizati= ons) > + "Return the list of authorized key fingerprints from the '.guix-author= izations' > +file at the given commit." Could 'default-authorizations' still be documented? Anyway, I don't see any problems with this patch (ignoring the warning and = the docstrings), but I'm completely unfamiliar with the internals of channel authentication, so I don't know what to look for. You'll need to find some= one else to review this. Greetings, Maxime --=-bw1GYLABH7zY1e7MLO6/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYVTzZBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7r1sAPwPBMrVj2xf2/3+qRc2vCdJ99mL KGQv4vjiAmGOHRA6zAD9FPycoQ3VFncbi4+HCqt6WplEYsgLkw5Nneps9E4mYgU= =LpmA -----END PGP SIGNATURE----- --=-bw1GYLABH7zY1e7MLO6/--