From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: soeren@soeren-tempel.net, 71925@debbugs.gnu.org
Cc: julien@lepiller.eu
Subject: [bug#71925] [PATCH 2/2] gnu: klee: Build with klee-uclibc support.
Date: Sat, 06 Jul 2024 20:49:37 +0200 [thread overview]
Message-ID: <beaba06e67a41d85922028cb56dbffb85f4e87e1.camel@gmail.com> (raw)
In-Reply-To: <50e13182dab9f13a90c63a670a286eb447133e44.1720033365.git.soeren@soeren-tempel.net>
Am Mittwoch, dem 03.07.2024 um 21:09 +0200 schrieb
soeren@soeren-tempel.net:
> From: Sören Tempel <soeren@soeren-tempel.net>
>
> * gnu/packages/check.scm (klee): Use klee-uclibc.
> ---
> gnu/packages/check.scm | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
> index 35e26ba6da..ad589f6e15 100644
> --- a/gnu/packages/check.scm
> +++ b/gnu/packages/check.scm
> @@ -1062,13 +1062,26 @@ (define-public klee
> (base32
> "1nma6dqi8chjb97llsa8mzyskgsg4dx56lm8j514j5wmr8vkafz6"))))
> (arguments
> (list
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'install 'wrap-hooks
> + (lambda* (#:key inputs outputs #:allow-
> other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin"))
> + (lib (string-append out "/lib")))
> + ;; Ensure that KLEE finds runtime
> libraries (e.g. uclibc).
> + (wrap-program (string-append bin
> "/klee")
> + `("KLEE_RUNTIME_LIBRARY_PATH" ":" =
> + (,(string-append lib
> "/klee/runtime/"))))))))
The leading colon is pointless here, since you're doing an "=" assign.
More importantly, can we make this a search path?
> #:configure-flags
> #~(list (string-append "-DLLVMCC="
> (search-input-file %build-inputs
> "/bin/clang"))
> (string-append "-DLLVMCXX="
> - (search-input-file %build-inputs
> "/bin/clang++")))))
> + (search-input-file %build-inputs
> "/bin/clang++"))
> + "-DENABLE_POSIX_RUNTIME=ON"
> + (string-append "-DKLEE_UCLIBC_PATH=" #$klee-uclibc))))
Can we use search-input-file for this and dirname our way up?
> (native-inputs (list clang-13 llvm-13 python-lit))
> - (inputs (list gperftools sqlite z3))
> + (inputs (list bash-minimal gperftools sqlite z3))
> (build-system cmake-build-system)
> (home-page "https://klee-se.org/")
> (synopsis "Symbolic execution engine")
Cheers
next prev parent reply other threads:[~2024-07-06 18:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 19:03 [bug#71925] [PATCH 0/2] Add klee-uclibc soeren
2024-07-03 19:09 ` [bug#71925] [PATCH 1/2] gnu: " soeren
2024-07-06 18:50 ` Liliana Marie Prikler
2024-07-03 19:09 ` [bug#71925] [PATCH 2/2] gnu: klee: Build with klee-uclibc support soeren
2024-07-06 18:49 ` Liliana Marie Prikler [this message]
2024-07-07 11:24 ` Sören Tempel
2024-07-07 12:51 ` Liliana Marie Prikler
2024-07-07 16:50 ` Sören Tempel
2024-07-07 16:53 ` Liliana Marie Prikler
2024-07-07 17:28 ` Sören Tempel
2024-07-07 18:27 ` Liliana Marie Prikler
2024-07-07 19:18 ` Sören Tempel
2024-07-07 17:26 ` [bug#71925] [PATCH v2 1/2] gnu: Add klee-uclibc soeren
2024-07-07 17:26 ` [bug#71925] [PATCH v2 2/2] gnu: klee: Build with klee-uclibc support soeren
2024-07-07 19:19 ` [bug#71925] [PATCH v3 1/2] gnu: Add klee-uclibc soeren
2024-07-07 19:19 ` [bug#71925] [PATCH v3 2/2] gnu: klee: Build with klee-uclibc support soeren
2024-07-08 7:44 ` [bug#71925] [PATCH v4 1/2] gnu: Add klee-uclibc soeren
2024-07-08 7:44 ` [bug#71925] [PATCH v4 2/2] gnu: klee: Build with klee-uclibc support soeren
2024-07-08 8:47 ` [bug#71925] [PATCH 0/2] Add klee-uclibc Sören Tempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beaba06e67a41d85922028cb56dbffb85f4e87e1.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=71925@debbugs.gnu.org \
--cc=julien@lepiller.eu \
--cc=soeren@soeren-tempel.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).