From: Maxime Devos <maximedevos@telenet.be>
To: John Kehayias <john.kehayias@protonmail.com>
Cc: control@debbugs.gnu.org, "52806@debbugs.gnu.org" <52806@debbugs.gnu.org>
Subject: [bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.
Date: Thu, 27 Jan 2022 16:56:02 +0100 [thread overview]
Message-ID: <be7bd63268336dee56286669ce6330e5b3405149.camel@telenet.be> (raw)
In-Reply-To: <xpvAbzMFF_MnhvXw-U3K3gI7z-Q-mDmrMOQ17BoXF40nu0W02OSEelEwwYpXRoRe_lUfZCtTlcgFFk_6GHE2SU8fZZsP5euBGhCLoj6S9ls=@protonmail.com>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
user guix
usertag 52806 + reviewed-looks-good
thanks
John Kehayias schreef op do 27-01-2022 om 03:33 [+0000]:
> Hi Maxime,
>
> Just wanted to see if you got a chance to see the updated patch I sent previously, where I made the change you suggested:
>
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >
> > On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:
> >
> > > 'outputs' is unused here, so you can simplify the lambda from
> > > (lambda * (#:key outputs #:allow-other-keys) ...)
> > > to
> > > (lambda _ ...).
> >
>
> Was there anything else I should take care of?
IIRC, no, the v5 patch appears to be fine, though IIRC I didn't look at
the source code of xinitrc-xsession.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-01-27 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 16:46 [bug#52806] [PATCH] gnu: Add xinitrc-xsession John Kehayias via Guix-patches via
2021-12-27 5:13 ` [bug#52806] [PATCH v2] " John Kehayias via Guix-patches via
2021-12-27 15:19 ` [bug#52806] [PATCH v3] " John Kehayias via Guix-patches via
2022-01-11 21:29 ` [bug#52806] [PATCH v4] " John Kehayias via Guix-patches via
2022-01-11 22:24 ` Maxime Devos
2022-01-11 22:34 ` [bug#52806] [PATCH v5] " John Kehayias via Guix-patches via
2022-01-27 3:33 ` John Kehayias via Guix-patches via
2022-01-27 15:56 ` Maxime Devos [this message]
2022-01-28 20:47 ` John Kehayias via Guix-patches via
2022-01-28 21:34 ` Maxime Devos
2022-02-04 19:52 ` bug#52806: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be7bd63268336dee56286669ce6330e5b3405149.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=52806@debbugs.gnu.org \
--cc=control@debbugs.gnu.org \
--cc=john.kehayias@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).