From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wBXzGJ3CSGBOZwAA0tVLHw (envelope-from ) for ; Wed, 10 Mar 2021 12:59:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id +OC3FJ3CSGDMQgAAB5/wlQ (envelope-from ) for ; Wed, 10 Mar 2021 12:59:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2DDD41C79A for ; Wed, 10 Mar 2021 13:59:09 +0100 (CET) Received: from localhost ([::1]:40820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJyQe-0002AS-Aq for larch@yhetil.org; Wed, 10 Mar 2021 07:59:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJyQY-0002AF-1w for guix-patches@gnu.org; Wed, 10 Mar 2021 07:59:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37547) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJyQX-0006oI-Qh for guix-patches@gnu.org; Wed, 10 Mar 2021 07:59:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJyQX-000426-PP for guix-patches@gnu.org; Wed, 10 Mar 2021 07:59:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#47042] gnu: qtsolutions: Enable examples. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Mar 2021 12:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47042 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , 47042@debbugs.gnu.org Received: via spool by 47042-submit@debbugs.gnu.org id=B47042.161538112215476 (code B ref 47042); Wed, 10 Mar 2021 12:59:01 +0000 Received: (at 47042) by debbugs.gnu.org; 10 Mar 2021 12:58:42 +0000 Received: from localhost ([127.0.0.1]:49093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJyQE-00041Y-B4 for submit@debbugs.gnu.org; Wed, 10 Mar 2021 07:58:42 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:50668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJyQC-00041P-7o for 47042@debbugs.gnu.org; Wed, 10 Mar 2021 07:58:41 -0500 Received: from nijino.local (217-149-164-20.nat.highway.telekom.at [217.149.164.20]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DwXFS4C2rz1LBCm; Wed, 10 Mar 2021 13:58:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4DwXFS4C2rz1LBCm DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1615381116; bh=5mec8Y0JPUst/5mi6mdhJ3TIN0fWWIAEDz0f78E0lmA=; h=Subject:From:To:Date:In-Reply-To:References:From; b=sJJVSRp9Oh8QOiFaGi/nGEltBEET5E/qv33q7fn3+SIhMzjGXXxHZJL+dhvwAfxAu OHHLLJ7WmcHsklhkg+qSb8ePMJRDDjP2H+fX4yn+4KsBBKzuwv5hAMZ/2D6Wzz9Ach 6kXCzag2vh6gF2edNYt+V2hrCFdxVfWZIYbMFZJc= Message-ID: From: Leo Prikler Date: Wed, 10 Mar 2021 13:58:35 +0100 In-Reply-To: <84ac6377-e05b-9bac-39b0-24c35fae89cf@raghavgururajan.name> References: <84ac6377-e05b-9bac-39b0-24c35fae89cf@raghavgururajan.name> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 2DDD41C79A X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: 75TB7UNLonw3 Am Mittwoch, den 10.03.2021, 06:09 -0500 schrieb Raghav Gururajan: > Hi Leo! > > Currently with this patch, we have following issues: > > [1] When examples are enabled for QtSingleApplication, it doesn't > get > linked to QtLockFile. (Try building without `;; Disable building of > examples for QtSingleApplication.` block) Then I guess we have to rewrite that Makefile (or pseudo-Makefile) in the snippet as well? > [2] For installation of examples, the binaries get installed in sub- > dirs > as `/bin/foo` instead of `/bin`. I don't think the compiled examples need to be installed at all – rather their source code etc. should be installed to share/doc (in a qtsolutions subfolder of course). The act of compiling them is merely a check, that they (plus the code they are an example of) "work as intended" or at least compile as intended. If I read your patch correctly, I made an indentation mistake during the review process, is that correct? Regards, Leo