unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
@ 2022-06-22  8:40 muradm
  2022-06-22 10:02 ` Maxime Devos
  2022-06-22 11:54 ` [bug#56136] [PATCH] " Maxime Devos
  0 siblings, 2 replies; 11+ messages in thread
From: muradm @ 2022-06-22  8:40 UTC (permalink / raw)
  To: 56136; +Cc: Liliana Marie Prikler

* gnu/packages/freedesktop.scm (basu): New variable.
---
 gnu/packages/freedesktop.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 29bb7c1664..7269520a21 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
 ;;; Copyright © 2021, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
+;;; Copyright © 2022 muradm <mail@muradm.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -702,6 +703,30 @@ (define-public elogind
 of a the system to know what users are logged in, and where.")
     (license license:lgpl2.1+)))
 
+(define-public basu
+  (package
+    (name "basu")
+    (version "0.2.0")
+    (home-page "https://git.sr.ht/~emersion/basu")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url home-page)
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0h23n7wg18xc7xwldca18wi00iajyliixwicqyvv38qx831d8q18"))))
+    (build-system meson-build-system)
+    (inputs
+     (list pkg-config python gperf libcap))
+    (synopsis "The sd-bus library, extracted from systemd.")
+    (description "Some projects rely on the sd-bus library for DBus support.
+However not all systems have systemd or elogind installed.
+This library provides just sd-bus (and the busctl utility).")
+    (license license:gpl2)))
+
 (define-public localed
   ;; XXX: This package is extracted from systemd but we retain so little of it
   ;; that it would make more sense to maintain a fork of the bits we need.
-- 
2.36.1





^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
  2022-06-22  8:40 [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0 muradm
@ 2022-06-22 10:02 ` Maxime Devos
  2022-06-22 10:32   ` [bug#56136] [PATCH v2] " muradm
  2022-06-22 11:54 ` [bug#56136] [PATCH] " Maxime Devos
  1 sibling, 1 reply; 11+ messages in thread
From: Maxime Devos @ 2022-06-22 10:02 UTC (permalink / raw)
  To: muradm, 56136; +Cc: Liliana Marie Prikler

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

muradm schreef op wo 22-06-2022 om 11:40 [+0300]:
> +    (license license:gpl2)))

Looking at
<https://git.sr.ht/~emersion/basu/tree/master/item/meson.build#L5>, it
seems to be LGPL2.1+, not GPL-2-only?

Greetings,
Maxime.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#56136] [PATCH v2] gnu: freedesktop: Add basu 0.2.0.
  2022-06-22 10:02 ` Maxime Devos
@ 2022-06-22 10:32   ` muradm
  0 siblings, 0 replies; 11+ messages in thread
From: muradm @ 2022-06-22 10:32 UTC (permalink / raw)
  To: 56136, Maxime Devos; +Cc: Liliana Marie Prikler

* gnu/packages/freedesktop.scm (basu): New variable.
---
 gnu/packages/freedesktop.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 29bb7c1664..bcd083a316 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
 ;;; Copyright © 2021, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
+;;; Copyright © 2022 muradm <mail@muradm.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -702,6 +703,30 @@ (define-public elogind
 of a the system to know what users are logged in, and where.")
     (license license:lgpl2.1+)))
 
+(define-public basu
+  (package
+    (name "basu")
+    (version "0.2.0")
+    (home-page "https://git.sr.ht/~emersion/basu")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url home-page)
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0h23n7wg18xc7xwldca18wi00iajyliixwicqyvv38qx831d8q18"))))
+    (build-system meson-build-system)
+    (inputs
+     (list pkg-config python gperf libcap))
+    (synopsis "The sd-bus library, extracted from systemd.")
+    (description "Some projects rely on the sd-bus library for DBus support.
+However not all systems have systemd or elogind installed.
+This library provides just sd-bus (and the busctl utility).")
+    (license license:lgpl2.1+)))
+
 (define-public localed
   ;; XXX: This package is extracted from systemd but we retain so little of it
   ;; that it would make more sense to maintain a fork of the bits we need.
-- 
2.36.1





^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
  2022-06-22  8:40 [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0 muradm
  2022-06-22 10:02 ` Maxime Devos
@ 2022-06-22 11:54 ` Maxime Devos
  2022-06-22 12:00   ` [bug#56136] [PATCH v3] " muradm
  2022-06-22 12:07   ` [bug#56136] [PATCH] " muradm
  1 sibling, 2 replies; 11+ messages in thread
From: Maxime Devos @ 2022-06-22 11:54 UTC (permalink / raw)
  To: muradm, 56136; +Cc: Liliana Marie Prikler

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

muradm schreef op wo 22-06-2022 om 11:40 [+0300]:
> +    (inputs
> +     (list pkg-config python gperf libcap))

(Didn't notice this previously):

  * gperf is a binary (usually) run during the build to generate stuff,
    so it needs to be in native-inputs for cross-compilation to work.

  * pkg-config is almost surely needs to be native-inputs (it's like a
    (cross-) compiler).  "./pre-inst-env guix lint basu" probably would
    report this.

    As a test, you can try
    "./pre-inst-env guix build basu --target=aarch64-linux-gnu" or
    such.

  * whether python is native- or non-native depends on how it is used.

  * libcap looks fine from here.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#56136] [PATCH v3] gnu: freedesktop: Add basu 0.2.0.
  2022-06-22 11:54 ` [bug#56136] [PATCH] " Maxime Devos
@ 2022-06-22 12:00   ` muradm
  2022-06-22 12:07   ` [bug#56136] [PATCH] " muradm
  1 sibling, 0 replies; 11+ messages in thread
From: muradm @ 2022-06-22 12:00 UTC (permalink / raw)
  To: 56136, Maxime Devos; +Cc: Liliana Marie Prikler

* gnu/packages/freedesktop.scm (basu): New variable.
---
 gnu/packages/freedesktop.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 29bb7c1664..1b0f21c0e4 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
 ;;; Copyright © 2021, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
+;;; Copyright © 2022 muradm <mail@muradm.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -702,6 +703,32 @@ (define-public elogind
 of a the system to know what users are logged in, and where.")
     (license license:lgpl2.1+)))
 
+(define-public basu
+  (package
+    (name "basu")
+    (version "0.2.0")
+    (home-page "https://git.sr.ht/~emersion/basu")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url home-page)
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0h23n7wg18xc7xwldca18wi00iajyliixwicqyvv38qx831d8q18"))))
+    (build-system meson-build-system)
+    (native-inputs
+     (list pkg-config python gperf))
+    (inputs
+     (list libcap))
+    (synopsis "The sd-bus library, extracted from systemd.")
+    (description "Some projects rely on the sd-bus library for DBus support.
+However not all systems have systemd or elogind installed.
+This library provides just sd-bus (and the busctl utility).")
+    (license license:lgpl2.1+)))
+
 (define-public localed
   ;; XXX: This package is extracted from systemd but we retain so little of it
   ;; that it would make more sense to maintain a fork of the bits we need.
-- 
2.36.1





^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
  2022-06-22 11:54 ` [bug#56136] [PATCH] " Maxime Devos
  2022-06-22 12:00   ` [bug#56136] [PATCH v3] " muradm
@ 2022-06-22 12:07   ` muradm
  2022-06-22 13:08     ` Maxime Devos
  1 sibling, 1 reply; 11+ messages in thread
From: muradm @ 2022-06-22 12:07 UTC (permalink / raw)
  To: Maxime Devos; +Cc: Liliana Marie Prikler, 56136

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]


Fixed in v3

Maxime Devos <maximedevos@telenet.be> writes:

> [[PGP Signed Part:Undecided]]
> muradm schreef op wo 22-06-2022 om 11:40 [+0300]:
>> +    (inputs
>> +     (list pkg-config python gperf libcap))
>
> (Didn't notice this previously):
>
>   * gperf is a binary (usually) run during the build to generate 
>   stuff,
>     so it needs to be in native-inputs for cross-compilation to 
>     work.
>
>   * pkg-config is almost surely needs to be native-inputs (it's 
>   like a
>     (cross-) compiler).  "./pre-inst-env guix lint basu" 
>     probably would
>     report this.
Didn't see any warning or else.

>
>     As a test, you can try
>     "./pre-inst-env guix build basu --target=aarch64-linux-gnu" 
>     or
>     such.
>
>   * whether python is native- or non-native depends on how it is 
>   used.
Python nedeed by gperf scripts, so native- also.

>
>   * libcap looks fine from here.
>
> Greetings,
> Maxime.
>
> [[End of PGP Signed Part]]


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
  2022-06-22 12:07   ` [bug#56136] [PATCH] " muradm
@ 2022-06-22 13:08     ` Maxime Devos
  2022-06-22 13:14       ` muradm
  0 siblings, 1 reply; 11+ messages in thread
From: Maxime Devos @ 2022-06-22 13:08 UTC (permalink / raw)
  To: muradm; +Cc: Liliana Marie Prikler, 56136

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

muradm schreef op wo 22-06-2022 om 15:07 [+0300]:
> >    * pkg-config is almost surely needs to be native-inputs (it's 
> >    like a
> >      (cross-) compiler).  "./pre-inst-env guix lint basu" 
> >      probably would
> >      report this.
> Didn't see any warning or else.

Can't reproduce:

$ guix lint -L . basu  # (*)
./a.scm:24:5: basu@0.2.0: ‘pkg-config’ zou waarschijnlijk inheemse voer moeten zijn
./a.scm:25:14: basu@0.2.0: geen punt toegestaan aan het einde van de synopsis
fetching CVE database for 2022...
fetching CVE database for 2021...
fetching CVE database for 2020...
[...]

(i.e.: the translation for 'native' is in retrospect confusing, pkg-config should
probably be a native-input instead and a synopsis may not end with a period)

(*): I put the package definition into a separate file, hence the -L ..  In your case,
that would be  './pre-inst-env guix lint basu' instead

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
  2022-06-22 13:08     ` Maxime Devos
@ 2022-06-22 13:14       ` muradm
  2022-06-22 13:21         ` [bug#56136] [PATCH v4] " muradm
  2022-06-22 16:32         ` [bug#56136] [PATCH] " Maxime Devos
  0 siblings, 2 replies; 11+ messages in thread
From: muradm @ 2022-06-22 13:14 UTC (permalink / raw)
  To: Maxime Devos; +Cc: Liliana Marie Prikler, 56136

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]


For v3 with lint I got only this:

gnu/packages/freedesktop.scm:726:14: basu@0.2.0: no period allowed 
at the end of the synopsis

v4 has no lint warnings.

--
muradm

Maxime Devos <maximedevos@telenet.be> writes:

> [[PGP Signed Part:Undecided]]
> muradm schreef op wo 22-06-2022 om 15:07 [+0300]:
>> >    * pkg-config is almost surely needs to be native-inputs 
>> > (it's
>> >    like a
>> >      (cross-) compiler).  "./pre-inst-env guix lint basu"
>> >      probably would
>> >      report this.
>> Didn't see any warning or else.
>
> Can't reproduce:
>
> $ guix lint -L . basu  # (*)
> ./a.scm:24:5: basu@0.2.0: ‘pkg-config’ zou waarschijnlijk 
> inheemse voer moeten zijn
> ./a.scm:25:14: basu@0.2.0: geen punt toegestaan aan het einde 
> van de synopsis
> fetching CVE database for 2022...
> fetching CVE database for 2021...
> fetching CVE database for 2020...
> [...]
>
> (i.e.: the translation for 'native' is in retrospect confusing, 
> pkg-config should
> probably be a native-input instead and a synopsis may not end 
> with a period)
>
> (*): I put the package definition into a separate file, hence 
> the -L ..  In your case,
> that would be  './pre-inst-env guix lint basu' instead
>
> Greetings,
> Maxime.
>
> [[End of PGP Signed Part]]


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#56136] [PATCH v4] gnu: freedesktop: Add basu 0.2.0.
  2022-06-22 13:14       ` muradm
@ 2022-06-22 13:21         ` muradm
  2022-06-22 19:36           ` bug#56136: " Liliana Marie Prikler
  2022-06-22 16:32         ` [bug#56136] [PATCH] " Maxime Devos
  1 sibling, 1 reply; 11+ messages in thread
From: muradm @ 2022-06-22 13:21 UTC (permalink / raw)
  To: 56136, Maxime Devos; +Cc: Liliana Marie Prikler

* gnu/packages/freedesktop.scm (basu): New variable.
---
 gnu/packages/freedesktop.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 29bb7c1664..4d06235771 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
 ;;; Copyright © 2021, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
+;;; Copyright © 2022 muradm <mail@muradm.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -702,6 +703,32 @@ (define-public elogind
 of a the system to know what users are logged in, and where.")
     (license license:lgpl2.1+)))
 
+(define-public basu
+  (package
+    (name "basu")
+    (version "0.2.0")
+    (home-page "https://git.sr.ht/~emersion/basu")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url home-page)
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0h23n7wg18xc7xwldca18wi00iajyliixwicqyvv38qx831d8q18"))))
+    (build-system meson-build-system)
+    (native-inputs
+     (list pkg-config python gperf))
+    (inputs
+     (list libcap))
+    (synopsis "The sd-bus library, extracted from systemd")
+    (description "Some projects rely on the sd-bus library for DBus support.
+However not all systems have systemd or elogind installed.
+This library provides just sd-bus (and the busctl utility).")
+    (license license:lgpl2.1+)))
+
 (define-public localed
   ;; XXX: This package is extracted from systemd but we retain so little of it
   ;; that it would make more sense to maintain a fork of the bits we need.
-- 
2.36.1





^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0.
  2022-06-22 13:14       ` muradm
  2022-06-22 13:21         ` [bug#56136] [PATCH v4] " muradm
@ 2022-06-22 16:32         ` Maxime Devos
  1 sibling, 0 replies; 11+ messages in thread
From: Maxime Devos @ 2022-06-22 16:32 UTC (permalink / raw)
  To: muradm; +Cc: Liliana Marie Prikler, 56136

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

muradm schreef op wo 22-06-2022 om 16:14 [+0300]:
> For v3 with lint I got only this:
> 
> gnu/packages/freedesktop.scm:726:14: basu@0.2.0: no period allowed 
> at the end of the synopsis

My comment was on the v2, not the v3.  You wrote that:

> >   * pkg-config is almost surely needs to be native-inputs (it's 
> >   like a
> >     (cross-) compiler).  "./pre-inst-env guix lint basu" 
> >     probably would
> >     report this.
> Didn't see any warning or else.

... which would seem to be somehow a bug in "guix lint" or an incorrect
use of "guix lint".  Basically, I don't understand how you didn't get
any warnings.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#56136: [PATCH v4] gnu: freedesktop: Add basu 0.2.0.
  2022-06-22 13:21         ` [bug#56136] [PATCH v4] " muradm
@ 2022-06-22 19:36           ` Liliana Marie Prikler
  0 siblings, 0 replies; 11+ messages in thread
From: Liliana Marie Prikler @ 2022-06-22 19:36 UTC (permalink / raw)
  To: muradm, 56136-done, Maxime Devos, 56094-done

Am Mittwoch, dem 22.06.2022 um 16:21 +0300 schrieb muradm:
> * gnu/packages/freedesktop.scm (basu): New variable.
Pushed along with the original issue.  Reworded both slightly.

Cheers




^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-06-22 19:38 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-22  8:40 [bug#56136] [PATCH] gnu: freedesktop: Add basu 0.2.0 muradm
2022-06-22 10:02 ` Maxime Devos
2022-06-22 10:32   ` [bug#56136] [PATCH v2] " muradm
2022-06-22 11:54 ` [bug#56136] [PATCH] " Maxime Devos
2022-06-22 12:00   ` [bug#56136] [PATCH v3] " muradm
2022-06-22 12:07   ` [bug#56136] [PATCH] " muradm
2022-06-22 13:08     ` Maxime Devos
2022-06-22 13:14       ` muradm
2022-06-22 13:21         ` [bug#56136] [PATCH v4] " muradm
2022-06-22 19:36           ` bug#56136: " Liliana Marie Prikler
2022-06-22 16:32         ` [bug#56136] [PATCH] " Maxime Devos

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).