unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Troy Figiel <troy@troyfigiel.com>
To: Sharlatan Hellseher <sharlatanus@gmail.com>
Cc: 68789@debbugs.gnu.org
Subject: [bug#68789] [PATCH 0/2] gnu: Add python-pyjanitor.
Date: Mon, 29 Jan 2024 18:18:57 +0100	[thread overview]
Message-ID: <bce44714-c405-4dbc-a06d-998ad6345bda@troyfigiel.com> (raw)
In-Reply-To: <87bk94tdvi.fsf@gmail.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 685 bytes --]

Hi Oleg,

Thanks for the check!

On 2024-01-29 15:26, Sharlatan Hellseher wrote:
> One note - you introduced a module cycle which was not before
> astronomy->python-science->astronomy. If the requirement of
> python-astropy is soft let's silent it for now.

Removing the python-astropy dependency should be fine for python-unyt. I
agree that avoiding module cycles would be better. If I recall
correctly, Astropy was only used in tests, because it has a similar
submodule dealing with physical units.

The build was successful and the cycle did not show up in the linter.
How did you find it? Did you happen to notice it when you saw the imports?

Best wishes,

Troy

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6367 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-01-29 17:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-28 22:49 [bug#68789] [PATCH 0/2] gnu: Add python-pyjanitor Troy Figiel
2024-01-28 21:47 ` [bug#68789] [PATCH 1/2] gnu: Add python-unyt Troy Figiel
2024-01-28 22:13 ` [bug#68789] [PATCH 2/2] gnu: Add python-pyjanitor Troy Figiel
2024-01-29 14:26 ` [bug#68789] [PATCH 0/2] " Sharlatan Hellseher
2024-01-29 17:18   ` Troy Figiel [this message]
2024-01-29 17:31     ` Sharlatan Hellseher
2024-01-29 18:13       ` Troy Figiel
2024-01-29 18:16 ` [bug#68789] [PATCH 1/2] gnu: Add python-unyt Troy Figiel
2024-01-29 18:17 ` [bug#68789] [PATCH 2/2] gnu: Add python-pyjanitor Troy Figiel
2024-01-29 18:18 ` [bug#68789] [PATCH v2 0/2] " Troy Figiel
2024-01-29 23:01 ` bug#68789: [PATCH " Sharlatan Hellseher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bce44714-c405-4dbc-a06d-998ad6345bda@troyfigiel.com \
    --to=troy@troyfigiel.com \
    --cc=68789@debbugs.gnu.org \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).