unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: jlicht@fsfe.org
To: 74187@debbugs.gnu.org
Cc: Jelle Licht <jlicht@fsfe.org>
Subject: [bug#74187] [PATCH 19/20] gnu: esbuild-node: Use node-lts instead of node.
Date: Sun,  3 Nov 2024 13:04:06 +0100	[thread overview]
Message-ID: <bcb5780bc95bc224ef8e425a93cce0177c1b66dd.1730634823.git.jlicht@fsfe.org> (raw)
In-Reply-To: <cover.1730634823.git.jlicht@fsfe.org>

From: Jelle Licht <jlicht@fsfe.org>

* gnu/packages/web.scm (esbuild-node)[#:phases]<build-platform>: Remove
workaround needed for building with older versions of Node.
[native-inputs]: Replace node by node-lts.

Change-Id: Iedf30dc1a395e674007c08ce6c0881dbb0f94f0e
---
 gnu/packages/web.scm | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 842c25b509..954da312bd 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -2126,12 +2126,6 @@ (define-public esbuild-node
           (add-after 'build 'build-platform
             (lambda* (#:key unpack-path #:allow-other-keys)
               (with-directory-excursion (string-append "src/" unpack-path)
-                ;; We're using Node 10, which doesn't have this method.
-                (substitute* "scripts/esbuild.js"
-                  (("exports.buildNativeLib" m)
-                   (string-append
-                    "Object.fromEntries = entries => entries.reduce((result, entry) => (result[entry[0]] = entry[1], result), {});\n"
-                    m)))
                 ;; Must be writable.
                 (for-each make-file-writable (find-files "." "."))
                 (invoke "node" "scripts/esbuild.js"
@@ -2154,7 +2148,7 @@ (define-public esbuild-node
                   (invoke "make" "test-go"))))))))
     (native-inputs
      (modify-inputs (package-native-inputs esbuild)
-       (append node)))))
+       (append node-lts)))))
 
 (define-public wwwoffle
   (package
@@ -9517,7 +9511,7 @@ (define-public archivebox
     (build-system python-build-system)
     (propagated-inputs
      (list curl
-           node))
+           node-lts))
     (inputs
      (list python
            youtube-dl
-- 
2.46.0





  parent reply	other threads:[~2024-11-03 12:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-03 12:01 [bug#74187] [PATCH 00/20] Bumping node to 20.18.0 and beyond jlicht
2024-11-03 12:03 ` [bug#74187] [PATCH 01/20] gnu: node: Replace customized nghttp2-for-node by nghttp2 jlicht
2024-11-03 12:03 ` [bug#74187] [PATCH 02/20] gnu: Remove nghttp2-for-node jlicht
2024-11-03 12:03 ` [bug#74187] [PATCH 03/20] gnu: node-lts: Replace customized c-ares-for-node by c-ares jlicht
2024-11-03 12:03 ` [bug#74187] [PATCH 04/20] gnu: Remove c-ares-for-node jlicht
2024-11-03 12:03 ` [bug#74187] [PATCH 05/20] gnu: Add libuv-for-node-lts jlicht
2024-11-03 12:03 ` [bug#74187] [PATCH 06/20] gnu: llhttp-bootstrap: Update to 8.1.2 jlicht
2024-11-03 12:03 ` [bug#74187] [PATCH 07/20] gnu: node-lts: Update to 20.18.0 [security fixes] jlicht
2024-11-03 12:03 ` [bug#74187] [PATCH 08/20] gnu: r-v8: Fix build with node-lts@20 jlicht
2024-11-03 18:29   ` Ricardo Wurmus
2024-11-03 12:03 ` [bug#74187] [PATCH 09/20] gnu: cwltool: Use node-lts instead of node jlicht
2024-11-03 12:03 ` [bug#74187] [PATCH 10/20] gnu: python-cwl-utils: " jlicht
2024-11-03 12:03 ` [bug#74187] [PATCH 11/20] gnu: ocaml-ezjsonm: " jlicht
2024-11-03 12:03 ` [bug#74187] [PATCH 12/20] gnu: js-of-ocaml: " jlicht
2024-11-03 12:04 ` [bug#74187] [PATCH 13/20] gnu: fmp: " jlicht
2024-11-03 12:04 ` [bug#74187] [PATCH 14/20] gnu: python-cloudscraper: " jlicht
2024-11-03 12:04 ` [bug#74187] [PATCH 15/20] gnu: qtwebengine-5: " jlicht
2024-11-03 12:04 ` [bug#74187] [PATCH 16/20] gnu: ruby-autoprefixer-rails: " jlicht
2024-11-03 12:04 ` [bug#74187] [PATCH 17/20] gnu: ruby-execjs: " jlicht
2024-11-03 12:04 ` [bug#74187] [PATCH 18/20] gnu: vlang: " jlicht
2024-11-03 12:04 ` jlicht [this message]
2024-11-03 12:04 ` [bug#74187] [PATCH 20/20] gnu: node: Rename variable node-bootstrap and hide package jlicht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bcb5780bc95bc224ef8e425a93cce0177c1b66dd.1730634823.git.jlicht@fsfe.org \
    --to=jlicht@fsfe.org \
    --cc=74187@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).