unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: 26454@debbugs.gnu.org
Subject: bug#26454: [PATCH 2/2] gnu: add emacs-exwm
Date: Sun, 16 Apr 2017 12:39:07 +0530	[thread overview]
Message-ID: <babd2486.AEUAJCbLnToAAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY8xig@mailjet.com> (raw)
In-Reply-To: <87k26ldys5.fsf@163.com>


Feng Shu writes:

> Arun Isaac <arunisaac@systemreboot.net> writes:
>
>> You should be able to do this just using #:make-flags. See
>> https://www.gnu.org/software/make/manual/html_node/Overriding.html
>
> emacs-build-system seem to have no #:make-flags, I just use
> "make var1=var1 all" instead.

Ah, yes. I forgot!

> the rest have been fixed, thanks!
>
> the below is new patch:

I'm not able to apply your patch. Could you send the patches made
against the latest master? Thanks!

> +    (arguments
> +     `(#:emacs ,emacs
> +       #:phases
> +       ;; Generate .el files from the XML description of the XCB bindings.
> +       ;; This will be adjusted when xelb developer comment in issue page:
> +       ;; https://github.com/ch11ng/xelb/issues/16
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'regenerate-el-files
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (zero? (system* "make"
> +                             (string-append "PROTO_PATH="
> +                                            (assoc-ref inputs "xcb-proto")
> +                                            "/share/xcb")
> +                             (string-append "EMACS_BIN="
> +                                            (assoc-ref inputs "emacs")
> +                                            "/bin/emacs -Q")
> +                             "all")))))))

"all" is the default target, isn't it? In the interest of brevity, you
can drop it.

> +    (native-inputs `(("xcb-proto" ,xcb-proto)))
> +    (home-page "https://github.com/ch11ng/xelb")
> +    (synopsis "X protocol Emacs Lisp Binding")
> +    (description "@code{emacs-xelb} is a pure Emacs Lisp implementation
> +of the X11 protocol based on the XML description files from the XCB
> +project. It features an object-oriented API and permits a certain degree
> +of concurrency. It should enable you to implement low-level X11 applications.")

There should be two spaces after the full stop '.' at the end of a
sentence. Do run through 'guix lint'. It will warn you about this.

> +(define-public emacs-exwm
> +  (package
> +    (name "emacs-exwm")
> +    (version "0.13-3.7a5bb11")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ch11ng/exwm")
> +                    (commit "7a5bb1156d07848e465f55fd31f8ec755b52aa01")))
> +              (file-name (string-append name "-" version "-checkout"))
> +              (sha256
> +               (base32
> +                "0cbaq2ls8pivz4h8hwgn9ldvg16pwlisdf047civvilqiqczw31w"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-xelb" ,emacs-xelb)))
> +    (inputs
> +     `(("xhost" ,xhost)
> +       ("dbus" ,dbus)))
> +    ;; The following functions and variables needed by emacs-exwm are
> +    ;; not included in emacs-minimal:
> +    ;; scroll-bar-mode, fringe-mode
> +    ;; x-display-pixel-width x-display-pixel-height
> +    (arguments
> +     `(#:emacs ,emacs
> +       #:phases
> +       ;; Generate .el files from the XML description of the XCB bindings.
> +       ;; This will be adjusted when xelb developer comment in issue page:
> +       ;; https://github.com/ch11ng/xelb/issues/16

This comment is only for emacs-xelb, and shouldn't be here, right?

Everything else LGTM. Please send one last patch set. There may be a few
more minor corrections. I'll make them and push. I'm eager to try out
exwm. I didn't know about it before your patch. Thank you! :-)

  reply	other threads:[~2017-04-16  7:10 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 22:58 bug#26453: [PATCH 1/2] gnu: add emacs-xelb Feng Shu
2017-04-11 22:58 ` bug#26454: [PATCH 2/2] gnu: add emacs-exwm Feng Shu
2017-04-12  9:35   ` Arun Isaac
2017-04-12 18:13     ` Alex Kost
2017-04-12 20:05       ` Arun Isaac
2017-04-13  1:14         ` tumashu
2017-04-13  5:21           ` Arun Isaac
2017-04-14 11:54             ` Feng Shu
2017-04-14 13:27               ` Arun Isaac
2017-04-14 15:13                 ` Feng Shu
2017-04-14 17:24                   ` Arun Isaac
2017-04-15  2:37                     ` tumashu
2017-04-15 12:29                       ` Feng Shu
2017-04-15 21:13                         ` Arun Isaac
     [not found]                         ` <e0ed6d82.AEAAJGDHDFkAAAAAAAAAAAO1LyIAAAACwQwAAAAAAAW9WABY8o0b@mailjet.com>
2017-04-15 23:41                           ` Feng Shu
2017-04-16  7:09                             ` Arun Isaac [this message]
2017-04-16  8:04                               ` Feng Shu, Arun Isaac
2017-04-16 20:53                                 ` Arun Isaac
2017-04-16 21:22                                   ` tumashu
2017-04-17  2:14                                     ` tumashu
2017-04-17 13:47                                       ` Arun Isaac
2017-04-18  8:20                                         ` Ludovic Courtès
2017-04-18 13:38                                           ` Arun Isaac
2017-04-18 20:39                                             ` Arun Isaac
2017-04-23  9:54                                         ` tumashu
2017-04-28 18:57                                           ` Arun Isaac
2017-04-14 21:47                   ` Ludovic Courtès
2017-04-16  9:32                 ` Ludovic Courtès
2017-04-16 11:06                   ` Arun Isaac
2017-04-16 21:09                     ` tumashu
2017-04-13  5:25           ` Arun Isaac
2017-04-13 21:04             ` Ludovic Courtès
2017-04-14  5:40               ` Arun Isaac
2017-04-16  9:03         ` Alex Kost
2017-04-16  9:29           ` Arun Isaac
2017-04-17 13:27   ` bug#26454: [PATCH 1/2] gnu: Add emacs-xelb Arun Isaac
2017-04-12  9:34 ` bug#26453: [PATCH 1/2] gnu: add emacs-xelb Arun Isaac
2017-04-12 10:12 ` Arun Isaac
     [not found] ` <cu7zifmezqp.fsf@systemreboot.net>
2017-04-13  5:26   ` Arun Isaac
     [not found] <20170417132743.5683-1-arunisaac@systemreboot.net>
2017-04-17 13:27 ` bug#26454: [PATCH 2/2] gnu: Add emacs-exwm Arun Isaac
     [not found] ` <c675c264.AEMAJSAD6iUAAAAAAAAAAAO1LyIAAAACwQwAAAAAAAW9WABY9MMd@mailjet.com>
2017-04-17 14:41   ` Feng Shu
2017-04-17 17:23     ` Arun Isaac
2017-04-17 21:51       ` Feng Shu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=babd2486.AEUAJCbLnToAAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY8xig@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=26454@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).