From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MFB6BVHtW18tRAAA0tVLHw (envelope-from ) for ; Fri, 11 Sep 2020 21:34:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iN9wO1DtW18aRgAA1q6Kng (envelope-from ) for ; Fri, 11 Sep 2020 21:34:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 46C609401CF for ; Fri, 11 Sep 2020 21:34:08 +0000 (UTC) Received: from localhost ([::1]:55220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGqgJ-0003nu-0X for larch@yhetil.org; Fri, 11 Sep 2020 17:34:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGqgE-0003nl-6L for guix-patches@gnu.org; Fri, 11 Sep 2020 17:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34180) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGqgD-0000y9-TE for guix-patches@gnu.org; Fri, 11 Sep 2020 17:34:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGqgD-0001vw-P4 for guix-patches@gnu.org; Fri, 11 Sep 2020 17:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43347] [PATCH] services: dovecot: Do not require dovecot to be globally installed. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Sep 2020 21:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43347 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois , 43347@debbugs.gnu.org Received: via spool by 43347-submit@debbugs.gnu.org id=B43347.15998599827365 (code B ref 43347); Fri, 11 Sep 2020 21:34:01 +0000 Received: (at 43347) by debbugs.gnu.org; 11 Sep 2020 21:33:02 +0000 Received: from localhost ([127.0.0.1]:45726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGqfG-0001ui-As for submit@debbugs.gnu.org; Fri, 11 Sep 2020 17:33:02 -0400 Received: from tobias.gr ([80.241.217.52]:35924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGqfC-0001uE-6u for 43347@debbugs.gnu.org; Fri, 11 Sep 2020 17:33:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=BuLG+kDtKeFHzM29yL1xO5cs7DYNEfq3itCq6WTYTbY=; h=references: in-reply-to:subject:to:from:date; b=W6kPykokW+F/sYTrHxiZGfzlmUzS7E7BYT 24fX7/ACpqMvq7c/PPsWQozcimW3eDo3Pdia1nnkmLL6/EQ1FdhL/khypyufRZOiaEHX2t IMuoprQraVfSAoioqqTYFg09Ga7v14zp3+lm6aDYB/SYPwx3GQVaAT/Yp4OtPH3xgBWo1C onxzDFaWYx/0v7xPQArSgD87EaLbsZNFBQj2Qhmt6yqNQwOGietXUKmsLI94SPfrw3n06v Qkf0nYG78G0UEF/S4w0p2quOyHA2ADoeV/er/xndopV9uLGUICpQiJDqnZHn2ChtDEA8// s52xzzVEWGylil3Wh84fcK0iHRFg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id 752fbba4; Fri, 11 Sep 2020 21:33:31 +0000 (UTC) MIME-Version: 1.0 Date: Fri, 11 Sep 2020 23:33:31 +0200 In-Reply-To: <87k0x09k6h.fsf@gmx.com> References: <87k0x09k6h.fsf@gmx.com> Message-ID: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=tobias.gr header.s=2018 header.b=W6kPykok; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: jewcCZpqU9gG Pierre, Thank you very much for the bug report. On 2020-09-11 21:40, Pierre Langlois wrote: > I noticed recently my little dovecot mailserver failed to boot, I > tracked it down to our service installing a symlink as: > > /etc/dovecot/modules -> /run/current-system/profile/lib/dovecot > > However, I didn't have the dovecot package globally installed, the > service does not install it AFAICT. Sorry, this is my fault. I've been slowly merging some Dovecot improvements[0] into master. While I'm happily replying from the latest Dovecot service, I run it in an... idiosyncratic manner that had me write some glue code to test these patches. I didn't realize that said glue was doing more work than I, er, realized. Too much. > We could extend the service to install dovecot into the global profile, > however instead we can just symlink /etc/dovecot/modules to the dovecot > package in the store directly. Nack. That just reverts to last week's monolithic Dovecot service that doesn't support modules, but now with pointless indirection via /etc. Nor should the service add anything to the system profile, or expect the user to do so. The fix is to add a ‘modules’ field to the service configuration that, exactly like CUPS's ‘extensions’ field, adds module packages like dovecot-pigeonhole to the union directory that /etc/dovecot/modules points to. Kind regards, T G-R Sent from a Web browser. Excuse or enjoy my brevity. [0]: https://issues.guix.gnu.org/42899