From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d57yz-0003SP-Vo for guix-patches@gnu.org; Mon, 01 May 2017 05:51:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d57yw-0001sx-Px for guix-patches@gnu.org; Mon, 01 May 2017 05:51:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:50302) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d57yw-0001sa-MJ for guix-patches@gnu.org; Mon, 01 May 2017 05:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d57yw-0005ne-DW for guix-patches@gnu.org; Mon, 01 May 2017 05:51:02 -0400 Subject: bug#26730: [PATCH] Fix bzip2 utilities Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d57xz-0003Mq-Ix for guix-patches@gnu.org; Mon, 01 May 2017 05:50:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d57xv-0001WH-LX for guix-patches@gnu.org; Mon, 01 May 2017 05:50:03 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:49489 helo=mira.cbaines.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d57xv-0001W9-Ck for guix-patches@gnu.org; Mon, 01 May 2017 05:49:59 -0400 Received: from [192.168.15.219] (my83-216-89-206.cust.relish.net [83.216.89.206]) by mira.cbaines.net (Postfix) with ESMTPSA id 2C24F13E3C9 for ; Mon, 1 May 2017 10:49:56 +0100 (BST) From: Christopher Baines Message-ID: Date: Mon, 1 May 2017 10:49:50 +0100 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gDXNw4IbHb6ee67NXuaTdqqReBP8P5T3J" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26730@debbugs.gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gDXNw4IbHb6ee67NXuaTdqqReBP8P5T3J Content-Type: multipart/mixed; boundary="k6Oq8FPbJ9H5IbIW5xGOafNatWKf3FFwo"; protected-headers="v1" From: Christopher Baines To: guix-patches@gnu.org Message-ID: Subject: [PATCH] Fix bzip2 utilities --k6Oq8FPbJ9H5IbIW5xGOafNatWKf3FFwo Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable The bzip2 package includes wrappers around diff, grep and less/more. These shell scripts currently include /usr/bin (and sometimes /bin) on the PATH, and therefore fail if any of the commands that they rely on cannot be found. By substituting /usr/bin (and /bin) for the appropriate package paths, these scripts work much more reliably. I had some issues with bzmore which uses more from util-linux, I think there might be a circular dependency in the Guix package tree, as I get a VM stack overflow when including util-linux as a input to bzip2. Note that as the bzip2 package is used by so many other packages, any non-superficial change to it probably means rebuilding the world. Below is a script, and two invocations of it, showing first what happens with the unaltered package, and then the package with the modifications I describe above. #!/bin/sh set -x bzip2 < /etc/shells > shells.bz2 bzcmp shells.bz2 shells.bz2 bzdiff shells.bz2 shells.bz2 bzegrep bash shells.bz2 bzfgrep bash shells.bz2 bzgrep bash shells.bz2 bzless shells.bz2 bzmore shells.bz2 =E2=86=92 PATH=3D/gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/= bin =2E/test.sh + bzip2 + bzcmp shells.bz2 shells.bz2 /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzcmp: line 16: sed: command not found /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzcmp: line 40: mktemp: command not found cannot create a temporary file + bzdiff shells.bz2 shells.bz2 /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzdiff: line 16: sed: command not found /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzdiff: line 40: mktemp: command not found cannot create a temporary file + bzegrep bash shells.bz2 /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzegrep: line 11: sed: command not found /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzegrep: line 43: sed: command not found /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzegrep: line 63: grep: command not found + bzfgrep bash shells.bz2 /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzfgrep: line 11: sed: command not found /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzfgrep: line 43: sed: command not found /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzfgrep: line 63: grep: command not found + bzgrep bash shells.bz2 /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzgrep: line 11: sed: command not found /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzgrep: line 43: sed: command not found /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzgrep: line 63: grep: command not found + bzless shells.bz2 /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzless: line 8: sed: command not found ------> shells.bz2 <------ /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzless: line 55: more: command not found + bzmore shells.bz2 /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzmore: line 8: sed: command not found ------> shells.bz2 <------ /gnu/store/s3c442d075fc8a0q0nspc9jjsgjq613p-bzip2-1.0.6/bin/bzmore: line 55: more: command not found =E2=86=92 PATH=3D/gnu/store/i3zkljbz6ryqdlfc9gnpcjg964inp9l3-bzip2-1.0.6/= bin =2E/test.sh + bzip2 + bzcmp shells.bz2 shells.bz2 + bzdiff shells.bz2 shells.bz2 + bzegrep bash shells.bz2 /run/current-system/profile/bin/bash /gnu/store/nylrl843mkfdwzz8cd5iabsib37vqc1j-bash-4.4.A/bin/bash + bzfgrep bash shells.bz2 /run/current-system/profile/bin/bash /gnu/store/nylrl843mkfdwzz8cd5iabsib37vqc1j-bash-4.4.A/bin/bash + bzgrep bash shells.bz2 /run/current-system/profile/bin/bash /gnu/store/nylrl843mkfdwzz8cd5iabsib37vqc1j-bash-4.4.A/bin/bash + bzless shells.bz2 ------> shells.bz2 <------ + bzmore shells.bz2 ------> shells.bz2 <------ /gnu/store/i3zkljbz6ryqdlfc9gnpcjg964inp9l3-bzip2-1.0.6/bin/bzmore: line 55: more: command not found --k6Oq8FPbJ9H5IbIW5xGOafNatWKf3FFwo-- --gDXNw4IbHb6ee67NXuaTdqqReBP8P5T3J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQJFBAEBCAAvFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlkHBL4RHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcPWw/8CcpSJT7Et3hAyO0K/Agmdng1l0H8/XgG CPhsMRJLVi3qDAuofIesWlUWt8EtGs8USK/O5QBFkVzH+CSByZnM2HqLjwS/j7pR 59bM6tWp1bGNPPK5Jv7ns2oDR+mbYmn0kMKlJlOxJgNDaiC9eVO43ubYdrtJL22y T4z/vDuTwqyzN/BujLoCbJDQNVveHLeXKDgJf20Lg/3wKVOJXzSVsM6COU29AwHt gpq53q6AHxVUplEt3tOBHgjH4ryTTI5cCv9Tlz9qr8hYztjNjJZ+olVWH401l+cw n5QyJ/lDygRb7xfXWlJ+1SFwkXY4Vp6X16G5aB1jWSp0kKW+ULfeIfem0o5YEMh+ GXT6GWojv3NfWytwdyb9RtGv9hpT37hvbbi9aJx5yZDqctTFLPc7Kdl/Nh7/yTar rVJr7aGK36hwOklNf5SsTwjqHoPfcIQDmF1eDiRUggWkBxjeoK5lVNEt+Wzb5CTz 6vRgvZOxEYFUdzVFnjLnayOkwTIhJ5bRO3kBUXYlWXu4xB3qb8LmpjJtHdlfzdru 5P+G33SqX/o31s469wCBuIQQa/QJ6F/jQdrgVN6xnv3e/I8As+gETYB3OzEUneGb ohUy5tIw3O4CpAUq+aQ1HLIRuZDCymo8EfBFU9TZroRl0hXRZ6SnJlE6r4QbVmp8 MWBGmrieL5o= =2ngn -----END PGP SIGNATURE----- --gDXNw4IbHb6ee67NXuaTdqqReBP8P5T3J--