unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>, 49227@debbugs.gnu.org
Subject: [bug#49227] [PATCH 1/3] build: qt-build-system: Allow users to override/extend XDG_DATA_DIRS.
Date: Sat, 26 Jun 2021 18:32:26 +0200	[thread overview]
Message-ID: <b9604603f40753e5054c82574ea1a95108297b01.camel@telenet.be> (raw)
In-Reply-To: <20210625180823.10382-1-maxim.cournoyer@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Maxim Cournoyer schreef op vr 25-06-2021 om 14:08 [-0400]:
>     ;; These shall match the search-path-specification for Qt and KDE
>     ;; libraries.
> -   (list '("XDG_DATA_DIRS" directory "/share"
> +   (list '("XDG_DATA_DIRS" suffix directory "/share"

I'd recomend adding a comment here, explaining why 'suffix' is necessary
and '=' is unsufficient, with a link to the bug and patches tracker,
for clarity.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2021-06-26 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 18:04 [bug#49227] [PATCH 0/3] Some Qt/qtbase improvements Maxim Cournoyer
2021-06-25 18:08 ` [bug#49227] [PATCH 1/3] build: qt-build-system: Allow users to override/extend XDG_DATA_DIRS Maxim Cournoyer
2021-06-25 18:08   ` [bug#49227] [PATCH 2/3] gnu: qtbase: Enable GTK support Maxim Cournoyer
2021-06-25 18:08   ` [bug#49227] [PATCH 3/3] gnu: qtbase: Specify configure flags via the #:configure-flags argument Maxim Cournoyer
2021-06-26 16:32   ` Maxime Devos [this message]
2021-07-02 21:08     ` bug#49227: [PATCH 1/3] build: qt-build-system: Allow users to override/extend XDG_DATA_DIRS Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9604603f40753e5054c82574ea1a95108297b01.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=49227@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).