unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ahmad Draidi via Guix-patches via <guix-patches@gnu.org>
To: 64755@debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi@redscript.org>,
	Andrew Tropin <andrew@trop.in>,
	Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#64755] [PATCH] gnu: git-modes -> emacs-git-modes.
Date: Fri, 21 Jul 2023 00:49:18 +0400	[thread overview]
Message-ID: <b921bab4f546ca8ce5c4a9c1a9a9887343e75fda.1689886157.git.a.r.draidi@redscript.org> (raw)

* gnu/packages/emacs-xyz.scm (emacs-git-modes): New variable.
(git-modes): Deprecate variable.
---

This makes the package name consistent when installing it through 'guix package -i' and a variable name in a system declaration file (e.g. /etc/config.scm). It finishes the job in #29582.

Not sure if the deprecation method I used is optimal, since it brings back to life the package name 'git-modes'. However, putting 'emacs-git-modes' in 'old-name' causes 'warning: ambiguous package specification', as expected.

 gnu/packages/emacs-xyz.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 550e5d2a65..6e8b2b313c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1261,7 +1261,7 @@ (define-public emacs-project
 some utility functions, and commands using that infrastructure.")
     (license license:gpl3+)))
 
-(define-public git-modes
+(define-public emacs-git-modes
   (package
     (name "emacs-git-modes")
     (version "1.4.1")
@@ -1285,6 +1285,9 @@ (define-public git-modes
 @file{.git/config}.")
     (license license:gpl3+)))
 
+(define-public git-modes
+  (deprecated-package "git-modes" emacs-git-modes))
+
 (define-public emacs-with-editor
   (package
     (name "emacs-with-editor")

base-commit: 21b718f4d6c3ded8ef50d12f6e9ae6474f74620f
-- 
2.41.0





             reply	other threads:[~2023-07-20 21:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 20:49 Ahmad Draidi via Guix-patches via [this message]
2023-07-21 18:27 ` [bug#64755] [PATCH] gnu: git-modes -> emacs-git-modes Liliana Marie Prikler
2023-07-22 10:15   ` Ahmad Draidi via Guix-patches via
2023-07-22 10:35 ` [bug#64755] [PATCH v2] gnu: Rename git-modes to emacs-git-modes Ahmad Draidi via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b921bab4f546ca8ce5c4a9c1a9a9887343e75fda.1689886157.git.a.r.draidi@redscript.org \
    --to=guix-patches@gnu.org \
    --cc=64755@debbugs.gnu.org \
    --cc=a.r.draidi@redscript.org \
    --cc=andrew@trop.in \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).