From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cJ3/M+YJvmH9VAAAgWs5BA (envelope-from ) for ; Sat, 18 Dec 2021 17:18:46 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YPHEL+YJvmH5fgAAB5/wlQ (envelope-from ) for ; Sat, 18 Dec 2021 16:18:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 94ABEC74B for ; Sat, 18 Dec 2021 17:18:46 +0100 (CET) Received: from localhost ([::1]:44548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mycQ1-0003K1-Of for larch@yhetil.org; Sat, 18 Dec 2021 11:18:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mycOM-0000Ys-QH for guix-patches@gnu.org; Sat, 18 Dec 2021 11:17:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mycOM-0005Md-Gm for guix-patches@gnu.org; Sat, 18 Dec 2021 11:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mycOM-0003oK-Cp for guix-patches@gnu.org; Sat, 18 Dec 2021 11:17:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Dec 2021 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 51838@debbugs.gnu.org Cc: Timothy Sample , Pierre Langlois , Jelle Licht Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163984421014615 (code B ref 51838); Sat, 18 Dec 2021 16:17:02 +0000 Received: (at 51838) by debbugs.gnu.org; 18 Dec 2021 16:16:50 +0000 Received: from localhost ([127.0.0.1]:43630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mycOA-0003ne-7Z for submit@debbugs.gnu.org; Sat, 18 Dec 2021 11:16:50 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]:35447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mycO8-0003nS-EY for 51838@debbugs.gnu.org; Sat, 18 Dec 2021 11:16:48 -0500 Received: by mail-qt1-f173.google.com with SMTP id j17so5786000qtx.2 for <51838@debbugs.gnu.org>; Sat, 18 Dec 2021 08:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=7rKT/PMnT4TM/URN2Jq7EelxpIGA1hcAHbBAHS13w+c=; b=TjkA9dsgu3n5MTvANTKhbWynqLpoU6Ksvf1V5GCvo9JfPd+mLviOemReXB4nnaUHdh qRCN/YM5IDH0VyYgSvoL0MJbrvMLGmCwLfjInKwa9Hhft4zSKHHTYIyRnBYbvYjjSbUX Zm54raRrrC/D4/gmRbEl+ifYT/2n9O/9FhVCumDBOsyAug77i43U5+7NKPUwQ3BAw3+U D9mYlqld6xjmBP1pZLouOvqy1z1OOesTYUGQi2QsCY/BNiGANIRVaIlqIB5/g4aXsZH8 1Z4q+Z4Z/zvhUfWiR/DU2HaVC3cGijCJg80mw6J+q5Dy/lmnI6VKpeicDQNkC+1WKKPn nH2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7rKT/PMnT4TM/URN2Jq7EelxpIGA1hcAHbBAHS13w+c=; b=1jJnAqsktvt5oE94FTGFkY20Rk3CZVYDOIT66fDC+5XWUS6mVJB22usZOsso0mHNli dGm6SfuGTg/aeqh/g+LRCJTWe/lzPo5zYLcTZRYpkUq5JI0qB2LgkqqIMcJ52+yCUm5/ b97Nix0y6S8IkHYBCReLz1JWexk9dv8M6W27GQrWcaHFF+bYw1KQc9Vg6o7l5C4v+hSj HpaPb/DEhzoT54rY1VX56lpQ8p1vqTEkQWmlPTH2hHQUmquCJ7zNbUx9eSLcIzz2KCd6 s5H8946QdMmz8vPa7ytXIpMaxzxKa7dQCJH4v9Xww7YXN2rDpb9VGDY6fr/NpZ9jQ3lO PamA== X-Gm-Message-State: AOAM531+L+GtjMZI2gEv9CctBQ5SZ+05U6+i83BfvO+mT7gHlH5py/HQ Kth2p48aQ8QtvTELJgQg5l0P+A== X-Google-Smtp-Source: ABdhPJx7Ru9dfyZfDRB+pPm3X6xFR4ho93G0vpnoavMSiog9cXrEAEPrPg8+goRGw5Jio/DCV1eBWA== X-Received: by 2002:a05:622a:1a03:: with SMTP id f3mr6805980qtb.141.1639844202940; Sat, 18 Dec 2021 08:16:42 -0800 (PST) Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id x4sm10043749qtw.44.2021.12.18.08.16.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Dec 2021 08:16:42 -0800 (PST) Message-ID: Date: Sat, 18 Dec 2021 11:16:41 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US References: <20211213060107.129223-1-philip@philipmcgrath.com> <20211217020325.520821-1-philip@philipmcgrath.com> <20211217020325.520821-21-philip@philipmcgrath.com> From: Philip McGrath In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639844326; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7rKT/PMnT4TM/URN2Jq7EelxpIGA1hcAHbBAHS13w+c=; b=Puw4OlVnSDGxJ2xU+hMzGQs5/fTdn1hDa7XbI6A97JvR+TODCTU64TfT5kKE9LzWxA7w7L w5bAj0d1IlvRXkidbowaSr8G3cNHcaqTeO7YqrghYG4WD03gWfpzh+idG7IOHKnhnjZlc/ j+RzuxFj+4BhHkxiHP1kX70BO2huXBFi4lo5aZvol8U08GtyYwbHrBgGSHY6ssWCK4DUhp qWF3HNI9AHUzSgNTTYzjGgcJcER3uwcgvEUV0DclqH8agk0kONAhdSw7Qdw5ga2iZNt4JQ 3HVFhX42KpCl6WEchK+7IdSPsbMLBw1g0vuXpuME1J0Cd8jNZqE5ojtLAfWP1w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639844326; a=rsa-sha256; cv=none; b=SlYlzy5PWnmWdX99QjPjTXZHI2tPUkJRzea6RojQWvUUrXSQRDMvGQtolvWgB9k+5i+VaB 5H/NGyUkMuH70iMx0FARovLktySbY6VnCTe7rGfYdFRpA1pGb+JhfFTpIXzzK1aNgO7h+C gG5peyZeDWXwoI24LgFpnsRGByuH2EKggmAtzrEugcqHQ1bA0s7d9wEAfjTQGnQU+QV9Cf Fm6sR++BIteccoqyGtx6Vw0+7Fp3J5sPAZCG5Ys6ULeyqqicub2fFBJ8xcb86miLwdrEG9 KcnSbXL86C06+ORuff2bwI/cGX+18Kjv5hSU64ld/TGPH1KKPv6zPIpHXses2Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=TjkA9dsg; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.51 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=TjkA9dsg; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 94ABEC74B X-Spam-Score: -1.51 X-Migadu-Scanner: scn0.migadu.com X-TUID: VFbzdP3ppQQl Hi, On 12/17/21 00:08, Liliana Marie Prikler wrote: > Am Donnerstag, dem 16.12.2021 um 21:03 -0500 schrieb Philip McGrath: >> * guix/build-system/node.scm (lower): Add the version of libuv >> used as an input to the #:node package as an additional implicit >> input, so that packages needing libuv always get the correct version. >> --- >>  guix/build-system/node.scm | 9 ++++++++- >>  1 file changed, 8 insertions(+), 1 deletion(-) >> > Do this and #21 have to be separated so far from the rest? If not, I'd > do build system first, then new packages. Otherwise fair enough. I tried to follow Tim's suggestion in to put the changes related to #:absent-dependencies before the changes to support native addons, so that the earlier changes could potentially be applied even if there was more discussion needed for the later ones (if #:absent-dependencies were less controversial. But note that the patches before this one aren't adding new packages; they are changing existing packages to use #:absent-dependencies rather than deleting the configure phase. So the series is ordered overall as: 1. Changes to the `node` package itself 2. Build system changes for #:absent-dependencies (including the delete-lockfiles phase, because un-deleting the configure phase exposes those problems) 3. Packages changes to use #:absent-dependencies 4. Build system changes to support native addons 5. New packages to exercise the support for native addons -Philip