From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id ODFODKBidGTDSgEASxT56A (envelope-from ) for ; Mon, 29 May 2023 10:30:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UB0nDKBidGTY9gAAauVa8A (envelope-from ) for ; Mon, 29 May 2023 10:30:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EC8D1C388 for ; Mon, 29 May 2023 10:30:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3YGT-0004qa-2E; Mon, 29 May 2023 04:30:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3YGS-0004qM-3w for guix-patches@gnu.org; Mon, 29 May 2023 04:30:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3YGR-0007K5-QE for guix-patches@gnu.org; Mon, 29 May 2023 04:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3YGR-0004IM-5e for guix-patches@gnu.org; Mon, 29 May 2023 04:30:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63508] [PATCH v2 4/4] gnu: eudev: Have udevadm look in /etc/udev/rules.d. (Closes: #63508) Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 29 May 2023 08:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Felix Lechner Cc: 63508@debbugs.gnu.org Received: via spool by 63508-submit@debbugs.gnu.org id=B63508.168534900016475 (code B ref 63508); Mon, 29 May 2023 08:30:03 +0000 Received: (at 63508) by debbugs.gnu.org; 29 May 2023 08:30:00 +0000 Received: from localhost ([127.0.0.1]:57030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3YGO-0004Hf-2H for submit@debbugs.gnu.org; Mon, 29 May 2023 04:30:00 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:46355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3YGM-0004HS-Hx for 63508@debbugs.gnu.org; Mon, 29 May 2023 04:29:59 -0400 Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-96f6a9131fdso449936866b.1 for <63508@debbugs.gnu.org>; Mon, 29 May 2023 01:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685348993; x=1687940993; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=RYCpWplS8fClxKIK+2cRi/yW+2K0fghEBnrNpQ6kBjU=; b=jWZmKp8Lzes+T/AkbE3zA2sFTHCSqWQSNk5elP4iCE7Bx4tMflpb1GW3e9rB7CC8C8 iVis5qWoENuu8wxfNOuxYmd49k2AEEwVgVp1S27kndLGfAUoTm2LSMIJK2jo4pNXbkwi BnvqbI5nbOEuj37cFt4KXyLWZx9HJOrBQWJpBPx93vK8CKGd5ShzH6SbGkxWfWG1nBSZ W3iQY0iPJz/CIz2fOwccg0LxMdYaKrw00SBzE2U04BJbd2GVBbJM9ev2FWJ/GJ4KduZ1 KUdITHHajOl3o87xVKRFMHu9WbUF96BGT6C5URnTEeWYVtEuNuPA+SqikR+7uOSwTWWu 62lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685348993; x=1687940993; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RYCpWplS8fClxKIK+2cRi/yW+2K0fghEBnrNpQ6kBjU=; b=c5T8qwkOsYK7IvDQnBEIuz9unQdaEf/j3fBN6aUgXTSQVECVWUjXbENtjpQemtU44M JsgpBI5+OQKAo/RMt8QO+MZgHGXFKuAHuPlcNitHX1GZrHXu5EXcPTyeIe94CkuD5SzN eVAzMrqVbTagRiH//lMH1SJ7YYgNbDC77ji47WS6vnom0/E8vGP+wbYZrN1oJYOoCOES LFIunY+yQKulwv2DX4U56WY7vTe6/fSKrsNim9HVW2ZWzKiiI/r3t4xXCIQ0rghlbw93 c0wpGSwCuLr0BxH73l+YkgC/6VJvWRvk1puXA9uhs1dUkyYQUNGOC/ciODdYQn9+ckTN eFHQ== X-Gm-Message-State: AC+VfDy3Am4xfTipjcxHTWOUIsE7rEAnVkS+nw3YYZn7fQRWv177Xi38 YH+R8boRMlI08JFV1/BaKak= X-Google-Smtp-Source: ACHHUZ4PJdQdNHBI/KdsFLfMi0cueO2+QvIUojZoVOCh7YJx/3IpSlkiUpBPhLIDOJsGprQM2cMwZg== X-Received: by 2002:a17:906:9b87:b0:966:484a:335e with SMTP id dd7-20020a1709069b8700b00966484a335emr10160814ejc.43.1685348992660; Mon, 29 May 2023 01:29:52 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a17-20020a17090680d100b0096739e10659sm5609853ejx.163.2023.05.29.01.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 01:29:52 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Mon, 29 May 2023 10:29:51 +0200 In-Reply-To: References: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@lease-up.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685349024; a=rsa-sha256; cv=none; b=t7c+r4CL83XU22vKrIzzevwZoRBLpKuNSX69PfAVK1F6vMPWoidKXKn6+tYpKAQzAR3978 nzEdp5Lt0T8/LiHdCM/m6XOiUreEiSz/FtS03Z0uavTVjDu6KKWA74+KW8yxOX3zr4E+1v DwB3j4MI1+SFEJFIoN4EMD3t4pQ0jn9dvkSg2a1lR+ZWhMdLt77WTwI7EWz8NifuUo/miQ BsQC9aRcpq14YenMcFZXWxx7/XMSJbR20gklO54UvjaMaSvthC+iPe8wQ2yUprzmLC1s0U VbRwzM3cqgzTXmku63dwsSk72YQWRNw5wg8yddoMH5Cwx9E8BcPY7jS7qRMv6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=jWZmKp8L; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685349024; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RYCpWplS8fClxKIK+2cRi/yW+2K0fghEBnrNpQ6kBjU=; b=WVT9T70m5ZVuUnQ/xtTbEuSeBLUhGz/au24dISbKIokHn6RcXx+F0kermgNrvCcgjiwVIM MFoPCPxitC7Be7ZpeB7TAPSAnuWUYt3VZUbv/DsuEjDK9TQFaQXN15Omtcg0MDshWr/UOZ OEsKm9jcOVBSSjNnpMzQMMCZdqF4KFlxLiuHWotn+lMg2QGmkCK7WUk7aZJQ63UdsPXBZs jDBSk9rv53vQQtPgnvRhpctM+Z8Zi6JNdy4KWqQHOzz7rRmb2F1Iau08N8AFiBk8eqwgBP 49zUbEnYVlNyC32zYdGuC3a23fj7pSFMDrscZQzLKAdMQDHv5PM10viLa35Ucg== X-Migadu-Spam-Score: -2.11 X-Spam-Score: -2.11 X-Migadu-Queue-Id: EC8D1C388 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=jWZmKp8L; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: vsTgrMAMsFQ7 Am Sonntag, dem 28.05.2023 um 16:23 -0700 schrieb Felix Lechner: > Hi Liliana, >=20 > Thank you for your kind review! I will push a new version with > squashed commits you requested shortly. You mean "submit", right? > While I am new to Guix, I am not sure that Gexp conversions fall > under "style changes" in my book. I believe they are considerably > more complex, and fraught with greater error. True, but there is room for error in dropping input labels as well. In fact, eudev's labels do cause a rebuild, but I decided to push v3 1/3 anyway to get CI ready. > On Wed, May 17, 2023 at 9:19=E2=80=AFPM Liliana Marie Prikler > wrote: > >=20 > > you may object that this doesn't mention /etc/udev/rules.d and thus > > could be problematic on foreign distributions, but I argue that you > > probably shouldn't mess with foreign udev anyway, and if you do > > that setting EUDEV_RULES_DIRECTORY is appropriate. >=20 > The intent of my patch was not to mention /etc/udev/rules.d > explicitly, but rather to replace the store folder that holds the > upstream rules, which we are currently using, with the one Guix > constructs in order to use rules from other places. That just happens > to be /etc/udev/rules.d as well. >=20 > On that note, my patch is not suitable for upstream because it > hardcodes the location to the runtime path in Guix. Other > distributions may keep them in a different place. The current > Autoconf setup probably works well for them. The same reason why your patch wouldn't fly upstream is why it won't fly in Guix. We do have to consider foreign distributions as well. > Either way, udevadm in Guix is currently broken. This patch fixes it > and should please be accepted. Thanks! There is more than one way to fix a bug and I argue that the one you have chosen is not the right one. Granted, same could be said for my patch, but you have yet to file a formal complaint. The closest I can recall is "the resulting flexibility may not be needed", but here we are discussing foreign distros storing udev rules in some other location.=20 Cheers