From: Saku Laesvuori via Guix-patches via <guix-patches@gnu.org>
To: Simon South <simon@simonsouth.net>
Cc: 67808@debbugs.gnu.org
Subject: [bug#67808] [PATCH 1/5] guix: build-system: font: Accept license-file-regexp keyword argument
Date: Thu, 14 Dec 2023 08:46:55 +0200 [thread overview]
Message-ID: <b6irijuetbr4halj2lhcafnpxcecbdr7qhwekdvsfnpsx4bhgb@xqpgpdbwi2id> (raw)
In-Reply-To: <87zfye2mvd.fsf@simonsouth.net>
[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]
> Thanks for raising this again, Saku.
>
> The issue of the font-build-system not exposing its %license-file-regexp
> argument affects a number of font packages that either define a
> redundant phase or simply fail to install the right license files from
> their distribution. I attempted to address the problem comprehensively
> with the patches in issue 61253:
>
> https://issues.guix.gnu.org/61253
>
> In addition to exposing the "%license-file-regexp" argument the changes
> there also provide a default value that matches common font-license file
> names (including "OFL.txt") and correct the 29 font packages I found to
> have issues.
That looks like a much more complete fix/improvement than mine. Great!
> If there's interest in fixing this, I'm willing to review those patches
> to verify they fix the problem globally. Saku's update to the
> font-jetbrains-mono package and addition of font-jetbrains-mono-nerd
> could then (and maybe should) be handled each as a separate issue.
Sounds good to me. I'll rebase those patches onto your's now and again
later if needed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-12-14 6:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 8:00 [bug#67808] [PATCH 1/5] guix: build-system: font: Accept license-file-regexp keyword argument Saku Laesvuori via Guix-patches via
2023-12-13 8:02 ` [bug#67808] [PATCH 2/5] gnu: Add font-jetbrains-mono-nerd-font Saku Laesvuori via Guix-patches via
2023-12-13 8:02 ` [bug#67808] [PATCH 3/5] gnu: font-jetbrains-mono: Use license-file-regexp argument Saku Laesvuori via Guix-patches via
2023-12-13 8:02 ` [bug#67808] [PATCH 4/5] gnu: font-jetbrains-mono: Use the correct license Saku Laesvuori via Guix-patches via
2023-12-13 8:02 ` [bug#67808] [PATCH 5/5] gnu: font-jetbrains-mono: Update to 2.304 Saku Laesvuori via Guix-patches via
2023-12-13 14:33 ` [bug#67808] [PATCH 1/5] guix: build-system: font: Accept license-file-regexp keyword argument Simon South
2023-12-14 6:46 ` Saku Laesvuori via Guix-patches via [this message]
2023-12-14 7:35 ` [bug#67808] [PATCH v2 0/1] Add JetBrainsMono Nerd Font Saku Laesvuori via Guix-patches via
2023-12-14 7:35 ` [bug#67808] [PATCH v2 1/1] gnu: Add font-jetbrains-mono-nerd-font Saku Laesvuori via Guix-patches via
2023-12-14 14:01 ` [bug#67808] [PATCH v3 0/3] Add procedure for patching Nerd Fonts Saku Laesvuori via Guix-patches via
2023-12-14 14:01 ` [bug#67808] [PATCH v3 1/3] gnu: Add nerd-font-patcher Saku Laesvuori via Guix-patches via
2023-12-14 14:01 ` [bug#67808] [PATCH v3 2/3] gnu: Add Nerd Font patching procedure Saku Laesvuori via Guix-patches via
2023-12-14 14:01 ` [bug#67808] [PATCH v3 3/3] gnu: Add font-jetbrains-mono-nerd-font Saku Laesvuori via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6irijuetbr4halj2lhcafnpxcecbdr7qhwekdvsfnpsx4bhgb@xqpgpdbwi2id \
--to=guix-patches@gnu.org \
--cc=67808@debbugs.gnu.org \
--cc=saku@laesvuori.fi \
--cc=simon@simonsouth.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).