From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6CwCAlUztmJ7PQAAbAwnHQ (envelope-from ) for ; Fri, 24 Jun 2022 23:57:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uKz0AFUztmKMEAEAG6o9tA (envelope-from ) for ; Fri, 24 Jun 2022 23:57:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A3EA12E218 for ; Fri, 24 Jun 2022 23:57:40 +0200 (CEST) Received: from localhost ([::1]:46922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4rJ5-0007Ur-Gk for larch@yhetil.org; Fri, 24 Jun 2022 17:57:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4r40-0005gM-17 for guix-patches@gnu.org; Fri, 24 Jun 2022 17:42:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4r3y-0006ge-P1 for guix-patches@gnu.org; Fri, 24 Jun 2022 17:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o4r3y-0003GK-MT for guix-patches@gnu.org; Fri, 24 Jun 2022 17:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55541] [PATCH] gnu: Add azpainter. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Jun 2022 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55541 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Kortkamp Cc: 55541@debbugs.gnu.org Received: via spool by 55541-submit@debbugs.gnu.org id=B55541.165610692112524 (code B ref 55541); Fri, 24 Jun 2022 21:42:02 +0000 Received: (at 55541) by debbugs.gnu.org; 24 Jun 2022 21:42:01 +0000 Received: from localhost ([127.0.0.1]:43729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4r3x-0003Fr-Cv for submit@debbugs.gnu.org; Fri, 24 Jun 2022 17:42:01 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:54488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4r3v-0003Fa-LJ for 55541@debbugs.gnu.org; Fri, 24 Jun 2022 17:42:00 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id n9hx2700L4UW6Th069hxqt; Fri, 24 Jun 2022 23:41:58 +0200 Message-ID: From: Maxime Devos Date: Fri, 24 Jun 2022 23:41:49 +0200 In-Reply-To: <87sfntu6ft.fsf@gnu.org> References: <6d31ff958ec0c75cbba8324a275315d195a54902.1653045472.git.tobias.kortkamp@gmail.com> <87sfntu6ft.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-AcwItZI8e2x7wL9RMuKS" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1656106918; bh=YdfiA/eCl/TtRZ0NTvT0zZ4tUONiaxIfb1uvBg1vHM8=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=PN44nrQtmqCWbAS6fHFG5Gw/szELEIPas83C+eVotkm5Xo4q8UppeRWok03wfk/wC G9c7YkQYVw0NyQGJBMnLmAa8FaCQwuBvVL40M/eeXg7TZx/LDj1SAm1Mdx0NlT+qdq WC2AR8K591QgZjiyqBkle3o7S+rFu8RRrIJH8Yfh4C9OJYH8GhcZ+Ro0qRRG9G61ly jaQKiimMpm7Cnh4yPMFY8tmAaR/AFHiObgt0/2p7QcBWbg80UPRLP/dKmlFv4kcWqS Iq7mMY94pPL262qI8f3BwHYFsO338tqQAvNxey18r/y5DMNuxUH3e/4PUBgSpMZ8aa i1SeGiLG6Hw6g== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656107860; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=YdfiA/eCl/TtRZ0NTvT0zZ4tUONiaxIfb1uvBg1vHM8=; b=InDfDblpfX4q+jfL7C2MDE26rYeDf2BLexzb7WkVpTSnj1fxY5mv0OKriMOqWnU475mwAb ySdYyVxytalIsW2jPZxJXmhhJucjoir0uzU8SrwhackLBANq6H6+5prdlLmnuE6MNWoHpD T7SgE2j3LoPyBzmZi5D36s41nthgIc1UrJ5kdIA8qBe8i6hkTgBFgCUEZAhd3tba9MRI7P OMuFwQe4JKcB4wu8CBNUPr2fvRHkJTpQ1XysMh6BZfmPGAhFjWo3EXqS6UNDO29U2+WjYr gaoueeNs1nE4J7BgCPXAWQjMBgRley9H0/+xD1Bq9ih66JXAL10yboL8wVxJ5A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656107860; a=rsa-sha256; cv=none; b=sEM77xGmw44rmlx0yddB8tI0/lh97vl+T9dnZnZh2s17wdJmhNzFUgwtddm/0u4dupG+ew 94f4VTgjMhzZUzH+o0b6cXpiKoXsWPpzqENQa5XkE4OJQdcCbODhwDQftqqywT9B95wmef DW+w2M3TaV/s0eg1g3Z6DY9WDAAsklDPXqiO9h+zsKODbeBJRzxu8BHV4BNQbdUQD9vp7Q yxzX01bnpmYrzo/NozpZDT0ji7S898T1aocYmkOWyQ/p4Yje6QF1JOn6x9MM8Ko+YweX7L ir3L8FmxFEMqRDZmjtqUkjWBrsH/xLuDK+U3RssIFf14Tzu4WBmzS4B+Lgrz6w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=PN44nrQt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.54 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=PN44nrQt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A3EA12E218 X-Spam-Score: 2.54 X-Migadu-Scanner: scn0.migadu.com X-TUID: hEbTT3afwBTz --=-AcwItZI8e2x7wL9RMuKS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable reopen 55541 Ludovic Court=C3=A8s schreef op vr 24-06-2022 om 22:56 [+0200]: > These are all good points and I appreciate that you did such a thorough > review (audit?) of the package! I looked through the code a bit, didn't check every file, so I wouldn't call it an audit. >=20 > That said, I think it=E2=80=99s a bit too much to ask of a downstream pac= kager > or user to address these issues.=C2=A0 As I see it, these issues should b= e > reported upstream and addressed upstream. >=20 > I hope that makes sense! AFAICT the issues have not been reported upstream yet, so I don't think we can close this entry on debbugs yet. While I'd like for downstream packaging to be trivial, the sad reality is that sometimes is not the case, the issues are still there and need to be resolved somehow (fixed downstream or upstream, or reported upstream). If not by the new downstream packager that submitted the patch, then by the the one committing the patch, or by a reviewer, or by some more neboluous role of a random Guix contributor, or in some exceptional cases the issue could be considered =E2=80=98too difficult and not too bad= =E2=80=99 with some corresponding reasoning. (It's most efficient if the reporting or fixing is done directly by the submitter, but if the submitter can't do it for whatever reason, then surely something can eventually be worked out by other people, albeit more slowly.) However, AFAICT, none of that has happened yet. More generally, I don't think we should have an =E2=80=98packages included = in Guix should be good, unless submitted by a newbie=E2=80=99 exception. Also= , potentially the new submitter would _like_ to learn more about Guix (and have time for it, etc.) and learn how to improve things? In the future, if someone submits a patch and I notice it has some complicated problems, should I just ignore the complicated problems and just LGTM? This seems contrary to the concept of reviewing to me.=20 (This is probably not what you meant, but to me, this is implied by your response.) Greetings, Maxime. --=-AcwItZI8e2x7wL9RMuKS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYrYvnRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7ig9AP9pcwZ8puWNrKWPcJWxF/bmOAOD BeAQzoC70/cDcAyMkgEA1l1FsBcXedzmqAFkkg7bL/XMZ0u+/IuqjdQZ28S2WAk= =Q2JG -----END PGP SIGNATURE----- --=-AcwItZI8e2x7wL9RMuKS--