unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: 46216@debbugs.gnu.org
Subject: [bug#46216] [PATCH] Remove duplication in tests/publish.scm
Date: Sun, 31 Jan 2021 19:46:02 +0100	[thread overview]
Message-ID: <b5f02cfda1b0586c32ce5a8610b4e490a637c552.camel@telenet.be> (raw)

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

Hi Guix!

In https://issues.guix.gnu.org/46214, I proposed
a draft patch for adding a ‘hook’ mechanism to
guix publish.  Now I would like to write some tests.

However, it seems the following construct is duplicated
for many tests:

   (call-with-new-thread
    (lambda ()
      (guix-publish "--port=PORT" et cetera)))
			
This patch series introduces some abstraction.
Currently, there is only one patch yet, but more
will follow.

"make check TESTS=tests/publish.scm" still succeeds.
(Guix version: 23a5dcce1d893b8f5c5301ae3c1af863776ed3cf
with some not-yet-upstreamed changes).

Maxime
-- 
Maxime Devos <maximedevos@telenet.be>
PGP Key: C1F3 3EE2 0C52 8FDB 7DD7  011F 49E3 EE22 1917 25EE
Freenode handle: mdevos

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

             reply	other threads:[~2021-01-31 18:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-31 18:46 Maxime Devos [this message]
2021-01-31 18:52 ` [bug#46216] [PATCH] Remove duplication in tests/publish.scm Maxime Devos
2021-01-31 20:04 ` Maxime Devos
2021-01-31 22:01 ` Maxime Devos
2021-01-31 22:10 ` [bug#46216] Fwd: " Maxime Devos
2021-02-01 14:04 ` [bug#46216] " Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5f02cfda1b0586c32ce5a8610b4e490a637c552.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=46216@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).