From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:37539) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7JTL-0006gT-LP for guix-patches@gnu.org; Thu, 27 Feb 2020 08:45:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7JTK-0005zq-LR for guix-patches@gnu.org; Thu, 27 Feb 2020 08:45:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7JTJ-0005zl-Qo for guix-patches@gnu.org; Thu, 27 Feb 2020 08:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j7JTJ-0003tf-Nl for guix-patches@gnu.org; Thu, 27 Feb 2020 08:45:01 -0500 Subject: [bug#39717] [PATCH 1/3] gnu: delft-icon-theme: Use the copy-build-system. Resent-Message-ID: Message-ID: From: Leo Prikler Date: Thu, 27 Feb 2020 14:44:45 +0100 In-Reply-To: <875zfs6ubq.fsf@ambrevar.xyz> References: <20200221163215.11008-1-leo.prikler@student.tugraz.at> <87mu9472ai.fsf@ambrevar.xyz> <635f276d8ce7198de37c5c95387dc656ee80f4ae.camel@student.tugraz.at> <875zfs6ubq.fsf@ambrevar.xyz> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 39717@debbugs.gnu.org Am Donnerstag, den 27.02.2020, 14:19 +0100 schrieb Pierre Neidhardt: > Can you detail what does not work? Which file, what error message? $ find `guix build --source delft-icon-theme` -xtype l This returns a list of broken symlinks. On any of them, install-file fails with "file not found". > In my opinion, the install-plan should be able to install any file, > symlink or not. Failing to do so seems like a bug to me. I think I agree with you. Instead of simply doing (copy-file file dest), we'd have to check for symlinks as is done in copy-recursively. Now that I have a more complete understanding of this bug, I'll try to come up with a patch. Regards, Leo