From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oAxiD3ue2GGVHwEAgWs5BA (envelope-from ) for ; Fri, 07 Jan 2022 21:11:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cPo8CHue2GGuWwEAG6o9tA (envelope-from ) for ; Fri, 07 Jan 2022 21:11:39 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D5B0D28CB1 for ; Fri, 7 Jan 2022 21:11:38 +0100 (CET) Received: from localhost ([::1]:37090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5vaL-00019v-Ne for larch@yhetil.org; Fri, 07 Jan 2022 15:11:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5v9e-0002mj-Ez for guix-patches@gnu.org; Fri, 07 Jan 2022 14:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5v9d-0007Bz-TD for guix-patches@gnu.org; Fri, 07 Jan 2022 14:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5v9d-0007xY-Py for guix-patches@gnu.org; Fri, 07 Jan 2022 14:44:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v8 00/41] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Jan 2022 19:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timothy Sample Cc: 51838@debbugs.gnu.org, Pierre Langlois , Jelle Licht , Philip McGrath , Leo Famulari Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.164158462430561 (code B ref 51838); Fri, 07 Jan 2022 19:44:01 +0000 Received: (at 51838) by debbugs.gnu.org; 7 Jan 2022 19:43:44 +0000 Received: from localhost ([127.0.0.1]:45930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5v9L-0007wp-MK for submit@debbugs.gnu.org; Fri, 07 Jan 2022 14:43:44 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5v9I-0007wW-Qu for 51838@debbugs.gnu.org; Fri, 07 Jan 2022 14:43:41 -0500 Received: by mail-wr1-f67.google.com with SMTP id l10so12989609wrh.7 for <51838@debbugs.gnu.org>; Fri, 07 Jan 2022 11:43:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=p/sjncRcz34ZGyBYnQXcrPW0wO1Em+t65oDmwGSSG4M=; b=pgfNz7oHdrI/fNKqDrIMzO62gszEKHPH74AtnK7ahjPKgTEk94otZ7j71yPRspG2LF V2BnzKcslatWB0l1MacqhT51Vdom6tALdlqsVpUCFzHfk+3jpHh1jyxgbHP+ra0HgagP sk3XjSIccDjvfisBU/ws0cwOP1b/VLFKTB3/HrpeuZ/Ru1KGgnm2rbkCZaqTs8lcF+dZ BBlvLwNRksl0boof78sCsaHD8v+Aa2z4dfpu/ku3uYfgDCg184LUth6yXRjaYQ5hqQmh IxfZvPRjxbpEwSiHIeWfgEVsy32kVJ/zA87RKmooLl3qEl9yKsJQx27DqAbkzHKWJp1O Q8fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=p/sjncRcz34ZGyBYnQXcrPW0wO1Em+t65oDmwGSSG4M=; b=pb7H5oPofs4+u7Ry3AjgkXrTrsGCuKk/ozAe3LCGYcUEK3ShDov2AC6oqqIoAc3JVp htQYsKOGO10wzkk5rBLOlZ6u4cEQQ83iV71EpchDYo7sIa2/Ys066hK8RBZKruu4KO6w 10Mzq7U3fpY6EUvUKYon0HBFWaUdQauFlxCr9uVERwCnOIfcCEIWgfaWzhE/KT0G5d9r pxj3Ld27Vmgun3mP5H6xG4/Kj+0/KM6aFpqj/h4cMl2gqOuKlpDKuV9ZOsYK1qCZRDa1 Xep5exsrgx1jUCdk4pqJMrhpHjeQHTJ9GHdDZLdcVaqTbmQ3BKYr+f1FT+WrXBifPRfI 5Trw== X-Gm-Message-State: AOAM530HZz/9laeVzNMGzgAiEPTW2ayLHwlwPCjz4W3G8kOq6NRyFd/w 2o49lScNozDoPL/SmRr/glM= X-Google-Smtp-Source: ABdhPJxsyNK5a/2oCxJLXsg5SmbCpfmPKFsUNBJ/i9iJZDn659qgKuMYtQFR6c4cot0MrQAWHjf2sQ== X-Received: by 2002:adf:f68b:: with SMTP id v11mr7231095wrp.260.1641584614778; Fri, 07 Jan 2022 11:43:34 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id j26sm9962771wms.46.2022.01.07.11.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 11:43:34 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Fri, 07 Jan 2022 20:43:32 +0100 In-Reply-To: <87v8yv1ofd.fsf@ngyro.com> References: <64e08d3a1838ed8507f33fae895545372960522f.camel@gmail.com> <87v8yv1ofd.fsf@ngyro.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641586298; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=p/sjncRcz34ZGyBYnQXcrPW0wO1Em+t65oDmwGSSG4M=; b=m16IZt9gHIbaVZULGp9gmJrhHSnwGZldG0QN1RJwrqQOjYf7sZdbGhA6C5wr1RdwebP+nF n5qIB5TowO/1NVXgEJwbCZTVBTRGX0QtBLJwJE06Vpqce+O3Q5IHzn1xfmYyiVPu7sMYxS XdMe3cx0wK/qaBTcrbxSjMvflY7HOc6wGccExFUyGoah+jUEgolrdGdS7b695miVPVkNUk gz9hmFhLXhkWVUzURG+t7Ri2Qfo/kDNqpafSw3Z5NEb6Uqoh8OFG23K4eG0yvuKMoFzaJm fsIt+GohvHf1hJ/+rnhxIiuraovtaKRAmCTI+bu+W2GzhwBEdgWD0EN+sUOlEw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641586298; a=rsa-sha256; cv=none; b=CUAJVMiNiTrYDWdK7Nu1RACB42EX0plxlJrs1nVELUbw1FxIZpO5Nw4bYt+7ID856CGLMh Q8uhs8uJdBTlYu2Tbrl7PYELnLGBQLawNEQrg4SaDV4F3OVstZ/ge/bkoH3NWc5Oc2eGDZ iu+WQRNyviLpOFy5JlCGnAvTWWz8ioynF+u9WN0hiJc2TKGzbO5Cbob6VdJ6B68vej7xew jG6JugFedlXh+GylvUUp+p9bPYV8Dz3b6wIklpYRAYmZQqwaXjL/7tZwtVUWnIJ7MbxrAl omRoPRPx8nCd0oemx0IZ6yo+oCszD4ULZCrEDTP6Jytc7OZ9efY2deWoRXh91w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=pgfNz7oH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=pgfNz7oH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D5B0D28CB1 X-Spam-Score: -2.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: Hj3HAa79xsek Hi, Am Freitag, dem 07.01.2022 um 11:49 -0500 schrieb Timothy Sample: > Liliana Marie Prikler writes: > > 4. Regexps :) > > I doubt regex support will be broadly useful here.  Putting the > anchors in every package name (e.g., "^tap$") makes for a lot of > noise.  My (wild) guess would be that regexes will save us listing > two dependencies for one out of every ten Node packages.  Given that, > my preference would be to not bother with regex support. My reason to include them is that we can already see a number of packages requiring typescript(.*) for a number of (.*) -- similarly karma and mocha -- in the patch set given by Philip. I do think regexps will be less useful later on and could very well become obsolete by the time we have a full bootstrap of everything, but we don't have an ETA on that, so for now I'd like to have that capability. I see two potential solutions here. First is matching the whole string as you suggested and discussed below. Second is opting in to regexp in general (there are some ".js" things, that would otherwise require escaping). This would take the form of the user writing '("foo" "bar" (regexp "^baz$")) as UNWANTED, and it'd be interpreted as the predicates (equal? S "foo") ; alternatively string=? (equal? S "bar") (string-match S "^baz$") WDYT? > > I think it'd be beneficial if delete-dependencies could delete > > dependencies based on their name matching a regexp rather than a > > string exactly.  This would make some of your lists shorter > > (e.g. "karma.*"), but there might be a debate on whether to use > > "^karma.*$" or whether to only consider regexps that match the > > dependency fully. > > If nothing else, I’m certainly on the other side of this debate!  :) > If every string is going to be treated as a pattern, we should have > it match fully by default.  That is, the anchors should be implicit.  > For the very rare (never?) case where you want to avoid anything that > so much as has “foo” in the name, it’s pretty easy to write > ".*foo.*". Full string matches are my preference too, but I only found the function that does partial match. Is there an easier solution than checking whether the matched string equals the input to string-match? Cheers