From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yBr4AV4CNmHrLAAAgWs5BA (envelope-from ) for ; Mon, 06 Sep 2021 13:58:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UAWUOV0CNmHxFgAA1q6Kng (envelope-from ) for ; Mon, 06 Sep 2021 11:58:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 53590C84C for ; Mon, 6 Sep 2021 13:58:21 +0200 (CEST) Received: from localhost ([::1]:55292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNDGW-0005Tw-Dc for larch@yhetil.org; Mon, 06 Sep 2021 07:58:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNDGE-0005Ta-PR for guix-patches@gnu.org; Mon, 06 Sep 2021 07:58:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40690) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNDGE-0003I1-HK for guix-patches@gnu.org; Mon, 06 Sep 2021 07:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNDGE-00052S-GV for guix-patches@gnu.org; Mon, 06 Sep 2021 07:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50425] [PATCH] gnu: Add minetest-advtrains. Resent-From: Vivien Kraus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Sep 2021 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50425 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 50425@debbugs.gnu.org Received: via spool by 50425-submit@debbugs.gnu.org id=B50425.163092942219278 (code B ref 50425); Mon, 06 Sep 2021 11:58:02 +0000 Received: (at 50425) by debbugs.gnu.org; 6 Sep 2021 11:57:02 +0000 Received: from localhost ([127.0.0.1]:52235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNDFG-00050f-4V for submit@debbugs.gnu.org; Mon, 06 Sep 2021 07:57:02 -0400 Received: from planete-kraus.eu ([89.234.140.182]:47760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNDFE-00050M-EY for 50425@debbugs.gnu.org; Mon, 06 Sep 2021 07:57:01 -0400 Received: from planete-kraus.eu (localhost.lan [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id 95959bb0; Mon, 6 Sep 2021 11:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h= message-id:subject:from:to:date:in-reply-to:references :content-type:mime-version; s=*; bh=ptaXNzTiQq14yd6Y7qaslkqPmiM=; b= a4Fg6/QWAUzsT1kIcTUzAj7aXkWDCzJlgl+lxl88KXosIsbEwsI+Y5+ItiVwB4Ev tTX7RRW9uR1qpB2i+EsZ66imtIHIuKBQTUAojr6eVmt4G5mNiZdWfSmW63yYnScI NxcD6RSF0w+pImHpYcIcLVx1QnmkPfpgC4YAitok+W0= Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id 8a27dba3 (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Mon, 6 Sep 2021 11:56:55 +0000 (UTC) Message-ID: Date: Mon, 06 Sep 2021 13:56:54 +0200 In-Reply-To: <031b52f03cac2218f9250882e5b8d3fe56cc7f49.camel@telenet.be> References: <87a6kqm6f3.fsf@planete-kraus.eu> <031b52f03cac2218f9250882e5b8d3fe56cc7f49.camel@telenet.be> Content-Type: multipart/mixed; boundary="=-9Gud2feM1kF/CLCvfCJ9" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Vivien Kraus X-ACL-Warn: , Vivien Kraus via Guix-patches From: Vivien Kraus via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630929501; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=+qUye3u6kMf4flPWG/MfKKuPmnCWCtw6jaPEjZw504k=; b=b65oSiEq2UTmJAsRRvQr56+1W66ZRY0Cg0kAebHDlQFToww5pLxhIAMrzQmwL0NJWXk8ix SK+cDBA44i7Mn2j7eH3qyK8emjk37LZ5tO5eKeyqNa1ZFvxz2sN3QG+IRe+83cqj9DFWAL yt++hiXt8A8Jb/WK3dYe1bgLLXrJj28h3Cb0XGYY6dFha4bbbzXvcARrbGQBAZy5yMIDci BvkHVxx9IgzXDHj98Fammjk8BG2bjV1OUsfjN9tl/1A+Je9mo5Owv2rfJZACGbNZfW48U8 TvHS7fmqenbmk94CiYWowm5Xh/SXtO/rIalI6lkNe5Xu/NlJ+IWbLQagpWVttg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630929501; a=rsa-sha256; cv=none; b=TTSdkOZeXIeBycdRgVrJ92MYJlgUvgiz4NKUhtOlCyzGvgCTHDV8kVrontYe4lVjKJRaQT +UEvjPZDS7cwg9JuIX7x9xKNap8ZH766AciFeB4PgJH8bG4GXTbwpJxOSkZVtVrF/TrNUW v8cv7jw0HYC8/2BC/V7K5zNPNvAoehG1z0Tea5ydjkytpEVhlbLl7rb8eN17WN/ouYftQu +F4GZCrCjW5FLmPfYaLoppdcI6RDkXqAPDHjuPuGgIka49vvv5CrihcZ/LB4iudKHCr7Jy ui2miH7RZ2g4u47KvQ6HI4BD7kbocF1AOVIBHS9PTTXdYNZsNfGDMM5Eev535A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 53590C84C X-Spam-Score: -1.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: hoGIQ/ZrfGCH --=-9Gud2feM1kF/CLCvfCJ9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hello Maxime, Le lundi 06 septembre 2021 à 13:17 +0200, Maxime Devos a écrit : > Did the minetest importer work well for you? I noticed 3 minor things: 1. The advtrain dependency on basic-trains was duplicated, I had to remove one occurence; 2. The version number came prefixed with a "v" that I had to remove; 3. It was not able to get the commit ID and the hash for minetest- advtrains, I had to fill it in myself (it was set to #f). Presumably because of the exotic tag name. That’s not counting the markdown and license issues, these are out of scope indeed. > Package descriptions are in texinfo, not markdown. You'll need > to make the necessary adjustments. I updated the patch to account for an @itemize instead of dash enumerations, I think it was the only thing missing. > According to > http://git.bananach.space/basic_trains.git/tree/license.txt, > it's agpl3+ actually. You’re right, advtrains too: https://git.bananach.space/advtrains.git/tree/license.txt I updated the patch. Also, when I run ./etc/indent-code.el gnu/packages/minetest, there are some re-indentations that happen for othe minetest packages. Thus, I’m not sure what indentation and general style I should adopt. Hopefully this problem will be fixed by guix style :) Vivien --=-9Gud2feM1kF/CLCvfCJ9 Content-Disposition: attachment; filename="0001-gnu-add-minetest-advtrains.patch" Content-Type: text/x-patch; name="0001-gnu-add-minetest-advtrains.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAzNmIzMTcwMzY2MjA1ZTc2MWM1NzY2NWYxOWRiYTFhNTgxY2E5MDUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaXZpZW4gS3JhdXMgPHZpdmllbkBwbGFuZXRlLWtyYXVzLmV1 PgpEYXRlOiBTdW4sIDUgU2VwIDIwMjEgMTU6MjE6MzUgKzAyMDAKU3ViamVjdDogW1BBVENIXSBn bnU6IGFkZCBtaW5ldGVzdC1hZHZ0cmFpbnMKCiogZ251L3BhY2thZ2VzL21pbmV0ZXN0LnNjbSAo bWluZXRlc3QtYWR2dHJhaW5zKTogTmV3IHZhcmlhYmxlLgoqIGdudS9wYWNrYWdlcy9taW5ldGVz dC5zY20gKG1pbmV0ZXN0LWJhc2ljLXRyYWlucyk6IE5ldyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFj a2FnZXMvbWluZXRlc3Quc2NtIHwgNjggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNjggaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2du dS9wYWNrYWdlcy9taW5ldGVzdC5zY20gYi9nbnUvcGFja2FnZXMvbWluZXRlc3Quc2NtCmluZGV4 IDU0NTNmNGQxNmEuLjgwMTUxYjhkZTYgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9taW5ldGVz dC5zY20KKysrIGIvZ251L3BhY2thZ2VzL21pbmV0ZXN0LnNjbQpAQCAtNjI0LDMgKzYyNCw3MSBA QCB0cmFjayBvZiBpbXBvcnRhbnQgbG9jYXRpb25zLiIpCiAgICAgICAgICAgICAgICAgICAgbGlj ZW5zZTpjYy1ieTQuMCBsaWNlbnNlOmNjLWJ5LXNhMy4wIGxpY2Vuc2U6cHVibGljLWRvbWFpbgog ICAgICAgICAgICAgICAgICAgIGxpY2Vuc2U6Y2MwIGxpY2Vuc2U6ZmRsMS4yKykpCiAgICAgKHBy b3BlcnRpZXMgYCgodXBzdHJlYW0tbmFtZSAuICJSZWFsQmFkQW5nZWwvdW5pZmllZF9pbnZlbnRv cnkiKSkpKSkKKworKGRlZmluZS1wdWJsaWMgbWluZXRlc3QtYWR2dHJhaW5zCisgIChwYWNrYWdl CisgICAgKG5hbWUgIm1pbmV0ZXN0LWFkdnRyYWlucyIpCisgICAgKHZlcnNpb24gIjIuMy4xIikK KyAgICAoc291cmNlCisgICAgIChvcmlnaW4KKyAgICAgICAobWV0aG9kIGdpdC1mZXRjaCkKKyAg ICAgICAodXJpIChnaXQtcmVmZXJlbmNlCisgICAgICAgICAgICAgKHVybCAiaHR0cHM6Ly9naXQu YmFuYW5hY2guc3BhY2UvYWR2dHJhaW5zLmdpdCIpCisgICAgICAgICAgICAgKGNvbW1pdCAicmVs ZWFzZS0yLjMuMSIpKSkKKyAgICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIgIjFpanFsY2ho MjY5anB2bWdtZG1kdnkzbnNuazBic3prdnZjcWs2dmF5c3Z4YW02OTVnZ3ciKSkKKyAgICAgICAo ZmlsZS1uYW1lIChnaXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpKSkKKyAgICAoYnVpbGQtc3lz dGVtIG1pbmV0ZXN0LW1vZC1idWlsZC1zeXN0ZW0pCisgICAgKGhvbWUtcGFnZSAiaHR0cDovL2Fk dnRyYWlucy5kZS8iKQorICAgIChzeW5vcHNpcworICAgICAiQWRkcyBnb29kLWxvb2tpbmcsIHJl YWxpc3RpYyB0cmFpbnMgd2l0aCByZWFsaXN0aWMgcmFpbHMuIikKKyAgICAoZGVzY3JpcHRpb24K KyAgICAgIlRoaXMgbW9kIGZlYXR1cmVzIHJlYWxpc3RpYyB0cmFpbnMgYW5kIHZhcmlvdXMgZXF1 aXBtZW50IGZvciByYWlsd2F5cywgd2l0aCBhIGZvY3VzIG9uIGF1dG9tYXRlZCB0cmFpbiBvcGVy YXRpb24uCisKK01haW4gZmVhdHVyZXM6CisKK0BpdGVtaXplCitAaXRlbQorYWxtb3N0LXJlYWxp c3RpYyB0cmFja3Mgd2l0aCBhY3R1YWwgY3VydmVzIGFuZCBzd2l0Y2hlczsKK0BpdGVtCityYWls d2F5IHNpZ25hbHMsIGNvbnRyb2xsYWJsZSBieSB2YXJpb3VzIG1lYW5zOworQGl0ZW0KK0FUQzog c2ltcGxlLCBjb21tYW5kLWxpa2UgYXV0b21hdGljIHRyYWluIGNvbnRyb2w7CitAaXRlbQorTHVh QVRDOiBQb3dlcmZ1bCBMdWEtc2NyaXB0ZWQgYXV0b21hdGljIHRyYWluIG9wZXJhdGlvbiAocmVx dWlyZXMgc29tZSBwcm9ncmFtbWluZyBrbm93bGVkZ2UpOworQGl0ZW0KK2FuIGludGVybG9ja2lu ZyBzeXN0ZW0sIGZlYXR1cmluZyB0cmFjayBzZWN0aW9ucywgcm91dGVzIGFuZCBhdXRvbWF0aWMg c3RvcHBpbmcgYmVmb3JlIHNpZ25hbHMuCitAZW5kIGl0ZW1pemUiKQorICAgIChsaWNlbnNlCisg ICAgIChsaXN0IGxpY2Vuc2U6Y2MtYnktc2EzLjAgbGljZW5zZTphZ3BsMyspKQorICAgIChwcm9w ZXJ0aWVzCisgICAgIGAoKHVwc3RyZWFtLW5hbWUgLiAib3J3ZWxsL2FkdnRyYWlucyIpKSkpKQor CisoZGVmaW5lLXB1YmxpYyBtaW5ldGVzdC1iYXNpYy10cmFpbnMKKyAgKHBhY2thZ2UKKyAgICAo bmFtZSAibWluZXRlc3QtYmFzaWMtdHJhaW5zIikKKyAgICAodmVyc2lvbiAiMS4wLjEiKQorICAg IChzb3VyY2UKKyAgICAgKG9yaWdpbgorICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAgICAg ICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAgICAodXJsICJodHRwOi8vZ2l0LmJhbmFu YWNoLnNwYWNlL2Jhc2ljX3RyYWlucy5naXQvIikKKyAgICAgICAgICAgICAoY29tbWl0CisgICAg ICAgICAgICAgICJkNDRjNDEwZjdjMmE3MjAyZWU2OGI2NmZjNTBmZWJhZTg5ZTBjNWRjIikpKQor ICAgICAgIChzaGEyNTYKKyAgICAgICAgKGJhc2UzMgorICAgICAgICAgIjB2dnpuZGo0OGtnZHoy YmZnaXZmbTIxN3NibWMybG14cHAybWlzcGN5N2J5bjRpMjZwcngiKSkKKyAgICAgICAoZmlsZS1u YW1lIChnaXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIG1p bmV0ZXN0LW1vZC1idWlsZC1zeXN0ZW0pCisgICAgKHByb3BhZ2F0ZWQtaW5wdXRzCisgICAgIGAo KCJtaW5ldGVzdC1hZHZ0cmFpbnMiICxtaW5ldGVzdC1hZHZ0cmFpbnMpKSkKKyAgICAoaG9tZS1w YWdlCisgICAgICJodHRwOi8vYWR2dHJhaW5zLmRlL3dpa2kvZG9rdS5waHA/aWQ9dXNhZ2U6dHJh aW5zOmJhc2ljX3RyYWlucyIpCisgICAgKHN5bm9wc2lzCisgICAgICJDb2xsZWN0aW9uIG9mIGJh c2ljIHRyYWlucyBmb3IgdGhlIEFkdmFuY2VkIFRyYWlucyBtb2QuIEZvcm1lcmx5IGluY2x1ZGVk IGluIG1haW4gYWR2dHJhaW5zIG1vZHBhY2sgKHVudGlsIDIuMy4wKSIpCisgICAgKGRlc2NyaXB0 aW9uCisgICAgICJUaGlzIG1vZHBhY2sgY29udGFpbnMgdGhlIHRyYWlucyB3aGljaCB3ZXJlIHRo ZSBcImRlZmF1bHRcIiB0cmFpbnMgaW4gYWR2dHJhaW5zIHVwIHRvIHZlcnNpb24gMi4yLjEuIikK KyAgICAobGljZW5zZQorICAgICAobGlzdCBsaWNlbnNlOmNjLWJ5LXNhMy4wIGxpY2Vuc2U6YWdw bDMrKSkKKyAgICAocHJvcGVydGllcworICAgICBgKCh1cHN0cmVhbS1uYW1lIC4gIm9yd2VsbC9i YXNpY190cmFpbnMiKSkpKSkKLS0gCjIuMzMuMAoK --=-9Gud2feM1kF/CLCvfCJ9--