unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ekaitz Zarraga <ekaitz@elenq.tech>
To: Erik Eduardo <eduarskate8@gmail.com>, 68742@debbugs.gnu.org
Cc: Erik Eduardo <erikeah@protonmail.com>
Subject: [bug#68742] [PATCH] gnu: river: add river.desktop on wayland-sessions
Date: Mon, 29 Jan 2024 17:41:07 +0100	[thread overview]
Message-ID: <b3b2ad21-3927-97f7-d867-5054916213e4@elenq.tech> (raw)
In-Reply-To: <f2f2742f98cc9d7b54c371b5c7221d93ef0dcdf2.1706288949.git.eduarskate8@gmail.com>

Hi

On 2024-01-26 18:09, Erik Eduardo wrote:
> From: Erik Eduardo <erikeah@protonmail.com>
> 
> This patch will allow to login from login managers or display managers
> to River.
> 
> Changes:
> 
>    - Creates a directory at share named wayland-sessions
>    - Install a desktop file from repo inside share/wayland-sessions
> 
> This is my first patch, please be patient and give me feedback, I will
> do my best.
> 
> Change-Id: Iea8999cf97bedc8fb7ede4dd22b8f0f9529d2fa1
> ---
>   gnu/packages/zig-xyz.scm | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/zig-xyz.scm b/gnu/packages/zig-xyz.scm
> index 200b5c9940..ca73c6bad8 100644
> --- a/gnu/packages/zig-xyz.scm
> +++ b/gnu/packages/zig-xyz.scm
> @@ -52,7 +52,16 @@ (define-public river
>       (build-system zig-build-system)
>       (arguments
>        (list
> -      #:zig-build-flags #~(list "-Dxwayland")   ;experimental xwayland support
> +      #:phases #~(modify-phases %standard-phases
> +                   (add-after 'install 'install-extra-files
> +                     (lambda* (#:key outputs #:allow-other-keys)
> +                       (let* ((out (assoc-ref outputs "out"))
> +                              (wayland-sessions (string-append out
> +                                                 "/share/wayland-sessions")))
> +                         (mkdir-p wayland-sessions)
> +                         (install-file "contrib/river.desktop"
> +                                       wayland-sessions)))))
> +      #:zig-build-flags #~(list "-Dxwayland") ;experimental xwayland support
>         #:zig-release-type "safe"))
>       (native-inputs (list libevdev
>                            libxkbcommon
> 
> base-commit: 2266754382bce43789976aec65181cb5085c8bc4


Looks good to me, but guix commits follow changelog format:

https://www.gnu.org/prep/standards/standards.html#Change-Logs

The rest of it looks ok. Please resend with the message fixed and I'll 
take a further look.

Thanks a lot for contributing to Guix.

Ekaitz




  reply	other threads:[~2024-01-29 16:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26 17:09 [bug#68742] [PATCH] gnu: river: add river.desktop on wayland-sessions Erik Eduardo
2024-01-29 16:41 ` Ekaitz Zarraga [this message]
2024-01-31  8:32 ` [bug#68742] [PATCH] gnu: river: Add river.desktop file Erik Eduardo
2024-02-08 17:32 ` [bug#68742] [PATCH v3] " Erik Eduardo
2024-02-08 19:08   ` Ekaitz Zarraga
2024-02-09 14:13   ` Ekaitz Zarraga
2024-02-14 12:19 ` [bug#68742] [PATCH v4] " Erik Eduardo
2024-02-14 12:31 ` [bug#68742] QA review for 68742 Ekaitz Zarraga
2024-02-14 13:33   ` Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3b2ad21-3927-97f7-d867-5054916213e4@elenq.tech \
    --to=ekaitz@elenq.tech \
    --cc=68742@debbugs.gnu.org \
    --cc=eduarskate8@gmail.com \
    --cc=erikeah@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).