From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8JwNKexiNmKBNwEAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 00:10:36 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gMDFIexiNmLneAEAG6o9tA (envelope-from ) for ; Sun, 20 Mar 2022 00:10:36 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 197092907A for ; Sun, 20 Mar 2022 00:10:36 +0100 (CET) Received: from localhost ([::1]:50390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nViDS-00039x-Fs for larch@yhetil.org; Sat, 19 Mar 2022 19:10:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nViDB-00039p-Rh for guix-patches@gnu.org; Sat, 19 Mar 2022 19:10:18 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nViCw-0005Kp-NH for guix-patches@gnu.org; Sat, 19 Mar 2022 19:10:11 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nViCw-0007n4-EF for guix-patches@gnu.org; Sat, 19 Mar 2022 19:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54309] What is the process from here? Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Mar 2022 23:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54309 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , fesoj000 , 54309@debbugs.gnu.org Received: via spool by 54309-submit@debbugs.gnu.org id=B54309.164773140029935 (code B ref 54309); Sat, 19 Mar 2022 23:10:02 +0000 Received: (at 54309) by debbugs.gnu.org; 19 Mar 2022 23:10:00 +0000 Received: from localhost ([127.0.0.1]:60763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nViCu-0007mk-7m for submit@debbugs.gnu.org; Sat, 19 Mar 2022 19:10:00 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:47304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nViCt-0007mc-1b for 54309@debbugs.gnu.org; Sat, 19 Mar 2022 19:09:59 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id 8P9x270014UW6Th06P9xSt; Sun, 20 Mar 2022 00:09:57 +0100 Message-ID: From: Maxime Devos Date: Sun, 20 Mar 2022 00:09:52 +0100 In-Reply-To: <87f117ba35bb40fe063d5cd0bee61039a5f9801e.camel@gmail.com> References: <8640c4e7b1a46e76ea4df8c21a290d1aa72de0d8.camel@gmail.com> <87f117ba35bb40fe063d5cd0bee61039a5f9801e.camel@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-MHSacWW1g2LrBd85pOoy" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647731397; bh=R9VCfjLGJtZ9INN7xqE5s07ejZLIBmzlyh3QUrlhalU=; h=Subject:From:To:Date:In-Reply-To:References; b=AJUjbGIVaa7nwFUmmcacpT+jpfhYm1w/tCXU3ehz2yHV7JM1Mk9r9SY6/yPpQwMtE /BiIGQF3j/BTF8Uk9bIVRWLRv0PEsOpkREwaiVLjSv+p068d01C8y7TvsjJlZ9dqrH 4FFGYimtyOKO9AM+HnD74JVZUv0ljxVLSPXtTusNtTnRf65TiHn6f1VcyrNETX/ZY6 EACI5lbV1uGJR+fUp737hHskiAOv8u89cEbeHlvx7W1QWobedd2qQQ7uePEvXGQlWv SR7slUCmbJuyOFSE47m+JKXGh8EpXKZ9li2fb8VEKVj77qY3IQCMPVPR43dxA1h2gG 1nFIwxNXAlgJw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647731436; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=R9VCfjLGJtZ9INN7xqE5s07ejZLIBmzlyh3QUrlhalU=; b=UjNyVgt+ftc8+2RlJy7eadU8/dhTpQ/MawPQo8EiuRtNfr7oe2n/wUc4VgpVfUtBwXTykb LEzBHR/wKkFL6oN8VcmdVwfzOB/3Ft8lqHHXoAebNYTsFYBD7hef561qTWw2B1Lum0/I/I o2WdavbIq4fTs5ZldeWczpaXzaAaL7dEfblNQvivDFTT2mIHRZTc7ZlVc3aTyRfLRKQBY0 qhc+zpNdKKAwLeXov9hO3qLkRe9der8w+DbN+PjQhV9csmdCnGqTv4ciJ9y0lQq574irDZ bFOyEuv806mkq4FmBHwb6eKKzbV1JEdQUtXRjHHTVIDl5Hncd9DECGI/DzTWyA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647731436; a=rsa-sha256; cv=none; b=R31f+5zP7lYHxqiYejaWGmGytj73OxVsO+aTjz9YwRD9W/pecVYYSqTvBhayOA0tRfvZKp bT+gyu/UgJzB+AbdOzrv2cz/Xt2PF8LNTOl+JAm51uF9rdc9tpSGqasAZ4bZI7qIoaHYAv hVbL/65atzE8cofSMfHLQIfWb+4t4rYxBXLEOy9mNxXlrV0Poc/3NhDFbHxeDv3rFkq3NG GHxVMhbqor1OVne5nXJOpNbsamLfmS/JiZf+OEtAEEYDENCCqz97SY3BnBzMZ5q+EGMJ2s RFD9KduG+RMEJzYooeaO2R4PkEjoZoYLJcT7FOOQIV7h8Y6wLrrHQfyJ0+CJqQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=AJUjbGIV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.87 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=AJUjbGIV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 197092907A X-Spam-Score: 3.87 X-Migadu-Scanner: scn0.migadu.com X-TUID: ENNYuvl4XpY0 --=-MHSacWW1g2LrBd85pOoy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Liliana Marie Prikler schreef op vr 18-03-2022 om 23:36 [+0100]: > > +(define (auditd-activation config) > > +=C2=A0 (with-imported-modules '((guix build utils)) > > +=C2=A0=C2=A0=C2=A0 #~(begin > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (use-modules (guix build ut= ils)) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (let ((var-log-audit "/var/= log/audit")) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (umask #o077) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (mkdir-p var-lo= g-audit))))) > > + > This would also apply umask 077 to /var and /var/log if those don't > already exist.=C2=A0 More importantly, code executed after that will also > inherit the umask, which I don't think is the intended consequence. More concretely, the procedure 'mkdir-p/perms' would address the umask issue, but not the potential =E2=80=98oops too restrictive permissions for = /var and /var/log' issue. Additionally, as var-log-audit is only used in a single place, you could simplify to #~(begin (use-modules ...) (mkdir-p/perms "/var/log/audit")) here. Greetings, Maxime. --=-MHSacWW1g2LrBd85pOoy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjZiwBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7k/wAQDRUa/PJU/p21gJrWCwCH6z4246 mkZ6BrAZUGXGBD/l7gD+NEdmv7dn7d82v7++/g3aTi1dZWlAdZFZr8Eg4cRDYg0= =d/f5 -----END PGP SIGNATURE----- --=-MHSacWW1g2LrBd85pOoy--