From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iKojMb1ttmEuVQAAgWs5BA (envelope-from ) for ; Sun, 12 Dec 2021 22:46:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OPb5LL1ttmHBcwAA1q6Kng (envelope-from ) for ; Sun, 12 Dec 2021 21:46:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7353924CF5 for ; Sun, 12 Dec 2021 22:46:37 +0100 (CET) Received: from localhost ([::1]:35826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwWg0-0003rG-Mb for larch@yhetil.org; Sun, 12 Dec 2021 16:46:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwWfT-0003pz-AZ for guix-patches@gnu.org; Sun, 12 Dec 2021 16:46:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwWfS-0004xo-0S for guix-patches@gnu.org; Sun, 12 Dec 2021 16:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwWfR-0004Uh-Nr for guix-patches@gnu.org; Sun, 12 Dec 2021 16:46:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v3 00/43] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Dec 2021 21:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 51838@debbugs.gnu.org, Timothy Sample , Jelle Licht , Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163934554817256 (code B ref 51838); Sun, 12 Dec 2021 21:46:01 +0000 Received: (at 51838) by debbugs.gnu.org; 12 Dec 2021 21:45:48 +0000 Received: from localhost ([127.0.0.1]:53358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwWfE-0004UG-LW for submit@debbugs.gnu.org; Sun, 12 Dec 2021 16:45:48 -0500 Received: from mail-vk1-f172.google.com ([209.85.221.172]:41932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwWfD-0004U4-T5 for 51838@debbugs.gnu.org; Sun, 12 Dec 2021 16:45:48 -0500 Received: by mail-vk1-f172.google.com with SMTP id 188so9276894vku.8 for <51838@debbugs.gnu.org>; Sun, 12 Dec 2021 13:45:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=agJkUz+kyVg872xovENixtzvHGZ58+6S4GJznL9EkPU=; b=FmihIQm8ui2bRSExyFHCzeHySOSYUIIDlnty4IVrIlz6UWXgYVVhEByRK7Sm5QQotb E3ChXxodeF0xRza1+90Mybgv+qB5AD7Z6UvZgAtLcrHRUIxFxgfMyfvvaZsQPDLCs43k hD1Tdhuo6OxmvLRd9AHI7fd0rxoFmNACRMsSYg8bhLQhk7yuxbPKtB5Dc/7gb7dUeCLb 5Rr1HR6fMscamKtqu8x23ua1E0SbzEdiMPo9O8+eZo6vVyLgG1AxiIP9oW5cv0ID7OHZ rTM7WouX6sLrd9MoCu++wVOtNU07eBO5SnO0q0ICRvtnYo2MABd4Z5VBOLUlM8lkpBAD FbJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=agJkUz+kyVg872xovENixtzvHGZ58+6S4GJznL9EkPU=; b=iTnChJBMtC46MN3wV29kvMF3fSro5CHIAtw0PMlXQZ7Q08jqea/BvSYOmp8+2N5H2k b7k8Eq1PfHz34Ej7BtuHnfVmYW7ANCVv5STlIRbR8DOGZw/z90b9z/hlwWcK1G1YNlsQ i5qcyaxIwV4Rt24Z20RoWhmFWs5D+DExVA/dlmzTQPRLMFeUKz5TswMTyz6aEKdRcJdP k/eu6aLMwdOTRHMWP5kLgUo61aYplUBpMhdBr5ORE9RlKrHuvfsr/HG5L3dNgSFD9aJF h7E3Mz6wsHZEBsxjgt523sXUkWUju1yNXIZkEYeIHRy0tZ56B4e9QisUAkGRzzPD/pDt OrFg== X-Gm-Message-State: AOAM530lKHlAfK/KMVc2fFgZJp5A2U9c+LlqYYK+u5gN2tMdEjMZF2ZO pmRDES0mAmyZ8XugjOJuXce7bA== X-Google-Smtp-Source: ABdhPJzJiNsfU3XUQEsf+ar5rv+GxcEI4CcieLF6ie+Osqjw7a92I5+omDxCIR7m05kyIK5QHbFP1A== X-Received: by 2002:a05:6122:997:: with SMTP id g23mr28736850vkd.15.1639345542282; Sun, 12 Dec 2021 13:45:42 -0800 (PST) Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id z188sm3392292vsz.12.2021.12.12.13.45.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 13:45:42 -0800 (PST) Message-ID: Date: Sun, 12 Dec 2021 16:45:41 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US References: <46a042bc08eb72a068b1e8c69bfe28cf2d4b2e53.camel@gmail.com> <20211208202838.752542-1-philip@philipmcgrath.com> <87ee6h24it.fsf@gmx.com> <87r1ahvkoa.fsf@gmx.com> From: Philip McGrath In-Reply-To: <87r1ahvkoa.fsf@gmx.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639345597; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=agJkUz+kyVg872xovENixtzvHGZ58+6S4GJznL9EkPU=; b=Rgy5h0Lpe8IA7hRUcvP53aWvOvDtsQlJv5zyHURGzxuJLi2Yb35BlYBjWvVVn/eDGULPaR jljPHI5UFpZ8cmMKmATmbpJ/r4V8Ctsmy9PCPZ4iPynG/7yh62SC4/s1gp3/1ggON1JrAu Cu3ADstQZqttyqPeJQU6+/bcCq2WkS1oQjuNLTBd43Qp5UpGnRLZsn88aGfHlEotAyTtqp qbJlfJvZMrDYOMEQ0ieZdhXTIAsnFKyO4k+iPNPoMPj2oWSsONN+JA0mZ9ZyZV0HHFWNJY PpesKtsknvpf3L8KmM5RSZppCdp8xjFuvJsPtKXJkNs/GTmw1hOtd/FMh/LrHw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639345597; a=rsa-sha256; cv=none; b=UD3K8z6dSDZXvKFejHPwKuB9hc48ozL02/vB09qL4e2TVSGFqX/sfPx0nSctdVgXG9U10Q jvPrNJl5G54PSS2YB9flMtjLZTlkYAQ2hWGGRNyTsF+fcdvZLhnhXpL1SR7udFe5o2QDdf i8GkouDNP1t4LcBR98GshgWkb9WMkX3fqElXenZuWpjOFXHb5sx3Bn/MpcRbPYD7mztQSM pL334tl7SEuOgG/LmKxu8XyVji9bVBJ1xyl3kEd+aK0liH9Lr+g/pVZ5T8zoM2MydrfRHW 4OgIVeY8u0Jl4e9bthn9NEQp6g6GmWI6z/ug3vYBNse+svdrY8rT7e+Vml880A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=FmihIQm8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.47 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=FmihIQm8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7353924CF5 X-Spam-Score: -0.47 X-Migadu-Scanner: scn1.migadu.com X-TUID: l4muNszhAB3y Hi! On 12/12/21 11:36, Pierre Langlois wrote: > > Pierre Langlois writes: >> Thanks for working on this! I've tested the series and rebased my own >> work on top locally, it's working for me so feel free to add: >> >> Tested-by: Pierre Langlois >> >> The series looks good to me overall, I'll add comments in each patch. > > OK, I'm done with my round of comments :-) > > I'm not a maintainer but I do have commit access, so I can volonteer to > push this on your behalf if maintainers are happy with the series. > Hopefully with some of my suggestions incorporated if you agree with > them. Thanks for the review! I'll send a v4 incorporating your comments, probably later today or tomorrow, and hopefully that will be ready to merge. It will also include node-debug, because I discovered that the lack of it causes some problems for the node-serialport packages, and it turned out not to be too difficult to add. -Philip