From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 4I0yNzbuNmV9FgEA9RJhRA:P1 (envelope-from ) for ; Tue, 24 Oct 2023 00:05:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4I0yNzbuNmV9FgEA9RJhRA (envelope-from ) for ; Tue, 24 Oct 2023 00:05:42 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A45E33C0B6 for ; Tue, 24 Oct 2023 00:05:42 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=autistici.org header.s=stigmate header.b=G88uRFn8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698098742; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=gBS/sNGx5LVN1rdv54ph3xy4XrOuUwX5xwlULJKwoI8=; b=qMxfZqbYZ4LbPweuA+V2dKW6yuLSriDVmmaTFu/kPPL5kFvIkSTvahxa6YWZaVDNXrAieN ssZcc7HkAnpInz74c2y9PgJRMiENzSL+jTzNfTAOtvDIlhWXLOApb4AZP95mgBzrEWPV7n kFQU4JotYYEbs3xr61eEMO/Q6SjfUiUPW2LnEuT9Fj/4+f7nnauOgBcqgnIC/Cqv/Ibyg/ B90soNIXJmags93i5jINzDAfWFUNNnKMHLNGSrdBKA4okTLG9mmhwD4NWcfBpmYD7Nl2KL Ca4DeGiI7Q3z/8e4X+oc3BzSmxmmX162hcl11Lk3Vq6MzF9cScrFc8lxC6r3pg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=autistici.org header.s=stigmate header.b=G88uRFn8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698098742; a=rsa-sha256; cv=none; b=lTcwhTgFeFPObjbXQ48JHDY0CQ/DBD+/y1+pbG2pKZmQ8xNIqjipQ1xqkHgIZHKkBdnTOd PiXe0PLVg/ZovstpgAcQg1Y/6BxhobD4w9uiG/gH8PvPFr7L4UH8530F5kb5AO9TQBWxN7 icaZoq6ddgA+URe8b6AKAOx9ZZ2zDh1MACNGBBu/6+SmHagIFthALMUvpuMd7JlC7ICPvi gk+84/RkP/qO1+JN3YGUzcCtV8sEzpowrqRWypyyWhuzit3Bcw+S69xYgZzL1gzD4EaG2I UxU/CacQr0AS2rXoMgHc9c2EMaING8FjpOHcjIwJOPkWzua7KUDvUxdCTeuf3A== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qv33H-0005oh-4u; Mon, 23 Oct 2023 18:05:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qv33E-0005oW-VD for guix-patches@gnu.org; Mon, 23 Oct 2023 18:05:33 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qv33E-0000vJ-MT for guix-patches@gnu.org; Mon, 23 Oct 2023 18:05:32 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qv33h-0000DK-M5 for guix-patches@gnu.org; Mon, 23 Oct 2023 18:06:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66396] [PATCH] guix: Add case to Github url updater. Resent-From: paul Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Oct 2023 22:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66396 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 66396@debbugs.gnu.org Received: via spool by 66396-submit@debbugs.gnu.org id=B66396.1698098739782 (code B ref 66396); Mon, 23 Oct 2023 22:06:01 +0000 Received: (at 66396) by debbugs.gnu.org; 23 Oct 2023 22:05:39 +0000 Received: from localhost ([127.0.0.1]:52119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qv33L-0000CY-2q for submit@debbugs.gnu.org; Mon, 23 Oct 2023 18:05:39 -0400 Received: from confino.investici.org ([93.190.126.19]:58001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qv33H-0000CO-T0 for 66396@debbugs.gnu.org; Mon, 23 Oct 2023 18:05:38 -0400 Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4SDq4K01nqz110G; Mon, 23 Oct 2023 22:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1698098705; bh=gBS/sNGx5LVN1rdv54ph3xy4XrOuUwX5xwlULJKwoI8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=G88uRFn8efAv8mfq1Zie/EyHvyCyF9/sE5O2vso9SJIW6H4wru6+TvSB8J67l4dbz 6WzWvt6r+Xhcd9LS9sPV7MDSF+hTbQuC2c1oWSuyDOnM/Ym+7d7iTYjtCMoN0BfmbW OK+UzKnvhvIOIXmWjigHd+3+758JKyA/VObdWD3I= Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19]) (Authenticated sender: goodoldpaul@autistici.org) by localhost (Postfix) with ESMTPSA id 4SDq4J6ZwDz1103; Mon, 23 Oct 2023 22:05:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------UbRjEB6L4NYZid2MbzOviZDu" Message-ID: Date: Tue, 24 Oct 2023 00:05:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 References: <1ed23c30a7592facd1db4c28c0f3cfb908157d9e.1696707911.git.goodoldpaul@autistici.org> <87y1ftc8bu.fsf@gnu.org> Content-Language: en-US In-Reply-To: <87y1ftc8bu.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: paul X-ACL-Warn: , paul via Guix-patches From: paul via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.60 X-Spam-Score: -6.60 X-Migadu-Queue-Id: A45E33C0B6 X-Migadu-Scanner: mx2.migadu.com X-TUID: nA/jHL5J1nYn This is a multi-part message in MIME format. --------------UbRjEB6L4NYZid2MbzOviZDu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Ludo’ , On 10/23/23 23:55, Ludovic Courtès wrote: >> + ((string-match (string-append "/releases/download/(v)?" version "/" >> + name ".*" ext "$") >> + url) >> + (string-replace-substring url version new-version)) > Is it not already covered by one of the other cases? Do you have an > example URL matched by this new clause? Yes, this patch fixes some failings I got from urls such as: |https://github.com/derailed/k9s/releases/download/v||0.27.4||/k9s_Linux_amd64.tar.gz| |https://github.com/metal3d/katenary/releases/download/||2.0.0-beta2||/katenary-linux-amd64| |https://github.com/kubernetes/kompose/releases/download/v||1.30.0||/kompose-linux-amd64| Thank you for your time, giacomo --------------UbRjEB6L4NYZid2MbzOviZDu Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Ludo’ ,

On 10/23/23 23:55, Ludovic Courtès wrote: 
+           ((string-match (string-append "/releases/download/(v)?" version "/"
+                                         name ".*" ext "$")
+                          url)
+            (string-replace-substring url version new-version))

Is it not already covered by one of the other cases?  Do you have an
example URL matched by this new clause?
Yes, this patch fixes some failings I got from urls such as:

https://github.com/derailed/k9s/releases/download/v0.27.4/k9s_Linux_amd64.tar.gz

https://github.com/metal3d/katenary/releases/download/2.0.0-beta2/katenary-linux-amd64

https://github.com/kubernetes/kompose/releases/download/v1.30.0/kompose-linux-amd64


Thank you for your time,


giacomo

--------------UbRjEB6L4NYZid2MbzOviZDu--