unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: rg@raghavgururajan.name, 67582-done@debbugs.gnu.org
Subject: bug#67582: [PATCH gnome-team 2/4] gnu: Add python-dbus-python.
Date: Tue, 19 Dec 2023 23:54:39 +0100	[thread overview]
Message-ID: <b1628e4035167bbe31baacec71aa3dad9a4c9de8.camel@gmail.com> (raw)
In-Reply-To: <875y1fyula.fsf@gmail.com>

Am Sonntag, dem 03.12.2023 um 14:06 -0500 schrieb Maxim Cournoyer:
> Hi,
> 
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> 
> > Am Sonntag, dem 03.12.2023 um 12:19 -0500 schrieb Maxim Cournoyer:
> > > Hello,
> > > 
> > > Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> > > 
> > > > * gnu/packages/python-xyz.scm (python-dbus-python): New
> > > > variable.
> > > 
> > > [...]
> > > 
> > > > +(define-public python-dbus-python
> > > > +  (package
> > > > +  (name "python-dbus-python")
> > > > +  (version "1.3.2")
> > > > +  (source
> > > > +   (origin
> > > > +     (method url-fetch)
> > > > +     (uri (pypi-uri "dbus-python" version))
> > > > +     (sha256
> > > > +      (base32
> > > > "1y28h90v2ib8zqhs3r2yr7ycg8ccwvw3gqkvadlm12v1129q2rxd"))))
> > > > +  (build-system pyproject-build-system)
> > > > +  (arguments
> > > > +   (list #:phases #~(modify-phases %standard-phases
> > > > +                      (add-after 'unpack 'patch-requirements
> > > > +                        (lambda _
> > > > +                          (substitute* (list "pyproject.toml"
> > > > "setup.py")
> > > > +                            (("'(ninja|patchelf)',?") ""))
> > > > +                          (substitute* "setup.cfg"
> > > > +                            (("(ninja|patchelf)") "")))))))
> > > > +  (inputs (list dbus glib))
> > > > +  (propagated-inputs (list python-pygobject))
> > > > +  (native-inputs (list pkg-config
> > > > +                       python-meson-python
> > > > +                       meson ninja patchelf
> > > > +                       python-sphinx python-sphinx-rtd-theme
> > > > +                       python-tappy
> > > > +                       python-wheel))
> > > 
> > > Is this 'guix style' produced?  The convention is to use:
> > > 
> > > (native-inputs
> > >  (list one
> > >        two
> > >        ...))
> > > 
> > > When there are more than 5 inputs (or if they don't fit on a
> > > single line).
> > I manually grouped them by theme.
> 
> I see.  I'd still prefer the conventional sorted flat list, because
> the next person touching it probably won't notice and break that
> logic.
We can still break it when the next person touches it, so that's fine
by me :)

Pushed, along with the rest.

  reply	other threads:[~2023-12-19 22:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-02 10:35 [bug#67582] [PATCH gnome-team 0/4] Update python-dbusmock Liliana Marie Prikler
2023-12-01 20:48 ` [bug#67582] [PATCH gnome-team 4/4] Revert "gnu: sysprof: Do not propagate libadwaita." Liliana Marie Prikler
2023-12-01 23:09 ` [bug#67582] [PATCH gnome-team 2/4] gnu: Add python-dbus-python Liliana Marie Prikler
2023-12-03 17:19   ` Maxim Cournoyer
2023-12-03 18:41     ` Liliana Marie Prikler
2023-12-03 19:06       ` Maxim Cournoyer
2023-12-19 22:54         ` Liliana Marie Prikler [this message]
2023-12-01 23:09 ` [bug#67582] [PATCH gnome-team 3/4] gnu: python-dbusmock: Update to 0.30.0 Liliana Marie Prikler
2023-12-01 23:38 ` [bug#67582] [PATCH gnome-team 1/4] gnu: Add python-meson-python Liliana Marie Prikler
2023-12-03 17:16   ` Maxim Cournoyer
2023-12-03 18:41     ` Liliana Marie Prikler
2023-12-03 19:04       ` Maxim Cournoyer
2023-12-02 14:18 ` [bug#67582] [PATCH gnome-team 0/4] Update python-dbusmock Vivien Kraus via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1628e4035167bbe31baacec71aa3dad9a4c9de8.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=67582-done@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).