From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WLdRAx++v15kWQAA0tVLHw (envelope-from ) for ; Sat, 16 May 2020 10:19:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id X965Oh6+v15CIgAAB5/wlQ (envelope-from ) for ; Sat, 16 May 2020 10:19:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2781B940369 for ; Sat, 16 May 2020 10:19:09 +0000 (UTC) Received: from localhost ([::1]:60940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZtuO-0005IM-0i for larch@yhetil.org; Sat, 16 May 2020 06:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZtuJ-0005Gd-IA for guix-patches@gnu.org; Sat, 16 May 2020 06:19:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56498) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZtuJ-0004Py-9H for guix-patches@gnu.org; Sat, 16 May 2020 06:19:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZtuI-00062P-4T for guix-patches@gnu.org; Sat, 16 May 2020 06:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41294] [PATCH] gnu: Add libfreenect. Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 May 2020 10:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41294 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "iyzsong@member.fsf.org" Cc: "41294@debbugs.gnu.org" <41294@debbugs.gnu.org> Received: via spool by 41294-submit@debbugs.gnu.org id=B41294.158962432523187 (code B ref 41294); Sat, 16 May 2020 10:19:02 +0000 Received: (at 41294) by debbugs.gnu.org; 16 May 2020 10:18:45 +0000 Received: from localhost ([127.0.0.1]:39811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZtu1-00061u-Hv for submit@debbugs.gnu.org; Sat, 16 May 2020 06:18:45 -0400 Received: from mail2.protonmail.ch ([185.70.40.22]:64805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZttz-00061g-Hi for 41294@debbugs.gnu.org; Sat, 16 May 2020 06:18:44 -0400 Date: Sat, 16 May 2020 10:18:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail; t=1589624317; bh=OxQZQTa/dfm4DpMpw1mPcpb3usy51rMZkfgtmV16spM=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=AWxe2bzUM2z50GoTc6LccHW6jojgliwKIBgpjKdxrV9j0dl6uLuwHbVKjd+m+V5uq bat3UjgmNH38Lr1EO4n7cTfo+tbGd4Gyv6sc+DrfqwkwD6QuvV879JQvVJk752W4qB 63ACoq/+lknU8BnyFr/mA+X5q3RYFWXczpn5aGJw= From: Ekaitz Zarraga Message-ID: In-Reply-To: <87k11c5ymm.fsf@member.fsf.org> References: <5kf9uJF2SDo9zwlTUoFI13o7P7q68o-AuSp72MvOp5PUaF2SlAPxzQJvFws5aaTOB5EHY4T3-En0Mhba7hADMIeJkgCeWUOY_Ciy0fv24Ck=@elenq.tech> <87k11c5ymm.fsf@member.fsf.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ekaitz Zarraga Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=elenq.tech header.s=protonmail header.b=AWxe2bzU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=elenq.tech (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: 9vLn494yZHwF Hi, On Saturday, May 16, 2020 5:48 AM, wrote: > We generally try to enable all optional features when adding a package, > I'd go with: > > 1. Build the python bindings by default. > 2. Try seperate the python bindings into another output. (eg: newt) > 3. If 1 and 2 seems difficult, try add a seperate package for the > python bindings, and it better only contains the bindings, reuse the > original package as input. (eg: python-libxml2) > > 4. If not feel lucky, just leave a TODO comment for it... > I don't really like the first because it forces you to add a python interpr= eter that is not needed otherwise. 2 and 3 sound good to me. It can handle both python2 and 3. What would you do with that? Maybe make option 3 and add two outputs to that with python2 and python3? O= r two different packages? (or just forget the python2?) > > > - The package is 300 megs checking `guix size` that's because it has = some testing binaries that have extra dependencies. If only the library is = compiled it doesn't depend on GLUT and that reduces the size a lot. I tried= to separate the package's outputs but I don't know how to do it correctly = (I checked the docs but it doesn't go in detail). I'd like to do it but I n= eed some help. > > To define a packages with multiple outputs: > > - Decide what =E2=80=98outputs=E2=80=99 can be made, eg: =E2=80=98doc= =E2=80=99, =E2=80=98bin=E2=80=99, =E2=80=98examples=E2=80=99, > etc. In this case, I=E2=80=99d add an =E2=80=98examples=E2=80=99 outp= ut, to put those > =E2=80=98freenect-*=E2=80=99 binaries, built from the =E2=80=9Cexampl= es=E2=80=9D directory. > > - Add an =E2=80=98outputs=E2=80=99 field, it default to =E2=80=98(list = "out")=E2=80=99, We=E2=80=99d use > =E2=80=98(outputs '("out" "examples")=E2=80=99. > > - Modify the install flags or phases to get files into their output > directory. Sometimes we can configure the target directory by flags, > but usually we have to move the files around after the install phase= =E2=80=A6 > > You can see =E2=80=98newt=E2=80=99 in =E2=80=98gnu/packages/slang.scm= =E2=80=99 for a example. Great! Thank you. That's more or less what I understood from some code exam= ples I checked but they were complex and I tried to make the same thing and= didn't work for me. I'll give it a new try with this example. Inputs can also be defined with an extra argument for different outputs, ri= ght? It should be something like: `(inputs `("freeglut" ,freeglut "examples")) Am I right? > > > - I'm not sure if the file where I added it is a good choice. > > Same here, we can always move it later=E2=80=A6 Yeah, sure. Thank you very much for your help. Best, Ekaitz