From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uGUsC+L/iWGJQAEAgWs5BA (envelope-from ) for ; Tue, 09 Nov 2021 05:58:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iOPdBuL/iWGaaQAA1q6Kng (envelope-from ) for ; Tue, 09 Nov 2021 04:58:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A3B369569 for ; Tue, 9 Nov 2021 05:58:09 +0100 (CET) Received: from localhost ([::1]:48216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkJCy-0005VD-Fb for larch@yhetil.org; Mon, 08 Nov 2021 23:58:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkJCs-0005V3-AU for guix-patches@gnu.org; Mon, 08 Nov 2021 23:58:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkJCs-0000FX-1Q for guix-patches@gnu.org; Mon, 08 Nov 2021 23:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mkJCr-000479-SR for guix-patches@gnu.org; Mon, 08 Nov 2021 23:58:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Nov 2021 04:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51427 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 51427@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Liliana Marie Prikler Received: via spool by 51427-submit@debbugs.gnu.org id=B51427.163643385015770 (code B ref 51427); Tue, 09 Nov 2021 04:58:01 +0000 Received: (at 51427) by debbugs.gnu.org; 9 Nov 2021 04:57:30 +0000 Received: from localhost ([127.0.0.1]:60305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkJCM-00046H-93 for submit@debbugs.gnu.org; Mon, 08 Nov 2021 23:57:30 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:43350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkJCK-000464-FM for 51427@debbugs.gnu.org; Mon, 08 Nov 2021 23:57:28 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkJCF-0006PO-6E; Mon, 08 Nov 2021 23:57:23 -0500 Date: Mon, 8 Nov 2021 23:57:23 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <87k0hi0xzp.fsf@gmail.com> Message-ID: References: <20211027034918.4591-1-maxim.cournoyer@gmail.com> <87o8795j61.fsf@gnu.org> <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@gmail.com> <87h7cxp9tl.fsf@gnu.org> <87sfwg7w9z.fsf@gmail.com> <87ee7tmdbd.fsf@gnu.org> <87k0hi0xzp.fsf@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-286994475-1636433843=:4243" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636433890; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=GUgvfg1mwx/8mYImKF2yjJZAYUJPd0VNem4P2cA2Brw=; b=A6X5AeP76uLbZ9xM9dI+6WwucDbKmhbEJzTsJAM4YjYaiKmDy7xb/pPI21c6l1xKX8Psz8 PlOsaVLX8trkYO/ObtfVhjsGmKhcsIyqZpgySVKiFxM+FIgEmEMZBm4A0YqySA4POrxFt7 MB9b6JUQ7XzdhulIsaoHZGmoEAkf/VP4ASTXmCniob11t8BHh3ERUvTyJeAbgntYsZT7XK kkTGXf8O1UF0APD4tuFyf4esnyQMRrg6SJCq56i4HfmlcWjmOfiw4WRY1w0dwysS98BxUf bC916Dz0yGDMCo17Vt343abVjsGHrzRld/v1oGoT4qIvQoTzfX7VZ5st5qSQRg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636433890; a=rsa-sha256; cv=none; b=d+fqGtuLwHavGEAdHxcvoMjia5QPz7SmC7N58LjG/rRKycd59GToU/hEK+HFf0LPj7LF+u Fm23opVdiyPNTaiX/7EO3o4FbwLjxz0uy3y5d4YIofj+UX68kMOPm7Jm0tM1tu8vHHC0YZ 9eokChDw2RdyqpkqhJqgP25TPsMZKRFVz62vbg3U3edWLli66qZF7fqhtdUAfq/QmpYsYE R/2vkoIYRSOeAkU0dWgDJ4aPb5wD3sM6rpi7LITTf+Kk5EUmMDv5Ahz2yFQYmSMXdWVoIN YoizHLggfqj/0mYs3+DPIKmoLHIjwNOBUDit0X3LslA0Zu15qUdF3N9YrTNdWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.08 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A3B369569 X-Spam-Score: 0.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: OGvOce/DIves This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-286994475-1636433843=:4243 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 8 Nov 2021, Maxim Cournoyer wrote: > Ludovic Courtès writes: > >> BTW, those using Btrfs can probably use ‘--disable-deduplication’ and be >> done with it. > > I erroneously used to think that Btrfs could do live deduplication, but > it doesn't. There are external tools to do out of band / batch > deduplication though [0]; so if they perform better than the guix daemon's > own dedup, perhaps we could document this way out for our Btrfs users. > > [0] https://btrfs.wiki.kernel.org/index.php/Deduplication A little while ago I had hoped to test btrfs with --disable-deduplication and bees [1] as the deduplication agent, but wasn't able to successfully run a system with --disable-deduplication because I needed the deduplication to cover up problem with grafts [2]. Until we resolve the second issue, I don't think we should recommend folks run the daemon with --disable-deduplication. [1] https://issues.guix.gnu.org/47983 (still missing a service) [2] https://issues.guix.gnu.org/47115 Best, Jack --925712948-286994475-1636433843=:4243--