From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id H4LCCqnPW2GjfgAAgWs5BA (envelope-from ) for ; Tue, 05 Oct 2021 06:08:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wDniBanPW2EJbgAA1q6Kng (envelope-from ) for ; Tue, 05 Oct 2021 04:08:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D02ECEDAC for ; Tue, 5 Oct 2021 06:08:07 +0200 (CEST) Received: from localhost ([::1]:43646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXbkM-0006kg-J7 for larch@yhetil.org; Tue, 05 Oct 2021 00:08:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXbkI-0006kW-LQ for guix-patches@gnu.org; Tue, 05 Oct 2021 00:08:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXbkI-0008Dd-CH for guix-patches@gnu.org; Tue, 05 Oct 2021 00:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mXbkH-0005HN-Uf for guix-patches@gnu.org; Tue, 05 Oct 2021 00:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50914] [PATCH] records: Raise a &fix-hint if a field has multiple values. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Oct 2021 04:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50914 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 50914@debbugs.gnu.org Received: via spool by 50914-submit@debbugs.gnu.org id=B50914.163340682420224 (code B ref 50914); Tue, 05 Oct 2021 04:08:01 +0000 Received: (at 50914) by debbugs.gnu.org; 5 Oct 2021 04:07:04 +0000 Received: from localhost ([127.0.0.1]:38752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXbjM-0005G8-1B for submit@debbugs.gnu.org; Tue, 05 Oct 2021 00:07:04 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:35496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXbjH-0005Fb-Rh for 50914@debbugs.gnu.org; Tue, 05 Oct 2021 00:07:02 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXbjC-00031l-96; Tue, 05 Oct 2021 00:06:54 -0400 Date: Tue, 5 Oct 2021 00:06:54 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: Message-ID: References: <20210930093229.4730-1-maximedevos@telenet.be> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-234003942-1633406814=:4243" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633406888; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Wtx9c4FAEPj+If6HjbMULCeWLCmMNTy7L1SQvcyLTyg=; b=UKWRyi8pHq28KjaKaB9pQX5ZdNIG7biNigsMXXkk763CSIhwu9oHEnXScJZGcmRSk8vYUX qM0jpE5MAJio43mXMvdbLbF62vWybUpWt1J8OsMSMrrY7Qh5cwv0/dmJxNwCY6Qb4UQBUN HIqhxVM5StubUK8ieUiou3WZ8+sWm68cW2N5lVf3tSfGvvYW5XGLyNDUKua1FB02JUcn3a opIfxLo4viHhF2PNsMDhiQ8fOz7YfMGt07TnD0i/PDzNHVZcSoII5ynMQSlYeabPnM/7k5 UA2h60WmRKO07d8i1WGVQnqIOpR3Uuuvxo7shbWRLE8G9JpUxg4UOgAvNJKFeA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633406888; a=rsa-sha256; cv=none; b=YqvRfe7skWH30fZ0VlCAU/r9imbs92Gf1E4JJj2h9ZicQh+aVIYKz74d3ntT+gdccxeQ1j pD67g2zxwhIzHz7QYcz1qpPLL5tkwHFbZ0gYXKdFvY3G0q8QgiYeGe6QVHOLSfFfqexGJ9 SVg0B5ULMRBpEdoG0+1iIlip/Ov5tH9woucSyfrmDuOtgmS9u0t2r8tsq59/HxIf4vV3Q3 8XcHBtvAdit98tVu9Ft4vrfYpAM+t5Ru0K/iUUxIB+yuPQf8PwAaRPKGZiUnvBt/WJ6WB1 36TyKTQ1NQLmuixhWairKFDNvZLqh2wkor1kROjKhiHedKyoOH8YX//+NZBPGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D02ECEDAC X-Spam-Score: -1.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: /RdJRSmzp+Kj This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-234003942-1633406814=:4243 Content-Type: text/plain; charset=ISO-8859-7; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 4 Oct 2021, Jack Hill wrote: > Wow, thanks for picking up on an annoyance I mentioned on IRC an providing a > patch! > > On Thu, 30 Sep 2021, Maxime Devos wrote: > >> * guix/records.scm (report-invalid-field-specifier): If >> 'weird' is something like (field (record ...) extra ...), hint that 'extra >> ...' should probably be moved inside (record ...). >> --- > > I don't have any comments on the code directly, but while the error message > is much improved, and would have helped me find my mistake quicker, it's > still a bit verbose and doesn't seem to be printing your nice error message. I did perturb the package definition in different ways and got your error message ``` error: field ¡uri¢ should only have one value, but an extra value ¡(sha256 (base32 0idhpvafy0gy3bdvw98q974wdv2x6vld2sv1f95ssl4l226cdqs4))¢ was passed as well. Perhaps this extra value was supposed to be a field specifier, and needs to be moved inside the record ¡(git-reference (url https://github.com/mvz/email-outlook-message-perl) (commit dd382f47fd112032bf91cb673178a27142d23e38))¢? hint: (uri (git-reference (url "https://github.com/mvz/email-outlook-message-perl") (commit "dd382f47fd112032bf91cb673178a27142d23e38") (sha256 (base32 "0idhpvafy0gy3bdvw98q974wdv2x6vld2sv1f95ssl4l226cdqs4")) (file-name (git-file-name name version)))) ``` with ``` (define-public msgconvert (package (name "msgconvert") (version "0.920") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/mvz/email-outlook-message-perl") (commit "dd382f47fd112032bf91cb673178a27142d23e38" ;; (string-append "v" version) )) (sha256 (base32 "0idhpvafy0gy3bdvw98q974wdv2x6vld2sv1f95ssl4l226cdqs4")) (file-name (git-file-name name version))))) (build-system perl-build-system) (native-inputs `(("perl-module-build" ,perl-module-build))) (inputs `(("perl-email-address" ,perl-email-address) ("perl-email-mime" ,perl-email-mime) ("perl-email-mime-contenttype" ,perl-email-mime-contenttype) ("perl-email-sender" ,perl-email-sender) ("perl-email-simple" ,perl-email-simple) ("perl-io-all" ,perl-io-all) ("perl-io-string" ,perl-io-string) ("perl-ole-storage-lite" ,perl-ole-storage-lite))) (home-page "https://www.matijs.net/software/msgconv") (synopsis "Foo") (description "Foo.") (license license:gpl1+))) ``` Best, Jack --925712948-234003942-1633406814=:4243--