From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 1eEsMFyyW2FAMAAAgWs5BA (envelope-from ) for ; Tue, 05 Oct 2021 04:03:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id dkxQK1yyW2GMFQAA1q6Kng (envelope-from ) for ; Tue, 05 Oct 2021 02:03:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3C5CFDB09 for ; Tue, 5 Oct 2021 04:03:08 +0200 (CEST) Received: from localhost ([::1]:49486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXZnP-000111-Cc for larch@yhetil.org; Mon, 04 Oct 2021 22:03:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXZnK-00010s-KO for guix-patches@gnu.org; Mon, 04 Oct 2021 22:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55333) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXZnK-0003lQ-D4 for guix-patches@gnu.org; Mon, 04 Oct 2021 22:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mXZnK-0002FH-A6 for guix-patches@gnu.org; Mon, 04 Oct 2021 22:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50914] [PATCH] records: Raise a &fix-hint if a field has multiple values. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Oct 2021 02:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50914 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 50914@debbugs.gnu.org Received: via spool by 50914-submit@debbugs.gnu.org id=B50914.16333993488584 (code B ref 50914); Tue, 05 Oct 2021 02:03:02 +0000 Received: (at 50914) by debbugs.gnu.org; 5 Oct 2021 02:02:28 +0000 Received: from localhost ([127.0.0.1]:38646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXZmm-0002EO-9v for submit@debbugs.gnu.org; Mon, 04 Oct 2021 22:02:28 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:35050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXZmi-0002E7-DV for 50914@debbugs.gnu.org; Mon, 04 Oct 2021 22:02:27 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXZmc-00063x-MR; Mon, 04 Oct 2021 22:02:18 -0400 Date: Mon, 4 Oct 2021 22:02:18 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <20210930093229.4730-1-maximedevos@telenet.be> Message-ID: References: <20210930093229.4730-1-maximedevos@telenet.be> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-1050268285-1633399338=:4243" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633399388; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=9mei9/prrBVPhXLhqBFmI9C5OaA3UwIu72PV9Non7gY=; b=If0BJ4oyOJs8vRar5A+L82yMnMfB8Y1CBWwFT3nbrIqnBl1Z0i5ptNX2wzK/1AVBnYeh6H zCD5g3jfcRPXfyncU6mT1GFhQj0VVr3u6CJ3Yws+AHoQfLe22nNNUyMIZEe+0CkR9YrWvG wn6lDDXZvgW8or650N4xUUi5Qo2I0N8Goi/nPHvf0/G1T6bYudrAR48XYQgsP4ZgsKX9hM 6yTAUZCNLvxAaeMCqDuGnOkwbrdH9eB4ulf7BN6xkznwNYvEJoujYNYPTx5R/XdFImHp/+ KRieS56u38Jq+KSV2SBwAfTmj8Ejo8igDXEYHv/8Tyne5PLtMMXEevXMNZZ02w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633399388; a=rsa-sha256; cv=none; b=YRYzPjT1rMPSUAbYMcFjs/UmxMuvQCEdJi+Oj4ASzadU5V76YHiT3U0Hl/OAkTJHV7cyur Ro9S4skkcDmX4Tu5Yk3mRnQT3yjZzaBXaH/PF+X0wSn/FMceEI/cTmjrI8l9KnwO7438D6 d9u6LJcFmgt/y7Cc2lKTzbXDCTPAxaM8U4UjiusMOoyr+XYSU+vn0Kk1eXMyv47Mycclvu QYh7ZOHFqG/Cnr30sV8AWkuwxqXOAmnXh1+WRTIRp7EwrRcHNOdyxNK457V50LyLbPTm2K nFHN7P6dpWWfvgqUPgg3FuixtkjqhxWa5Mk5niUeH5dyLkPK+JFPNQjCobYZwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3C5CFDB09 X-Spam-Score: -1.81 X-Migadu-Scanner: scn1.migadu.com X-TUID: NFM05PKgwEdw This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-1050268285-1633399338=:4243 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 8BIT Wow, thanks for picking up on an annoyance I mentioned on IRC an providing a patch! On Thu, 30 Sep 2021, Maxime Devos wrote: > * guix/records.scm (report-invalid-field-specifier): If > 'weird' is something like (field (record ...) extra ...), hint that 'extra > ...' should probably be moved inside (record ...). > --- I don't have any comments on the code directly, but while the error message is much improved, and would have helped me find my mistake quicker, it's still a bit verbose and doesn't seem to be printing your nice error message. The error I now get is, ``` gnu/packages/mail.scm:2884:2: error: (package (name "msgconvert") (version "0.920") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/mvz/email-outlook-message-perl") (commit "dd382f47fd112032bf91cb673178a27142d23e38"))))) (sha256 (base32 "0idhpvafy0gy3bdvw98q974wdv2x6vld2sv1f95ssl4l226cdqs4")) (file-name (git-file-name name version)) (build-system perl-build-system) (native-inputs (quasiquote (("perl-module-build" (unquote perl-module-build))))) (inputs (quasiquote (("perl-email-address" (unquote perl-email-address)) ("perl-email-mime" (unquote perl-email-mime)) ("perl-email-mime-contenttype" (unquote perl-email-mime-contenttype)) ("perl-email-sender" (unquote perl-email-sender)) ("perl-email-simple" (unquote perl-email-simple)) ("perl-io-all" (unquote perl-io-all)) ("perl-io-string" (unquote perl-io-string)) ("perl-ole-storage-lite" (unquote perl-ole-storage-lite))))) (home-page "https://www.matijs.net/software/msgconv") (synopsis "Foo") (description " Foo.") (license license:gpl1+)): extraneous field initializers (sha256 file-name) ``` For reference, the faulty package definition I used to test: ``` (define-public msgconvert (package (name "msgconvert") (version "0.920") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/mvz/email-outlook-message-perl") (commit "dd382f47fd112032bf91cb673178a27142d23e38" ;; (string-append "v" version) ))) )) (sha256 (base32 "0idhpvafy0gy3bdvw98q974wdv2x6vld2sv1f95ssl4l226cdqs4")) (file-name (git-file-name name version)) (build-system perl-build-system) (native-inputs `(("perl-module-build" ,perl-module-build))) (inputs `(("perl-email-address" ,perl-email-address) ("perl-email-mime" ,perl-email-mime) ("perl-email-mime-contenttype" ,perl-email-mime-contenttype) ("perl-email-sender" ,perl-email-sender) ("perl-email-simple" ,perl-email-simple) ("perl-io-all" ,perl-io-all) ("perl-io-string" ,perl-io-string) ("perl-ole-storage-lite" ,perl-ole-storage-lite))) (home-page "https://www.matijs.net/software/msgconv") (synopsis "Foo") (description "Foo.") (license license:gpl1+))) ``` Best, Jack --925712948-1050268285-1633399338=:4243--