From: Jack Hill <jackhill@jackhill.us>
To: Sarah Morgensen <iskarian@mgsn.dev>
Cc: 49539@debbugs.gnu.org
Subject: [bug#49539] [PATCH] gnu: Add nginx-rtmp-module.
Date: Thu, 22 Jul 2021 16:53:32 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.21.2107221649500.2109@marsh.hcoop.net> (raw)
In-Reply-To: <86im13ro1i.fsf_-_@mgsn.dev>
[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]
On Wed, 21 Jul 2021, Sarah Morgensen wrote:
> Jack Hill <jackhill@jackhill.us> writes:
>
>> + ((#:phases phases)
>> + `(modify-phases ,phases
>> + ;; The LICENSE file will be overwritten with the one from nginx
>> + ;; when unpacking the nginx source, so copy this one to its own
>> + ;; file.
>> + (add-after 'unpack 'preserve-license-file
>> + (lambda _ (copy-file "LICENSE" "LICENSE.rtmp")))
>> + (add-after 'preserve-license-file 'unpack-nginx-sources
>> + (lambda* (#:key inputs native-inputs #:allow-other-keys)
>> + (begin
>> + ;; The nginx source code is part of the module’s source.
>> + (format #t "decompressing nginx source code~%")
>> + (let ((tar (assoc-ref inputs "tar"))
>> + (nginx-srcs (assoc-ref inputs "nginx-sources")))
>> + (invoke (string-append tar "/bin/tar")
>> + "xvf" nginx-srcs "--strip-components=1"))
>
> You can probably drop the direct reference to tar and just use `(invoke
> "tar" ...)`
>
> Also, if you want to avoid the extra step of renaming the original
> LICENSE, you can use `--transform=s,/LICENSE$,/LICENSE.nginx,` as an
> argument to tar.
Thanks for suggesting these improvements! I've incorporated them into a
version 3 that I'll post shortly.
Best,
Jack
P.S. The same opportunities for improvement exists in some of our other
nginx modules, from which I copied this phase. The next time we update
those might be a good time to clean them up.
next prev parent reply other threads:[~2021-07-22 20:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 20:39 [bug#49539] [PATCH] gnu: Add nginx-rtmp-module Jack Hill
2021-07-12 20:52 ` Jonathan Brielmaier
2021-07-12 21:11 ` Jack Hill
2021-07-12 21:13 ` [bug#49539] [PATCH v2] " Jack Hill
2021-07-22 4:05 ` [bug#49539] [PATCH] " Sarah Morgensen
2021-07-22 20:53 ` Jack Hill [this message]
2021-07-22 20:55 ` [bug#49539] [PATCH v3] " Jack Hill
2021-07-29 19:48 ` bug#49539: [PATCH] " Ludovic Courtès
2021-07-24 22:07 ` [bug#49539] " Sarah Morgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2107221649500.2109@marsh.hcoop.net \
--to=jackhill@jackhill.us \
--cc=49539@debbugs.gnu.org \
--cc=iskarian@mgsn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).