unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jack Hill <jackhill@jackhill.us>
To: 49014@debbugs.gnu.org
Subject: [bug#49014] [PATCH 0/2] Add tlf
Date: Mon, 14 Jun 2021 00:12:23 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2106132357190.2109@marsh.hcoop.net> (raw)

This series adds a package for Tlf, an amateur (ham) radio logging 
program. Some things to note:

Tlf depends on hamlib, which has `Requires.private: libusb-1.0` in its 
pkg-config file. Tlf fails to build if libusb is not present in its build 
environment. I saw two options for resolving this: 1) add libusb as an 
input for tlf or 2) propagate libusb from hamlib. I chose the latter, but 
I'm not sure if that's the right choice as hamlib also provides binaries, 
so folks might want to install it in their profiles in addition to using 
it as a library.

The released version of Tlf doesn't work with our packaged version of 
hamlib because hamlib made a breaking change in the name of one of their 
macros. I added a patch from newer Tlf commits that works around this by 
adding some indirection.

I tested that it builds reproducably on x86_64-linux, and that it builds 
emulated aarch64-linux and armhf-linux. I was happy to see, especially on 
armhf, that I didn't run into the problem that caused Debian to add a 
patch:

https://salsa.debian.org/debian-hamradio-team/tlf/-/blob/8a0cbff093ac8846aa73ff012668b55628056ef4/debian/patches/979377-test-cabrillo

Jack Hill (2):
   gnu: hamlib: Make libusb a propagated input.
   gnu: Add tlf.

  gnu/local.mk                                  |  1 +
  .../patches/tlf-support-hamlib-4.2+.patch     | 66 +++++++++++++++++++
  gnu/packages/radio.scm                        | 64 +++++++++++++++++-
  3 files changed, 130 insertions(+), 1 deletion(-)
  create mode 100644 gnu/packages/patches/tlf-support-hamlib-4.2+.patch

-- 
2.32.0





             reply	other threads:[~2021-06-14  4:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14  4:12 Jack Hill [this message]
2021-06-14  4:14 ` [bug#49014] [PATCH 1/2] gnu: hamlib: Make libusb a propagated input Jack Hill
2021-06-14  4:14   ` [bug#49014] [PATCH 2/2] gnu: Add tlf Jack Hill
2021-06-14  4:20 ` [bug#49014] [PATCH v2 1/2] gnu: hamlib: Make libusb a propagated input Jack Hill
2021-06-14  4:20   ` [bug#49014] [PATCH v2 2/2] gnu: Add tlf Jack Hill
2021-06-18 16:15 ` [bug#49014] [PATCH v3] " Jack Hill
2021-06-21  8:52   ` bug#49014: " Guillaume Le Vaillant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2106132357190.2109@marsh.hcoop.net \
    --to=jackhill@jackhill.us \
    --cc=49014@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).