unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jack Hill <jackhill@jackhill.us>
To: Raghav Gururajan <rg@raghavgururajan.name>
Cc: 48953@debbugs.gnu.org
Subject: [bug#48953] [PATCH v2 3/3] gnu: dino: Enable missing features.
Date: Thu, 10 Jun 2021 23:35:25 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2106102331090.2109@marsh.hcoop.net> (raw)
In-Reply-To: <20210611011550.27628-3-rg@raghavgururajan.name>

[-- Attachment #1: Type: text/plain, Size: 2083 bytes --]

On Thu, 10 Jun 2021, Raghav Gururajan via Guix-patches via wrote:

> * gnu/packages/messaging.scm (dino)[phases](wrap-env): New phase.
> [inputs]: Add gspell, gstreamer, gst-plugins-base, gst-plugins-good,
> icu4c, libsrtp and webrtc-audio-processing.
> ---
> gnu/packages/messaging.scm | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index 5be733f3a2..41f26ba8e0 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -114,6 +114,7 @@
>   #:use-module (gnu packages sphinx)
>   #:use-module (gnu packages sqlite)
>   #:use-module (gnu packages tcl)
> +  #:use-module (gnu packages telephony)
>   #:use-module (gnu packages texinfo)
>   #:use-module (gnu packages textutils)
>   #:use-module (gnu packages tls)
> @@ -1241,6 +1242,17 @@ Encryption to Gajim.")
>                            (guix build glib-or-gtk-build-system))
>        #:phases
>        (modify-phases %standard-phases
> +         (add-after 'install 'wrap-env
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (for-each
> +                (lambda (name)
> +                  (let ((file (string-append out "/bin/" name))
> +                        (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
> +                    (wrap-program file
> +                      `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))
> +                '("dino")))
> +             #t))

Nitpick of a sort: Can we forgo the #t with the (hopefully soon) 
upcoming core-updates merge?

[…]

> +       ("gspell" ,gspell)               ; for spell-check support
> +       ("gstreamer" ,gstreamer)         ; for A/V support
> +       ("gst-plugins-base" ,gst-plugins-base)
> +       ("gst-plugins-good" ,gst-plugins-good)

[…]

> +       ("webrtc-audio-processing" ,webrtc-audio-processing))) ; for A/V support

Is there actual A/V support in this version of Dino, or is that only 
coming in 0.3.0?

Best,
Jack

  reply	other threads:[~2021-06-11  3:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11  1:00 [bug#48953] [PATCH v1 00/03]: Improve Dino Raghav Gururajan via Guix-patches via
2021-06-11  1:01 ` [bug#48953] [PATCH v1 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
2021-06-11  1:01   ` [bug#48953] [PATCH v1 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
2021-06-11  1:01   ` [bug#48953] [PATCH v1 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
2021-06-11  1:15 ` [bug#48953] [PATCH v2 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
2021-06-11  1:15   ` [bug#48953] [PATCH v2 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
2021-06-11  3:31     ` Jack Hill
2021-06-11 15:06       ` Jack Hill
2021-06-17  0:17       ` Raghav Gururajan via Guix-patches via
2021-06-11  1:15   ` [bug#48953] [PATCH v2 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
2021-06-11  3:35     ` Jack Hill [this message]
2021-06-17  0:19       ` Raghav Gururajan via Guix-patches via
2021-06-16  7:17 ` [bug#48953] [PATCH v3 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
2021-06-16  7:17   ` [bug#48953] [PATCH v3 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
2021-06-16  7:17   ` [bug#48953] [PATCH v3 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
2021-06-16  7:19 ` [bug#48953] [PATCH v4 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
2021-06-16  7:19   ` [bug#48953] [PATCH v4 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
2021-06-16  7:19   ` [bug#48953] [PATCH v4 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
2021-06-17  0:20 ` [bug#48953] [PATCH v5 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
2021-06-17  0:20   ` [bug#48953] [PATCH v5 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
2021-06-17  0:20   ` [bug#48953] [PATCH v5 3/3] gnu: dino: Enable some features Raghav Gururajan via Guix-patches via
2021-06-21 17:19     ` Jack Hill
2021-06-22  5:19 ` bug#48953: (no subject) Raghav Gururajan via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2106102331090.2109@marsh.hcoop.net \
    --to=jackhill@jackhill.us \
    --cc=48953@debbugs.gnu.org \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).