From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kMDCLf1ve2CGlwAAgWs5BA (envelope-from ) for ; Sun, 18 Apr 2021 01:32:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wF2HKP1ve2DMcAAAB5/wlQ (envelope-from ) for ; Sat, 17 Apr 2021 23:32:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C4C9F563 for ; Sun, 18 Apr 2021 01:32:13 +0200 (CEST) Received: from localhost ([::1]:41360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXuQ8-0003sI-Ic for larch@yhetil.org; Sat, 17 Apr 2021 19:32:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXuO2-0002hi-Ls for guix-patches@gnu.org; Sat, 17 Apr 2021 19:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33360) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXuO2-0004Z0-Du for guix-patches@gnu.org; Sat, 17 Apr 2021 19:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXuO2-0002Q6-94 for guix-patches@gnu.org; Sat, 17 Apr 2021 19:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47852] [PATCH] gnu: Add sc-im Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 17 Apr 2021 23:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47852 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart Cc: Oliver Loaiza , ekaitz@elenq.tech, raghavgururajan@disroot.org, hello@elenq.tech, Raghav Gururajan , 47852@debbugs.gnu.org Received: via spool by 47852-submit@debbugs.gnu.org id=B47852.16187021759241 (code B ref 47852); Sat, 17 Apr 2021 23:30:02 +0000 Received: (at 47852) by debbugs.gnu.org; 17 Apr 2021 23:29:35 +0000 Received: from localhost ([127.0.0.1]:44906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXuNa-0002Oy-Vp for submit@debbugs.gnu.org; Sat, 17 Apr 2021 19:29:35 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:60808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXuNX-0002Og-22 for 47852@debbugs.gnu.org; Sat, 17 Apr 2021 19:29:33 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXuNP-0001NP-0Y; Sat, 17 Apr 2021 19:29:23 -0400 Date: Sat, 17 Apr 2021 19:29:22 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <15c0925b25d9950553a55a4881922cc4@dismail.de> Message-ID: References: <15c0925b25d9950553a55a4881922cc4@dismail.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-792663861-1618702163=:8414" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618702333; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=FR5AjDyu1IvDVMKVIL+jatf95ei80IBnvYQWpdrGFM8=; b=S1/FF9PYmVkJsWPxZvew5GiwloXjRcVdG5Q5wdOIq7QYgPJssdsm3fAyrAYdjtlBsnVolc 1gjp4d6Lub6/3N3lVYbadbvOS+mBFIw6lbtsjHxaD11dW0FqxM8O2wSRO9tuvqaAqNDquT 7hlLHEHGAARW+KBerggWx28csFKScF77NHyn4lrdQCsjFlMqiMBG8YTeqSCIY8AHKyJMWk vDLXjC1YSLcGuoVp/YWmHwPhtzYfAPI/m0r7BiZaOOvFHJyqHGVB6mmyqnzQvDBSiBg8bu u4XrvjO51P+5MJFirxEhWEyF/TbR8pitJjxvn8A8sewEhkVtkizonMJmfrl58A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618702333; a=rsa-sha256; cv=none; b=Apc5LgpL9uBg17L+gbcjA5KCIF4F1p8MQ0xiDdBjUu4OK5FYLrt1Or0eUtlsLt31EWi8QS 1BxCqg5H3rqEntqyoV0I7A6bzh3PQjIEGAUbPftT8v+lrMAi/FSYw6yUwQm5r7oYbdRojX iDxhgddO44e2pBCqKEt0h1RNL1lm5QpwF3Vbsc2+dcC1kyn7hU9ZwJJF/RXPBl/i/LZwAs AZWCV3sgJy/L9sdOVcGGSRQ1d5SqWsSdfbquHCQ47sDvDe614Ue4SiWBZUbo4qf1/wnxxk TBCSH/FszfaRX6HKJsAXBSNEnd3t1bd1e9FDi1ivG9HD979EdxLCjns+YeVyQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.44 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5C4C9F563 X-Spam-Score: -1.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: BLLlZAOSkvut This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-792663861-1618702163=:8414 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Sat, 17 Apr 2021, jgart via Guix-patches via wrote: > Hi Guix! > > Attached is a patch for sc-im, a terminal based spreadsheet program providing a vim-like experience. Interesting program, thanks for working on the package > I added Ekaitz as a co-author and added both of our copyrights to the top of the file. Glad to see this work being picket up and that we can collaborate across time. > This new version of sc-im is from 16 days ago. > > I'm currently getting the following two linter warnings: > > the source file name should contain the package name > permanent redirect from https://github.com/andmarti1424/sc-im.git to https://github.com/andmarti1424/sc-im > > Any suggestions for what I need to adjust to make those pass? I have some inline suggestions as follows: >From 62b2b692329f8db791db08700821111238ed40be Mon Sep 17 00:00:00 2001 From: jgart Date: Sat, 17 Apr 2021 17:43:16 -0400 Subject: [PATCH] gnu: Add sc-im. * gnu/packages/visidata.scm: New file. Should be sc-im.scm there :) I have no opinion on if this warrants its own file, but I expect others would be willing to comment. * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. Co-authored-by: Ekaitz Zarraga +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2020 Ekaitz Zarraga +;;; Copyright © 2021 jgart +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu packages sc-im) + #:use-module (guix packages) + #:use-module (guix git-download) + #:use-module (guix download) + #:use-module (guix build-system gnu) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (gnu packages) + #:use-module (gnu packages base) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages maths) + #:use-module (gnu packages statistics) + #:use-module (gnu packages xml) + #:use-module (gnu packages compression) + #:use-module (gnu packages bison) + #:use-module (gnu packages ncurses)) + +(define-public sc-im + (let ((commit-ref "75ae3806844821cba1b2e3fdb9237d737944e850")) + (package + (name "sc-im") + (version "0.8.1") + (source (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/andmarti1424/sc-im.git") + (commit commit-ref))) You can remove the .git from the url to clear up the permanent redirect lint warning. In other packages, we use the tag directly with something like (commit (string-append "v" version)) and are thus able to forgo the let binding. Unless there is a reason to think upstream will move the tag to a different commit, I recommend doing that here too. Also, adding `(file-name (git-file-name name version))` to the origin specification will clear up the file name lint warning. + (sha256 + (base32 + "1i1yq5mh9d7yi1bkgaq4p1lr8zrxhlvqmjnj33wmg5v6vpfim1h0")))) + (build-system gnu-build-system) + (arguments + ;; There are no tests at the moment. + ;; https://github.com/andmarti1424/sc-im/issues/537 + ;; https://github.com/andmarti1424/sc-im/pull/385 + `(#:tests? #f Thanks for adding the comment about the lack of test. + #:make-flags (list "-C" "src" "CC=gcc" We prefer `(string-append "CC=" ,(cc-for-target))` which helps when cross-compiling + (string-append "prefix=" (assoc-ref %outputs "out"))) + #:phases + (modify-phases + %standard-phases + (delete 'configure)))) + (inputs + `(("gnuplot" ,gnuplot) + ("libxls" ,libxls) + ("libxlsxwriter" ,libxlsxwriter) + ("libxml2" ,libxml2) + ("libzip" ,libzip) + ("ncurses" ,ncurses))) + (native-inputs + `(("pkg-config" ,pkg-config) + ("which" ,which) + ("bison" ,bison))) + (synopsis "Spreadsheet program with vim-like keybindings") + (description + "@code{sc-im} is a highly configurable spreadsheet program + providing a vim-like experience. @code{sc-im} supports @{gnuplot} interaction, + functions for sorting and filtering, 256 color support, and much more.") + (home-page "https://github.com/andmarti1424/sc-im") + (license license:bsd-4)))) -- 2.29.3 Can you send an updated patch? Best, Jack --925712948-792663861-1618702163=:8414--