From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qF3tJXFN3F7tfQAA0tVLHw (envelope-from ) for ; Sun, 07 Jun 2020 02:14:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id xvLCIXFN3F4mHQAA1q6Kng (envelope-from ) for ; Sun, 07 Jun 2020 02:14:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0025A9401CB for ; Sun, 7 Jun 2020 02:14:08 +0000 (UTC) Received: from localhost ([::1]:41620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhkp5-0001FX-Bv for larch@yhetil.org; Sat, 06 Jun 2020 22:14:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhkp0-0001FO-14 for guix-patches@gnu.org; Sat, 06 Jun 2020 22:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41351) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhkoz-0007px-OI for guix-patches@gnu.org; Sat, 06 Jun 2020 22:14:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhkoz-00080S-H8 for guix-patches@gnu.org; Sat, 06 Jun 2020 22:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41695] [PATCH] Update Go to v1.14.4 Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 07 Jun 2020 02:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41695 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Katherine Cox-Buday Cc: 41695@debbugs.gnu.org Received: via spool by 41695-submit@debbugs.gnu.org id=B41695.159149599630711 (code B ref 41695); Sun, 07 Jun 2020 02:14:01 +0000 Received: (at 41695) by debbugs.gnu.org; 7 Jun 2020 02:13:16 +0000 Received: from localhost ([127.0.0.1]:52897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhkoG-0007zH-5v for submit@debbugs.gnu.org; Sat, 06 Jun 2020 22:13:16 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:32852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhkoE-0007z5-PO for 41695@debbugs.gnu.org; Sat, 06 Jun 2020 22:13:15 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jhko9-0005Wq-A8; Sat, 06 Jun 2020 22:13:09 -0400 Date: Sat, 6 Jun 2020 22:13:09 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <87d06c0zza.fsf@gmail.com> Message-ID: References: <87d06c0zza.fsf@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="925712948-124151133-1591495989=:5735" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: up+lcUeGQpa/ This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-124151133-1591495989=:5735 Content-Type: text/plain; format=flowed; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sat, 6 Jun 2020, Katherine Cox-Buday wrote: > Jack Hill writes: > > You're welcome! Thanks for the review. I wish I had more time to > contribute to Guix. > > I suppose I should have qualified my statement by saying there's too > many dependent Go packages for me to test. I should invest in a better > computer :) More computing is nice, but in the meantime, I'm happy to be part of a community of other Guix people who can provide extra cycles when needed. I'd like to recognize the work Chris and Danjela are doing on Guix Data Service to ease patch review as well. >> Reading through the Go release notes [1], the following change to the >> net/url package caught my eye: >> >>> When parsing of a URL fails (for example by Parse or >>> ParseRequestURI), the resulting Error message will now quote the >>> unparsable URL. This provides clearer structure and consistency with >>> other parsing errors. >> >> I think this could be the cause of the docker test failure. Should we >> patch docker or perhaps try to update it? > > Spot on! I've updated docker and docker-cli. hyperledger-fabric depends > on docker-cli and also continues to build. I've attached a patch which > should supersede the prior patch. It updates go, docker, and docker-cli > atomically. I'm happy to confirm that the revised path fixes the docker problem here as well. […] >> I am curious, why switch to using git-fetch? > > `guix lint` now complains about downloading tarballs. I have also > recently seen some chatter on the mailing list about preferring this. Right, I remember that thread, thanks! Hopefully a more experienced reviewer/committer will confirm that everything looks good and push soon. Best, Jack --925712948-124151133-1591495989=:5735--