unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jack Hill <jackhill@jackhill.us>
To: Katherine Cox-Buday <cox.katherine.e@gmail.com>
Cc: 41695@debbugs.gnu.org
Subject: [bug#41695] [PATCH] Update Go to v1.14.4
Date: Sat, 6 Jun 2020 22:13:09 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.20.2006062144370.5735@marsh.hcoop.net> (raw)
In-Reply-To: <87d06c0zza.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]

On Sat, 6 Jun 2020, Katherine Cox-Buday wrote:

> Jack Hill <jackhill@jackhill.us> writes:
>
> You're welcome! Thanks for the review. I wish I had more time to
> contribute to Guix.
>
> I suppose I should have qualified my statement by saying there's too
> many dependent Go packages for me to test. I should invest in a better
> computer :)

More computing is nice, but in the meantime, I'm happy to be part of a 
community of other Guix people who can provide extra cycles when needed.

I'd like to recognize the work Chris and Danjela are doing on Guix Data 
Service to ease patch review as well.

>> Reading through the Go release notes [1], the following change to the
>> net/url package caught my eye:
>>
>>> When parsing of a URL fails (for example by Parse or
>>> ParseRequestURI), the resulting Error message will now quote the
>>> unparsable URL. This provides clearer structure and consistency with
>>> other parsing errors.
>>
>> I think this could be the cause of the docker test failure. Should we
>> patch docker or perhaps try to update it?
>
> Spot on! I've updated docker and docker-cli. hyperledger-fabric depends
> on docker-cli and also continues to build. I've attached a patch which
> should supersede the prior patch. It updates go, docker, and docker-cli
> atomically.

I'm happy to confirm that the revised path fixes the docker problem here 
as well.

[…]

>> I am curious, why switch to using git-fetch?
>
> `guix lint` now complains about downloading tarballs. I have also
> recently seen some chatter on the mailing list about preferring this.

Right, I remember that thread, thanks!

Hopefully a more experienced reviewer/committer will confirm that 
everything looks good and push soon.

Best,
Jack

  reply	other threads:[~2020-06-07  2:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 23:36 [bug#41695] [PATCH] Update Go to v1.14.4 Katherine Cox-Buday
2020-06-05 21:07 ` Jack Hill
2020-06-06 19:13   ` Katherine Cox-Buday
2020-06-07  2:13     ` Jack Hill [this message]
2020-06-26 10:55       ` bug#41695: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.2006062144370.5735@marsh.hcoop.net \
    --to=jackhill@jackhill.us \
    --cc=41695@debbugs.gnu.org \
    --cc=cox.katherine.e@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).