From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:40073) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1bTv-0006uc-7X for guix-patches@gnu.org; Tue, 11 Feb 2020 14:46:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1bTu-0001uY-5C for guix-patches@gnu.org; Tue, 11 Feb 2020 14:46:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51603) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1bTu-0001uR-1I for guix-patches@gnu.org; Tue, 11 Feb 2020 14:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1bTt-0002mp-Tg for guix-patches@gnu.org; Tue, 11 Feb 2020 14:46:01 -0500 Subject: [bug#39570] go: update to 1.13 Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:38991) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1bTR-0006W9-9E for guix-patches@gnu.org; Tue, 11 Feb 2020 14:45:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1bTP-0000Uz-Ak for guix-patches@gnu.org; Tue, 11 Feb 2020 14:45:32 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:50768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j1bTO-0000QZ-NJ for guix-patches@gnu.org; Tue, 11 Feb 2020 14:45:31 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1j1bTM-0003GW-0W for guix-patches@gnu.org; Tue, 11 Feb 2020 14:45:28 -0500 Date: Tue, 11 Feb 2020 14:45:27 -0500 (EST) From: Jack Hill Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 39570@debbugs.gnu.org Hi Guix, The following is the minimal patch to update Go to 1.13. I'm motivated to do this, in part, because of the go modules transition [0]. In the short term, this will allow users of the go tooling to use the newest modules behavior. The Guix go tooling, however, is not ready for modules [1], so in this commit, I configure the go-build-system to use the old behavior. Eventually the switch to do so will go away upstream, so we'll need to update the build system. Some things to be aware of when reviewing: I believe that in Go 1.13, the upstream issued that lead to excessive references being maintained in go programs [2] has been fixed, but I did not undo our workaround. With 1.13 the behavior of `go get` changed to download packages from Google's mirror at proxy.golang.org by default [3] as opposed to directly from upstream. This is configurable by users, and I don't think it is a FSDG issue (if it is, I think it would be on privacy grounds), but we could change the default behavior if needed. I replaced the go-1.12 package with go-1.13, rather than having both. guix refresh -l go says that "Building the following 51 packages would ensure 175 dependent packages are rebuilt," so I have prepared the commit against master. I tested the commit by building syncthing and restic on my x86_64 system. [0] https://blog.golang.org/v2-go-modules [1] https://lists.gnu.org/archive/html/guix-devel/2020-02/msg00110.html [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33620 [3] https://golang.org/doc/go1.13#modules Thanks, Jack