From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oDFfC9uL1WF+egAAgWs5BA (envelope-from ) for ; Wed, 05 Jan 2022 13:15:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OBntB9uL1WHd+gAAauVa8A (envelope-from ) for ; Wed, 05 Jan 2022 13:15:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D3EF21ED0 for ; Wed, 5 Jan 2022 13:15:22 +0100 (CET) Received: from localhost ([::1]:33120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n55CL-0005HP-Lw for larch@yhetil.org; Wed, 05 Jan 2022 07:15:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n558A-0001kg-Ca for guix-patches@gnu.org; Wed, 05 Jan 2022 07:11:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n558A-0005bv-2h for guix-patches@gnu.org; Wed, 05 Jan 2022 07:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5589-0007fe-QM for guix-patches@gnu.org; Wed, 05 Jan 2022 07:11:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 0/4] Add upstream updater for git-fetch origins. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Jan 2022 12:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: Sarah Morgensen , 50072@debbugs.gnu.org Received: via spool by 50072-submit@debbugs.gnu.org id=B50072.164138461029423 (code B ref 50072); Wed, 05 Jan 2022 12:11:01 +0000 Received: (at 50072) by debbugs.gnu.org; 5 Jan 2022 12:10:10 +0000 Received: from localhost ([127.0.0.1]:39699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n557K-0007eU-8C for submit@debbugs.gnu.org; Wed, 05 Jan 2022 07:10:10 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:36922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n557H-0007eJ-VQ for 50072@debbugs.gnu.org; Wed, 05 Jan 2022 07:10:09 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id f0A6260024UW6Th010A6vR; Wed, 05 Jan 2022 13:10:06 +0100 Message-ID: From: Maxime Devos Date: Wed, 05 Jan 2022 12:10:01 +0000 In-Reply-To: <86y23u768v.fsf@gmail.com> References: <20220104200643.43374-1-maximedevos@telenet.be> <20220104200643.43374-2-maximedevos@telenet.be> <867dbfcf9n.fsf_-_@gmail.com> <52e7be94d926aa06c2a0132090e8c212381e7900.camel@telenet.be> <86y23u768v.fsf@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-iBee+YQimxTinYy8Ip8a" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1641384606; bh=rbw++mXOoYiI1OcCH5yk1m5mW+nHKqrI+LhcxKEbd4c=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=FyWcdyKvTE+LODj8kYLN4CpgeOxcBV3Z/L+IjyeGpL4n+i0MSNL5ivYw1KlT8a3KH MqEbjAeeTuaPZt13CRKR5U6R7f71Kv/gPypFaz83ebRrwEk3PxM6uL4tO5kkaVYZAS QZw943xZwEuyErzDInK84qDBqXLuTwRJWp61dYCuIfVcUnNZYG+0O3Po0ZNHqsQTsw ulYGfUdBVd7RmUgjWwbx8p2dakrsdYDRPZBbAwno16Zz1Lpcbw5SS9GSgvvtrhMZrx i7SNZm2fbVxHJ0CFiqiV53P0iioyaPckj7mpOdjClbqmOLaloSiAClqobg080sfAn0 NSDUHAmHNAz2Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641384922; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=rbw++mXOoYiI1OcCH5yk1m5mW+nHKqrI+LhcxKEbd4c=; b=A+CyNLQdJkrjFunfE+IzsQoXYKQmel3c8XQaceZNnso3FP1VW8o88K8DBghTtFvT5b/ddx e0W4+Zpvfy3XPQ4ZoOgfxHxJuyP0YnSHwfOEc3LQjRfPnRIsUZ22IzK1pfy1flnkW76CnJ 1ur1aQLn6UnNHhXcJdyHDhv0pPfel+JWFk/kLL8OXHFSA+rG+C2I0ZmSj42CGQYbHyrw5k Ba28AhnE0qAKSVP79s26uokZdTKFiP+cJ8QtoemxtS0VbhtxqpLRBXE2oPC1zAOqprsanB 3LvJRo/p18tAVsvRZvzTFr8ACigArYCiRnbFnCGLezRFASv3gC0sTX29q3b8rg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641384922; a=rsa-sha256; cv=none; b=R+PuAUiC5GDGSD92oKuD3syhh+Tn6AJuYstusGH32tmcldi/KgqXaMGrDdPD3bQZIalhg+ DQVohAB6M4kQjymX6N7GaC8ydwVR4QgxaIvJM8N7gQvLlOzlgOQzf2KfrcE6mIE+vQnIsl Zn4MgRfO5RSzfEMM+cOoc2rBgOv1zQhIgl+WUATlB0vUK3EprTgidQ6S/7BwHAyUYAiF1F 86WMFFUhCFWLOFrKH7S7D11NA31XuCojBjFgF6aVW6rplPe2NnK13U85sKIAf1fQZRZHhI R/L+M6xDioRsJXmU7FJIm2US6tcAgoD1kHLzr6gbxQ+UtiA/6mDiYEgHiOTcYQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=FyWcdyKv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=FyWcdyKv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8D3EF21ED0 X-Spam-Score: -4.20 X-Migadu-Scanner: scn1.migadu.com X-TUID: x5WbB9onsjJ9 --=-iBee+YQimxTinYy8Ip8a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable zimoun schreef op wo 05-01-2022 om 12:48 [+0100]: > > > > +=C2=A0 (if (or (eq? recursive? #true) > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (and (eq? r= ecursive? 'auto) > > >=20 > > > =E2=80=A6the symbol =E2=80=99auto=E2=80=99 is only used here.=C2=A0 I= IRC all the series. :-) > >=20 > > In =E2=80=98[PATCH v4 3/4] refresh: Support non-tarball sources.=E2=80= =99, there's > >=20 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (let ((hash (file-hash* output))) > >=20 > > There, #:recursive? is 'auto'. >=20 > Naive questions: Is it mandatory?=C2=A0 Or can be explicitly set? >=20 > (I have nothing against, just to me =E2=80=99auto=E2=80=99 is somehow amb= iguous and > =C2=ABIn > the face of ambiguity, refuse the temptation to guess=C2=BB as =E2=80=99p= yhon3 -c > 'import this'=E2=80=99 says ;-)) 'auto' is indeed a little ambigious, so I adjusted most calls to file-hash* to set #:recursive? #true/#false appropriately in=C2=A0v3. But in this particular case (guix/scripts/refresh.scm), it not known in advance, so some guesswork is necessary. Anyway, these calls to file-hash* are bothering me a little: can't we just record the hash in the 'upstream-source' record or ask the daemon for the hash of a store item (*) or something? (*) Maybe query-path-hash works or maybe there are problems. Also, would be nice if there was a variant of query-path-hash that works on non-sha256 (in principle guix supports other hashes, though currently they are unused). Or maybe query-path-hash is works differently. That would complicate this patch series more, so I'd prefer to delay that for a future patch series. Greetings, Maxime. --=-iBee+YQimxTinYy8Ip8a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYdWKmRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7mAvAPoDCzK6yPbZ1D2qdvfMDzNbDQzJ jFXBd3z2jNS8cWaH1AEA7We4WsrSQdz1EFwe9VyERTX7yazUrIkAvrZdOxxjbQg= =u1xx -----END PGP SIGNATURE----- --=-iBee+YQimxTinYy8Ip8a--