From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0iqT-0001l7-3S
	for guix-patches@gnu.org; Wed, 19 Apr 2017 02:12:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0iqP-0007LL-VU
	for guix-patches@gnu.org; Wed, 19 Apr 2017 02:12:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:57229)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d0iqP-0007LD-SQ
	for guix-patches@gnu.org; Wed, 19 Apr 2017 02:12:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d0iqP-0002Jz-Nq
	for guix-patches@gnu.org; Wed, 19 Apr 2017 02:12:01 -0400
Subject: bug#26488: [PATCH] gnu: Add crawl.
Resent-Message-ID: <handler.26488.B26488.14925823038897@debbugs.gnu.org>
Message-Id: <af1b313c.ADsAAHQO6XkAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY9v-d@mailjet.com>
MIME-Version: 1.0
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Wed, 19 Apr 2017 11:41:34 +0530
In-reply-to: <43dae64d-8d60-8930-ce6b-12afd44fe787@cock.li>
References: <9758282d-96a4-8fe4-183b-a60a43a9eab9@cock.li>
	<cu7shlbed1g.fsf@systemreboot.net>
	<791d5ba7.AEQAJP3OyzEAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY8IM9@mailjet.com>
	<f0593d7a-2db6-fad7-99c9-3b180c55e068@cock.li>
	<c09ea559.AEMAJMF3UlcAAAAAAAAAAAO0_XAAAAACwQwAAAAAAAW9WABY8Q9P@mailjet.com>
	<8ac92fe4-14dd-3933-8901-bea4ff8673ac@cock.li>
	<b75ed791.AEQAJYdmpaQAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY9QuM@mailjet.com>
	<43dae64d-8d60-8930-ce6b-12afd44fe787@cock.li>
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: nee <nee@cock.li>
Cc: 26488@debbugs.gnu.org


> Thank you very much, for your intensive help with cleaning up this packag=
e!

No problem! That's what I'm here for... :-) And, thank you for your
patience with all my corrections!

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (delete 'check)
> +         ;; Test cases require the source to be rebuild with the -DDEBUG=
 define.
> +         ;; Do 'check before 'build to avoid a 3rd build on make install=
.
> +         (add-before 'build 'check
> +           (lambda* (#:key inputs outputs make-flags
> +                     parallel-build? parallel-tests? #:allow-other-keys)

Since you are not using the parallel-build? and parallel-tests? keyword
arguments anymore, why keep them in the argument list?

> +             (zero? (apply system* "make" "debug" "test"
> +                           (cons (format #f "-j~d" (parallel-job-count))
> +                                 make-flags))))))))

As noted earlier, only the last argument of apply needs to be a
list. So, this can be shortened to something like:

(zero? (apply system* "make" (format #f "-j~d"
(parallel-job-count)) "debug" "test" make-flags))

Everything else LGTM! Only the graphical build remains now.
=