From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:45233) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iivLP-0005J0-T2 for guix-patches@gnu.org; Sun, 22 Dec 2019 02:08:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iivLO-0005dC-P3 for guix-patches@gnu.org; Sun, 22 Dec 2019 02:08:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iivLO-0005bx-JU for guix-patches@gnu.org; Sun, 22 Dec 2019 02:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iivLO-0001OD-Bj for guix-patches@gnu.org; Sun, 22 Dec 2019 02:08:02 -0500 Subject: [bug#38670] [PATCH] Fix audio/video in icecat Resent-Message-ID: Date: Sun, 22 Dec 2019 07:07:37 +0000 (UTC) From: Brett Gilio Message-ID: In-Reply-To: <87lfr57yi4.fsf@netris.org> References: <20191219145922.715720ad@sybil.lepiller.eu> <87k16pmh0b.fsf@gnu.org> <87lfr57yi4.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mark H Weaver Cc: Julien Lepiller , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 38670@debbugs.gnu.org Dec 21, 2019 10:54:14 PM Mark H Weaver : > Hi Julien, > > Thanks very much for investigating and producing a working fix for this > issue! It is a great relief to remove this item from my TODO list :) > > I have a few minor nits, and am currently testing a slight variant of > your proposed patch, attached below. I made the following changes: > > * I added a new phase instead of augmenting the existing > 'link-libxul-with-libraries' phase, since the name of the existing > phase doesn't match what's being done here. > > * I leave the numeric suffixes (version number) of the shared library > names unchanged, instead of stripping them as you did. > > * I used "\\." in the regexp to strictly match that character. > > * I moved the rationale comment from the commit log into the code. > > What do you think? > > Thanks again! > Mark > I think with Mark's changes this is looking pretty much perfect. -- Brett M. Gilio GNU Guix, Contributor | GNU Project, Webmaster [DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]