From: Brett Gilio <brettg@posteo.net>
To: Mark H Weaver <mhw@netris.org>
Cc: "Julien Lepiller" <julien@lepiller.eu>,
"Ludovic Courtès" <ludo@gnu.org>,
38670@debbugs.gnu.org
Subject: [bug#38670] [PATCH] Fix audio/video in icecat
Date: Sun, 22 Dec 2019 07:07:37 +0000 (UTC) [thread overview]
Message-ID: <af03418f-b45d-4219-aa5d-0c499db5705e@localhost> (raw)
In-Reply-To: <87lfr57yi4.fsf@netris.org>
Dec 21, 2019 10:54:14 PM Mark H Weaver :
> Hi Julien,
>
> Thanks very much for investigating and producing a working fix for this
> issue! It is a great relief to remove this item from my TODO list :)
>
> I have a few minor nits, and am currently testing a slight variant of
> your proposed patch, attached below. I made the following changes:
>
> * I added a new phase instead of augmenting the existing
> 'link-libxul-with-libraries' phase, since the name of the existing
> phase doesn't match what's being done here.
>
> * I leave the numeric suffixes (version number) of the shared library
> names unchanged, instead of stripping them as you did.
>
> * I used "\\." in the regexp to strictly match that character.
>
> * I moved the rationale comment from the commit log into the code.
>
> What do you think?
>
> Thanks again!
> Mark
>
I think with Mark's changes this is looking pretty much perfect.
--
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg@gnu.org> <brettg@posteo.net>
next prev parent reply other threads:[~2019-12-22 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 13:59 [bug#38670] [PATCH] Fix audio/video in icecat Julien Lepiller
2019-12-21 22:49 ` Ludovic Courtès
2019-12-22 4:52 ` Mark H Weaver
2019-12-22 7:07 ` Brett Gilio [this message]
2019-12-22 10:00 ` Julien Lepiller
2019-12-22 20:33 ` Mark H Weaver
2019-12-22 23:04 ` Julien Lepiller
2019-12-23 11:50 ` bug#38670: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af03418f-b45d-4219-aa5d-0c499db5705e@localhost \
--to=brettg@posteo.net \
--cc=38670@debbugs.gnu.org \
--cc=julien@lepiller.eu \
--cc=ludo@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).