From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:45745)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iL3r2-00063o-4U
 for guix-patches@gnu.org; Thu, 17 Oct 2019 07:22:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iL3r0-0005Us-TO
 for guix-patches@gnu.org; Thu, 17 Oct 2019 07:22:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:38423)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iL3r0-0005Uo-OO
 for guix-patches@gnu.org; Thu, 17 Oct 2019 07:22:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iL3r0-0007g7-KG
 for guix-patches@gnu.org; Thu, 17 Oct 2019 07:22:02 -0400
Subject: [bug#37741] [PATCH 2/3] gnu: Add arm-trusted-firmware-rk3399.
Resent-Message-ID: <handler.37741.B37741.157131131829493@debbugs.gnu.org>
References: <20191014001407.28367-1-nomble@palism.com>
 <20191014060136.31144-1-nomble@palism.com> <877e56vep3.fsf@yucca>
 <00df76bd-4997-0906-5e51-884704b4b0b9@rock-chips.com> <87o8yfudp1.fsf@yucca>
From: Kever Yang <kever.yang@rock-chips.com>
Message-ID: <aea8edd5-347c-db27-7a5a-b022979376f4@rock-chips.com>
Date: Thu, 17 Oct 2019 14:43:28 +0800
MIME-Version: 1.0
In-Reply-To: <87o8yfudp1.fsf@yucca>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Vagrant Cascadian <vagrant@debian.org>, nomble@palism.com, 37741@debbugs.gnu.org
Cc: Danny Milosavljevic <dannym@scratchpost.org>

Vagrant,

On 2019/10/17 下午1:46, Vagrant Cascadian wrote:
> On 2019-10-15, Kever Yang wrote:
>> On 2019/10/15 下午12:02, Vagrant Cascadian wrote:
>>> On 2019-10-14, nomble@palism.com wrote:
>>>> * gnu/packages/bootloaders.scm (arm-trusted-firmware-rk3399): New exported
>>>> variable.
>>> Thanks for working on this!
>>>
>>> Unfortunately this currently embeds a binary blob
>>> (plat/rockchip/rk3399/drivers/dp/hdcp.bin) with no license.
>>>
>>> I reported the issue upstream:
>>>
>>>     https://github.com/ARM-software/tf-issues/issues/651
>>
>> I have send the patch to ATF to remove the hdpc.bin, you can comment on it.
>>
>> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/2194
> On both Debian and Guix it fails to build with:
>
> plat/rockchip/rk3399/plat_sip_calls.c: In function
> ‘rockchip_plat_sip_handler’:
> plat/rockchip/rk3399/plat_sip_calls.c:59:15: error: unused variable ‘x6’
> [-Werror=unused-variable]
>    uint64_t x5, x6;
>                 ^~
> plat/rockchip/rk3399/plat_sip_calls.c:59:11: error: unused variable ‘x5’
> [-Werror=unused-variable]
>    uint64_t x5, x6;
>             ^~
> cc1: all warnings being treated as errors
> make: *** [Makefile:777: build/rk3399/debug/bl31/plat_sip_calls.o] Error
> 1
> make: *** Waiting for unfinished jobs....
> command "make" "-j" "3" "PLAT=rk3399" "CROSS_COMPILE=aarch64-linux-gnu-"
> "DEBUG=1" failed with status 2
>
>
> Also commented on the patch in review.trustedfirmware.org.


Sorry, I do catch this issue last week, but forgot to update it to the 
Gerrit.

Already update to a new patch set now.


Thanks,

- Kever

>
>
> live well,
>    vagrant