From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +PFeEaoGGGOXHAEAbAwnHQ (envelope-from ) for ; Wed, 07 Sep 2022 04:49:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MNhFEaoGGGNXjAAAauVa8A (envelope-from ) for ; Wed, 07 Sep 2022 04:49:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0D1EB12479 for ; Wed, 7 Sep 2022 04:49:13 +0200 (CEST) Received: from localhost ([::1]:58500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVl7n-0008VD-Ui for larch@yhetil.org; Tue, 06 Sep 2022 22:49:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVl7e-0008Tm-Sa for guix-patches@gnu.org; Tue, 06 Sep 2022 22:49:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVl7e-0001Co-F6 for guix-patches@gnu.org; Tue, 06 Sep 2022 22:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVl7e-0007sg-6L for guix-patches@gnu.org; Tue, 06 Sep 2022 22:49:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57625] [PATCH 1/3] gnu: Add libgc-private-headers-for-pnet. Resent-From: Adam Faiz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Sep 2022 02:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57625 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 57625@debbugs.gnu.org Received: via spool by 57625-submit@debbugs.gnu.org id=B57625.166251893430278 (code B ref 57625); Wed, 07 Sep 2022 02:49:02 +0000 Received: (at 57625) by debbugs.gnu.org; 7 Sep 2022 02:48:54 +0000 Received: from localhost ([127.0.0.1]:53065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVl7V-0007sI-Ue for submit@debbugs.gnu.org; Tue, 06 Sep 2022 22:48:54 -0400 Received: from knopi.disroot.org ([178.21.23.139]:53406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVl7T-0007s7-9w for 57625@debbugs.gnu.org; Tue, 06 Sep 2022 22:48:52 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 9BA2F4008D for <57625@debbugs.gnu.org>; Wed, 7 Sep 2022 04:48:49 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NDyh_S_DWmYd for <57625@debbugs.gnu.org>; Wed, 7 Sep 2022 04:48:48 +0200 (CEST) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1662518928; bh=Uz/287UxxK9CiY0C0AO4PB77hamKhnUJjgZKUpgdbNo=; h=Date:From:Subject:To:References:In-Reply-To; b=jvYEDj47c3tzNJrgJlCSnhEI/BEA5qGmzfBF2UaMQhfRn6NIx5e5MWxjeKDiZPwF/ uO0ZnUlclNexd+JMyR9Fs7pmH/LhZRhxMnfU4OgqTDWWeu0rfY4R2dKOWMYBW2Yt+i cNUr4M7EBg0vgfw9i1K1GM/V+lDLdo0efJzlwyjpI4PQFFvQu+vA63ja0IzIODVyuo HGvheIaYbWXN8L1FmJv/UAdgrrYf0och6lP1wG7AxovZgqWS4UKgvxYYMmyamERS5l qvWDc3vV31xIahb4jqC8XMFIxj0RQ0nlceIm2+kassNAnRK9sEMvo5+rityNQfUaDA mBsKaIgDcQK+g== Date: Wed, 7 Sep 2022 10:48:45 +0800 Mime-Version: 1.0 References: <9d424667-868f-03f2-c521-8c10e106d6d3@disroot.org> <620a920f-c95a-ada1-714c-dc39fc95c5a9@disroot.org> <13dfa7fa-a27f-f68d-43ba-4be55e14ba16@telenet.be> Content-Language: en-US In-Reply-To: <13dfa7fa-a27f-f68d-43ba-4be55e14ba16@telenet.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Adam Faiz X-ACL-Warn: , Adam Faiz via Guix-patches From: Adam Faiz via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662518954; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=I2SbJRfcwywCMcPgDecErFe/23OxfyuNY6x4IpqCPWo=; b=bJHncIOclMaDNUXsOUk6mYgJkcoS77hSScC/7YZpTIsmNHrHNFB9Tw3UlLsCYUzQw3TXmN 5JojfVdZdtx7ti76P3+cB0YjPB26ENxMDiwoG+iyd4nYV/851IRPG6ATIgb2fz/F5NmFOW LbnTAZofU1Y49s+zDsN6SRZJ60KEAfMMd1t2yqvbonmSvOdQ2uwBo+bGaIpAmI0y3EH3Ba njQgDx4ttX6JxzBVghQIqtFE1Q3D92PxbmTzEkdi9BZCPPU5JzGOuZn6TR6m57am2x3x9h xUtElfdl/tBL+XDtzTIQ9KrhFLKDbiF8bTkMao7So9lv49ia+/5oxHOu7ywlfQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662518954; a=rsa-sha256; cv=none; b=evHoNgnGACyIdRmFCVKn3pYgAoQtn0D6RhNRrZhZqgTvjuCLrgI28gw/B986KiIjcqux2S AQIFuGX+r03ThTvYZBPdQe0VrnOGUMrtBn+/PrZmDDYpZSbr7hd4tKYTchI8JI7TUheCpj cGsbQrYnBgmtbnwLn6UNhSJBBkaPGVfvGQ8Nnf0NgkeY6W8eerwBPcSaO7GsvDY6bSxcM3 po6ZBSZI/qDM4Nz6BDNgvw8Vdx9BU1Hx5hnwn6DTipOH2OywRe5G6y9B3j3MnLhPKA4Mko j0g8nfVFI4DgsSCad5xWVni1CV72InQf9Ar6SQe6BhAj6qbWyU9jfTy83FW8Ow== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=jvYEDj47; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.77 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=jvYEDj47; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0D1EB12479 X-Spam-Score: -2.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: mwy9CzoyQLtn On 9/7/22 00:55, Maxime Devos wrote: > Also, why a hidden package? > Greetings, > Maxime. I wasn't sure if the package would be useful being exposed to the user interface, since it's specific to pnet's needs. > (*) Untested proposal: > > (define-public libgc-all-headers ; TODO(core-updates) merge into libgc > (package > (inherit libgc) > (name "libgc-all-headers") > (outputs "out") > (arguments > (append (package-arguments libgc) > (list #:imported-modules > '((guix build gnu-build-system) (guix build copy-build-system)) > #:phases > #~(modify-phases > (add-after 'install 'delete-library > (lambda _ > (delete-file-recursively (string-append #$output "/lib")))) > (add-after 'install 'delete-private-header > (lambda _ > (delete-file-recursively (string-append #$output "/lib")))) Why is 'delete-private-header the same as 'delete-library? Was it a typo, and supposed to delete something else("include/private"?) > (add-after 'install 'install-private > (lambda arguments > ((@ (guix build copy-build-system) install) > (append (list #:install-plan '(("include/config.h" [...]) [...])) > arguments)))))))) > (synopsis ...) > (description ...))) Thanks, this looks much better than what I wrote. I didn't know how I could inherit it from libgc. I can use this in the V1 for this patch.