From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KBn5OAd+fGFG8QAAgWs5BA (envelope-from ) for ; Sat, 30 Oct 2021 01:04:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8OyONAd+fGGHcAAAbx9fmQ (envelope-from ) for ; Fri, 29 Oct 2021 23:04:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 86264E866 for ; Sat, 30 Oct 2021 01:04:39 +0200 (CEST) Received: from localhost ([::1]:59904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgavO-0002dZ-Km for larch@yhetil.org; Fri, 29 Oct 2021 19:04:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgauo-0001mz-OG for guix-patches@gnu.org; Fri, 29 Oct 2021 19:04:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgauo-000744-Fy for guix-patches@gnu.org; Fri, 29 Oct 2021 19:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgauo-0000QR-9e for guix-patches@gnu.org; Fri, 29 Oct 2021 19:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48046] [PATCH]: Gnu add astropy Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 Oct 2021 23:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48046 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sharlatan Hellseher , 48046@debbugs.gnu.org Received: via spool by 48046-submit@debbugs.gnu.org id=B48046.16355486181597 (code B ref 48046); Fri, 29 Oct 2021 23:04:02 +0000 Received: (at 48046) by debbugs.gnu.org; 29 Oct 2021 23:03:38 +0000 Received: from localhost ([127.0.0.1]:56242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgauP-0000Ph-Ib for submit@debbugs.gnu.org; Fri, 29 Oct 2021 19:03:37 -0400 Received: from mout02.posteo.de ([185.67.36.66]:52109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgauJ-0000PI-H5 for 48046@debbugs.gnu.org; Fri, 29 Oct 2021 19:03:35 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id BD352240104 for <48046@debbugs.gnu.org>; Sat, 30 Oct 2021 01:03:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1635548604; bh=0XzGlDYn4bCfhkSPzXnJvRXYp40ihKPoC3IUDxgdUb0=; h=Subject:From:To:Date:From; b=NRTmtjHgT943K6eXgDXZLGN7sTqfSuQ4tbjb923lUYzD68pSB3GFX6wpzyRslI4eP sx4astgwWkrKRfVhSAIPoXZSZpXPmz+ayuhF16eYnCW/af5sKUUCf8g/2SMmKR9MxG a2PsX47gg6t52c3JE5Z2rjLYyYr8e6bhuXr2fPc7w4ko7RaVIBpYradUSANCLMoDbe ZExL1mwihYwbCGrVJppX6rK1X+SIL+bYjM70lxl6ArSLeUWWJFujIrUMJ1XZRENgjZ Uy005cCIdtxI9Pn95DyoeEvd/EF3wt6v5XwKWTGCFzEGj+alLHRt7b21kwa2y39XPm kKtt6IJBFoCFg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Hgydk2kNjz6tm5; Sat, 30 Oct 2021 01:03:22 +0200 (CEST) Message-ID: From: Vinicius Monego Date: Fri, 29 Oct 2021 22:58:45 +0000 In-Reply-To: References: <7055d87cdde449415e62f0b0c15d96deb378af67.camel@posteo.net> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635548679; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=f8ewHlWl6MItZN5cD3I1fVBp6PhNJuD/gh6GFRxAJe0=; b=MTlrkVudFMWzx2qzOHIt3aU7pwqu4kLJZ+ucB11xA/1AH+EnX3amH2Cae14laAxZXQnJv8 WPr7bSimerj4cbFEWXhwbOkzjs71tN4IoL+XqMpPvq2Dz2vdVMXwuMGNHiRhDTC28zbhtT OK3TywiA5lDnexC1w/CXZTrw9fcyJ9qqIBM+SNsQI0JKjMnpVaqlSpdBUvVp2GUNEoepZn Qo1LMIroUgA9UUYgF7wEMQa9exFB4cNCfHyseY/oMT+HmZcQhiBwa0sJJYzSPmb+y6MCIn uS3wusdmO50o+npHEWUv7oXHcI3KuYaxOsPolf3Ghz4bSJJeR4z1PfTWdt6o2A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635548679; a=rsa-sha256; cv=none; b=AcNFBAEQg7btG465wWq3/q+KWE01FjcbD7nDZpov/5wY/+yo1lVkZi9b6w7jCga4EozPrJ 4Lr78Pf8Pq+urFPzS7LGAJ0jPGALBx4+JPsXm4pOsgyrQ7FQVr8BYbAl1E5sqUxkhCoU5c lDotxJ6SJe+AQXHrciT6R3ilbCFQebW7vJNqX5P00yJvaLEOrScUPCMnOl0PMvFDqoshg+ 42dexoRtUN+8KJVK6VN4yEcedyA7lAILgehn0Qw9pcFIbT9ta2B93tNG3T3Wva8M0+Ks7J cjt/pf2ziy5N2M5TnXNEWgSAZ5KyodUwCcksugM7yltASztiWTUT4/9zHkf+wQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=NRTmtjHg; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=NRTmtjHg; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 86264E866 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3/nNkkxw41ZS Hi Sharlatan, I was looking at this series once again and there are some fixes I will have to do in a resubmission. The main problem right now is that astropy is tied to a specific wcs version that it bundles. The code can't compile with the 7.5 version in Guix. Astropy 4.2 comes with wcs 7.3 and 4.3 comes with wcs 7.6. I tried to update wcs in guix to 7.6 but tests failed in this version. Not sure what is the best approach in this, packaging a separate wcs at 7.3 and keep astropy at 4.2.1, or use the bundle. Anyway, I'll submit this series again later. Vinicius Em sex, 2021-10-29 às 22:35 +0100, Sharlatan Hellseher escreveu: > Hi Guix team! > > Is this set of patches still in review or just dromaint :)? > > Regards > > On Sun, 23 May 2021 at 21:01, Sharlatan Hellseher > wrote: > > > > Hi Vinicius, > > > > It' fantastic! Thanks for your feedback and modification, I'm > > absolutely ok with them. > > > > When astropy is accepted it will open a way for other astronomical > > packages which are depend on it, > > and I've noticed some other packages in master require astropy for > > tests so it would beneficial to have it merged :)! > > > > On Sun, 23 May 2021 at 17:54, Vinicius Monego > > wrote: > > > > > > Hi Sharlatan, > > > > > > Thanks for continuing the work on the astropy package, I managed > > > to > > > finish it this time. I am resending your patch with the following > > > modifications: > > > > > > - Moved the package definition from the bottom to the middle of > > > the > > > file (to avoid merge conflicts) > > > - Removed all optional inputs and propagated the remaining. I > > > left only > > > those listed in install_requires, setup_requires, test_requires > > > and > > > test[extras] in setup.cfg > > > - Changed synopsis and description > > > - Changed package labels to match the package name > > > - Made the compiler file writable instead of deleting it > > > - Deleted the makdir-astropy phase (it wasn't needed) > > > - Added license for the jquery bundle that is not replaced > > > > > > and then I made my own improvements on that patch: enabling tests > > > and > > > unbundling some external libraries. > > > > > > I removed the optional packages because astropy is a core > > > package, > > > which will be a dependency for its many extensions. It's > > > important that > > > it builds with a high probability of success or the chain will > > > break. > > > Some of its optional dependencies, e.g. Pandas, have a broken > > > build in > > > aarch64 at the moment. The "full" astropy package could be > > > installed > > > easily from a manifest file and the tests can run again with > > > astropy.test(). > > > > > > > the project heavily depends on TOX which requires pip to > > > > install > > > > missing dependencies for itself. > > > > > > I don't think that a project can heavily depend on tox, all it > > > does is > > > manage a virtual environment with dependencies to run the tests. > > > Guix > > > does the same so tox is redundant here. Tests will still run with > > > the > > > testing framework. > > > > > > Two more suggestions for future Python patches: > > > > > > > +         (replace 'check > > > > +           (lambda* (#:key inputs outputs #:allow-other-keys) > > > > +             (add-installed-pythonpath inputs outputs) > > > > +             (invoke "pytest" "-vv"))) > > > > > > When a project contains tests as part of the application code, as > > > in > > > Astropy, tests should run with "pytest --pyargs module". See > > > Pytest > > > Integration Pratices: > > > https://docs.pytest.org/en/documentation-restructure/background/goodpractices.html > > > > > > It's also good practice in Guix to use (when tests?) when > > > overriding > > > the check phase to allow --without-tests=pkg. > > > > > > > ImportError: You appear to be trying to import astropy from > > > > within a > > > > source checkout or from an editable installation without > > > > building the > > > > extension modules first. Either run: > > > > > > I fixed this error by running the second command before the > > > tests. > > > > > > If you don't mind the modifications I did, I will call this > > > patchset > > > complete and wait for a committer to review. > > > > > > Vinicius > > > > > > > > -- > > > > … наш разум - превосходная объяснительная машина которая способна > > найти смысл почти в чем угодно, истолковать любой феномен, но > > совершенно не в состоянии принять мысль о непредсказуемости. > > >