unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#54513] [PATCH] gnu: murmur-shepherd-service: Fix binary name
@ 2022-03-21 21:42 fesoj000
  2022-03-23 20:01 ` Liliana Marie Prikler
  2022-03-24 11:47 ` bug#54513: " Ludovic Courtès
  0 siblings, 2 replies; 3+ messages in thread
From: fesoj000 @ 2022-03-21 21:42 UTC (permalink / raw)
  To: 54513

* gnu/services/telephony.scm: murmur-shepherd-service (start): fixed
binary path of mumble server, which is now called mumble-server instead
of murmurd since version 1.4.x
---
  gnu/services/telephony.scm | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/telephony.scm b/gnu/services/telephony.scm
index e678bae87c..d09877aedf 100644
--- a/gnu/services/telephony.scm
+++ b/gnu/services/telephony.scm
@@ -961,7 +961,7 @@ (define (murmur-shepherd-service config)
           (requirement '(networking))
           (start #~(make-forkexec-constructor
                     '(#$(file-append (murmur-configuration-package config)
-                                    "/bin/murmurd")
+                                    "/bin/mumble-server")
                       "-ini"
                       #$(or (murmur-configuration-file config)
                             (default-murmur-config config)))
-- 
2.34.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#54513] [PATCH] gnu: murmur-shepherd-service: Fix binary name
  2022-03-21 21:42 [bug#54513] [PATCH] gnu: murmur-shepherd-service: Fix binary name fesoj000
@ 2022-03-23 20:01 ` Liliana Marie Prikler
  2022-03-24 11:47 ` bug#54513: " Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: Liliana Marie Prikler @ 2022-03-23 20:01 UTC (permalink / raw)
  To: fesoj000, 54513

Am Montag, dem 21.03.2022 um 22:42 +0100 schrieb fesoj000:
> * gnu/services/telephony.scm: murmur-shepherd-service (start): fixed
> binary path of mumble server, which is now called mumble-server
> instead of murmurd since version 1.4.x
Nice catch, but perhaps we should rename the entire service and place a
deprecation notice at the appropriate location.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#54513: [PATCH] gnu: murmur-shepherd-service: Fix binary name
  2022-03-21 21:42 [bug#54513] [PATCH] gnu: murmur-shepherd-service: Fix binary name fesoj000
  2022-03-23 20:01 ` Liliana Marie Prikler
@ 2022-03-24 11:47 ` Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2022-03-24 11:47 UTC (permalink / raw)
  To: fesoj000; +Cc: 54513-done

Hi,

fesoj000 <fesoj000@gmail.com> skribis:

> * gnu/services/telephony.scm: murmur-shepherd-service (start): fixed
> binary path of mumble server, which is now called mumble-server instead
> of murmurd since version 1.4.x

[...]

>            (start #~(make-forkexec-constructor
>                      '(#$(file-append (murmur-configuration-package config)
> -                                    "/bin/murmurd")
> +                                    "/bin/mumble-server")

There was a second instance of this that I fixed; I adjusted the commit
log and commit that.

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> Nice catch, but perhaps we should rename the entire service and place a
> deprecation notice at the appropriate location.

Yes, that would be a welcome change.

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-03-24 11:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-21 21:42 [bug#54513] [PATCH] gnu: murmur-shepherd-service: Fix binary name fesoj000
2022-03-23 20:01 ` Liliana Marie Prikler
2022-03-24 11:47 ` bug#54513: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).